[INFO] updating cached repository m0ppers/rpck
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/m0ppers/rpck
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/m0ppers/rpck" "work/ex/clippy-test-run/sources/stable/gh/m0ppers/rpck"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/m0ppers/rpck'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/m0ppers/rpck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m0ppers/rpck"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m0ppers/rpck'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 154a60603972de971cabcfe69f9873932e16c66e
[INFO] sha for GitHub repo m0ppers/rpck: 154a60603972de971cabcfe69f9873932e16c66e
[INFO] validating manifest of m0ppers/rpck on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of m0ppers/rpck on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing m0ppers/rpck
[INFO] finished frobbing m0ppers/rpck
[INFO] frobbed toml for m0ppers/rpck written to work/ex/clippy-test-run/sources/stable/gh/m0ppers/rpck/Cargo.toml
[INFO] started frobbing m0ppers/rpck
[INFO] finished frobbing m0ppers/rpck
[INFO] frobbed toml for m0ppers/rpck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m0ppers/rpck/Cargo.toml
[INFO] crate m0ppers/rpck has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting m0ppers/rpck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m0ppers/rpck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f6d7bd203b210879ba0dc0b05bf9fa9d5f6a0b86a954a711a57602554d20185d
[INFO] running `"docker" "start" "-a" "f6d7bd203b210879ba0dc0b05bf9fa9d5f6a0b86a954a711a57602554d20185d"`
[INFO] [stderr]     Checking rpck v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:92:33
[INFO] [stderr]    |
[INFO] [stderr] 92 |                                 data: data,
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:103:33
[INFO] [stderr]     |
[INFO] [stderr] 103 |                                 num: num,
[INFO] [stderr]     |                                 ^^^^^^^^ help: replace it with: `num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:92:33
[INFO] [stderr]    |
[INFO] [stderr] 92 |                                 data: data,
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:103:33
[INFO] [stderr]     |
[INFO] [stderr] 103 |                                 num: num,
[INFO] [stderr]     |                                 ^^^^^^^^ help: replace it with: `num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Negation by multiplying with -1
[INFO] [stderr]   --> src/lib.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |             try!(target.write_i8((data.len() as i32 * -1) as i8));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::neg_multiply)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:81:33
[INFO] [stderr]    |
[INFO] [stderr] 81 | /                                 written = written + try!(write_chunk(Chunk::Unique {
[INFO] [stderr] 82 | |                                     data: data,
[INFO] [stderr] 83 | |                                 }, &mut writeable));
[INFO] [stderr]    | |___________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]    |
[INFO] [stderr] 81 |                                 written += match $ expr {
[INFO] [stderr] 82 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 83 | :: Err ( err ) => {
[INFO] [stderr] 84 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 85 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:106:29
[INFO] [stderr]     |
[INFO] [stderr] 106 |                             written = written + try!(write_chunk(current, &mut writeable));
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 106 |                             written += match $ expr {
[INFO] [stderr] 107 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 108 | :: Err ( err ) => {
[INFO] [stderr] 109 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 110 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:114:21
[INFO] [stderr]     |
[INFO] [stderr] 114 |                     written = written + try!(write_chunk(chunk, &mut writeable));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 114 |                     written += match $ expr {
[INFO] [stderr] 115 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 116 | :: Err ( err ) => {
[INFO] [stderr] 117 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 118 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 |         written = written + try!(write_chunk(current.unwrap(), &mut writeable));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 123 |         written += match $ expr {
[INFO] [stderr] 124 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 125 | :: Err ( err ) => {
[INFO] [stderr] 126 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 127 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Negation by multiplying with -1
[INFO] [stderr]   --> src/lib.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |             try!(target.write_i8((data.len() as i32 * -1) as i8));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::neg_multiply)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:81:33
[INFO] [stderr]    |
[INFO] [stderr] 81 | /                                 written = written + try!(write_chunk(Chunk::Unique {
[INFO] [stderr] 82 | |                                     data: data,
[INFO] [stderr] 83 | |                                 }, &mut writeable));
[INFO] [stderr]    | |___________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]    |
[INFO] [stderr] 81 |                                 written += match $ expr {
[INFO] [stderr] 82 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 83 | :: Err ( err ) => {
[INFO] [stderr] 84 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 85 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:106:29
[INFO] [stderr]     |
[INFO] [stderr] 106 |                             written = written + try!(write_chunk(current, &mut writeable));
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 106 |                             written += match $ expr {
[INFO] [stderr] 107 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 108 | :: Err ( err ) => {
[INFO] [stderr] 109 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 110 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:114:21
[INFO] [stderr]     |
[INFO] [stderr] 114 |                     written = written + try!(write_chunk(chunk, &mut writeable));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 114 |                     written += match $ expr {
[INFO] [stderr] 115 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 116 | :: Err ( err ) => {
[INFO] [stderr] 117 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 118 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 |         written = written + try!(write_chunk(current.unwrap(), &mut writeable));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] help: replace it with
[INFO] [stderr]     |
[INFO] [stderr] 123 |         written += match $ expr {
[INFO] [stderr] 124 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 125 | :: Err ( err ) => {
[INFO] [stderr] 126 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 127 | $ crate :: convert :: From :: from ( err ) ) } };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bin/rpck.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     match rpck::archive(rfile, metadata.len(), wfile) {
[INFO] [stderr] 47 | |         Err(why) => panic!("couldn't write: {}", why.description()),
[INFO] [stderr] 48 | |         Ok(_) => ()
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(why) = rpck::archive(rfile, metadata.len(), wfile) { panic!("couldn't write: {}", why.description()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bin/rpck.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     match rpck::archive(rfile, metadata.len(), wfile) {
[INFO] [stderr] 47 | |         Err(why) => panic!("couldn't write: {}", why.description()),
[INFO] [stderr] 48 | |         Ok(_) => ()
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(why) = rpck::archive(rfile, metadata.len(), wfile) { panic!("couldn't write: {}", why.description()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.76s
[INFO] running `"docker" "inspect" "f6d7bd203b210879ba0dc0b05bf9fa9d5f6a0b86a954a711a57602554d20185d"`
[INFO] running `"docker" "rm" "-f" "f6d7bd203b210879ba0dc0b05bf9fa9d5f6a0b86a954a711a57602554d20185d"`
[INFO] [stdout] f6d7bd203b210879ba0dc0b05bf9fa9d5f6a0b86a954a711a57602554d20185d