[INFO] updating cached repository m-ou-se/ninj [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/m-ou-se/ninj [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/m-ou-se/ninj" "work/ex/clippy-test-run/sources/stable/gh/m-ou-se/ninj"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/m-ou-se/ninj'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/m-ou-se/ninj" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m-ou-se/ninj"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m-ou-se/ninj'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bfb4a34548a1d3d03275bf5e6cfcd6b2450c4553 [INFO] sha for GitHub repo m-ou-se/ninj: bfb4a34548a1d3d03275bf5e6cfcd6b2450c4553 [INFO] validating manifest of m-ou-se/ninj on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of m-ou-se/ninj on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing m-ou-se/ninj [INFO] finished frobbing m-ou-se/ninj [INFO] frobbed toml for m-ou-se/ninj written to work/ex/clippy-test-run/sources/stable/gh/m-ou-se/ninj/Cargo.toml [INFO] started frobbing m-ou-se/ninj [INFO] finished frobbing m-ou-se/ninj [INFO] frobbed toml for m-ou-se/ninj written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m-ou-se/ninj/Cargo.toml [INFO] crate m-ou-se/ninj has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting m-ou-se/ninj against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/m-ou-se/ninj:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0b58870ae293972e9795921da4146d43051e366ceba1cdfb6fe6ad384273ec4 [INFO] running `"docker" "start" "-a" "b0b58870ae293972e9795921da4146d43051e366ceba1cdfb6fe6ad384273ec4"` [INFO] [stderr] Checking raw-string v0.3.1 [INFO] [stderr] Checking pile v0.1.0 [INFO] [stderr] Checking ninj v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec/parse.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec/parse.rs:63:4 [INFO] [stderr] | [INFO] [stderr] 63 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec/parse.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec/parse.rs:63:4 [INFO] [stderr] | [INFO] [stderr] 63 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/eat.rs:21:6 [INFO] [stderr] | [INFO] [stderr] 21 | }).unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/eat.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | .unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/eat.rs:67:6 [INFO] [stderr] | [INFO] [stderr] 67 | }).unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/spec/expand.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | fn is_shell_safe(c: &u8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/spec/expand.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(match scope.lookup_var(var_name) { [INFO] [stderr] | ________^ [INFO] [stderr] 118 | | Some(FoundVar::Expanded(e)) => result.push_str(e), [INFO] [stderr] 119 | | Some(FoundVar::Paths { paths, newlines }) => { [INFO] [stderr] 120 | | for (i, p) in paths.iter().enumerate() { [INFO] [stderr] ... | [INFO] [stderr] 142 | | None => {} [INFO] [stderr] 143 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 117 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/expand.rs:172:65 [INFO] [stderr] | [INFO] [stderr] 172 | let n = source.bytes().position(|b| b != b' ' && b != b'\t').unwrap_or(source.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| source.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `spec::scope::FileScope<'a, 'p>` [INFO] [stderr] --> src/spec/scope.rs:155:2 [INFO] [stderr] | [INFO] [stderr] 155 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 156 | | FileScope { [INFO] [stderr] 157 | | parent_scope: None, [INFO] [stderr] 158 | | vars: Vec::new(), [INFO] [stderr] 159 | | rules: Vec::new(), [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `spec::Spec` [INFO] [stderr] --> src/spec/mod.rs:78:2 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 79 | | Spec { [INFO] [stderr] 80 | | build_rules: Vec::new(), [INFO] [stderr] 81 | | default_targets: Vec::new(), [INFO] [stderr] 82 | | build_dir: RawString::new(), [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/eat.rs:21:6 [INFO] [stderr] | [INFO] [stderr] 21 | }).unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/eat.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | .unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/eat.rs:67:6 [INFO] [stderr] | [INFO] [stderr] 67 | }).unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/spec/expand.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | fn is_shell_safe(c: &u8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/spec/expand.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(match scope.lookup_var(var_name) { [INFO] [stderr] | ________^ [INFO] [stderr] 118 | | Some(FoundVar::Expanded(e)) => result.push_str(e), [INFO] [stderr] 119 | | Some(FoundVar::Paths { paths, newlines }) => { [INFO] [stderr] 120 | | for (i, p) in paths.iter().enumerate() { [INFO] [stderr] ... | [INFO] [stderr] 142 | | None => {} [INFO] [stderr] 143 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 117 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/expand.rs:172:65 [INFO] [stderr] | [INFO] [stderr] 172 | let n = source.bytes().position(|b| b != b' ' && b != b'\t').unwrap_or(source.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| source.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `spec::scope::FileScope<'a, 'p>` [INFO] [stderr] --> src/spec/scope.rs:155:2 [INFO] [stderr] | [INFO] [stderr] 155 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 156 | | FileScope { [INFO] [stderr] 157 | | parent_scope: None, [INFO] [stderr] 158 | | vars: Vec::new(), [INFO] [stderr] 159 | | rules: Vec::new(), [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `spec::Spec` [INFO] [stderr] --> src/spec/mod.rs:78:2 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 79 | | Spec { [INFO] [stderr] 80 | | build_rules: Vec::new(), [INFO] [stderr] 81 | | default_targets: Vec::new(), [INFO] [stderr] 82 | | build_dir: RawString::new(), [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.82s [INFO] running `"docker" "inspect" "b0b58870ae293972e9795921da4146d43051e366ceba1cdfb6fe6ad384273ec4"` [INFO] running `"docker" "rm" "-f" "b0b58870ae293972e9795921da4146d43051e366ceba1cdfb6fe6ad384273ec4"` [INFO] [stdout] b0b58870ae293972e9795921da4146d43051e366ceba1cdfb6fe6ad384273ec4