[INFO] updating cached repository lvillani/aoc2018-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lvillani/aoc2018-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lvillani/aoc2018-rs" "work/ex/clippy-test-run/sources/stable/gh/lvillani/aoc2018-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lvillani/aoc2018-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lvillani/aoc2018-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lvillani/aoc2018-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lvillani/aoc2018-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9317642d52ccc4aa163daa73d868f61f209a776d [INFO] sha for GitHub repo lvillani/aoc2018-rs: 9317642d52ccc4aa163daa73d868f61f209a776d [INFO] validating manifest of lvillani/aoc2018-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lvillani/aoc2018-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lvillani/aoc2018-rs [INFO] finished frobbing lvillani/aoc2018-rs [INFO] frobbed toml for lvillani/aoc2018-rs written to work/ex/clippy-test-run/sources/stable/gh/lvillani/aoc2018-rs/Cargo.toml [INFO] started frobbing lvillani/aoc2018-rs [INFO] finished frobbing lvillani/aoc2018-rs [INFO] frobbed toml for lvillani/aoc2018-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lvillani/aoc2018-rs/Cargo.toml [INFO] crate lvillani/aoc2018-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lvillani/aoc2018-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lvillani/aoc2018-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 144dc8b61f8b1c233d075a0a42f20910a2c181f5d05e121d393bc4086b83db28 [INFO] running `"docker" "start" "-a" "144dc8b61f8b1c233d075a0a42f20910a2c181f5d05e121d393bc4086b83db28"` [INFO] [stderr] Checking aoc2018-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/day1.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | const INPUT_DAY1: &'static str = "tests/inputs/day1.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/day2.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | const INPUT_DAY2: &'static str = "tests/inputs/day2.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> tests/day1.rs:9:50 [INFO] [stderr] | [INFO] [stderr] 9 | let result = gimme_numbers(INPUT_DAY1).iter().fold(0, |acc, x| acc + x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> tests/day2.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | fn gimme_lines<'a>(path: impl AsRef) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `"docker" "inspect" "144dc8b61f8b1c233d075a0a42f20910a2c181f5d05e121d393bc4086b83db28"` [INFO] running `"docker" "rm" "-f" "144dc8b61f8b1c233d075a0a42f20910a2c181f5d05e121d393bc4086b83db28"` [INFO] [stdout] 144dc8b61f8b1c233d075a0a42f20910a2c181f5d05e121d393bc4086b83db28