[INFO] updating cached repository luki/calc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luki/calc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luki/calc" "work/ex/clippy-test-run/sources/stable/gh/luki/calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luki/calc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luki/calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luki/calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luki/calc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e94a9c6cdbcbee76e3fa3ec0df01c6336628f919 [INFO] sha for GitHub repo luki/calc: e94a9c6cdbcbee76e3fa3ec0df01c6336628f919 [INFO] validating manifest of luki/calc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luki/calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luki/calc [INFO] finished frobbing luki/calc [INFO] frobbed toml for luki/calc written to work/ex/clippy-test-run/sources/stable/gh/luki/calc/Cargo.toml [INFO] started frobbing luki/calc [INFO] finished frobbing luki/calc [INFO] frobbed toml for luki/calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luki/calc/Cargo.toml [INFO] crate luki/calc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luki/calc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luki/calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7189639e07ee5022c84cf69eb4fc1376270ab4abb1163e93400c7d95b14fd2bd [INFO] running `"docker" "start" "-a" "7189639e07ee5022c84cf69eb4fc1376270ab4abb1163e93400c7d95b14fd2bd"` [INFO] [stderr] Checking calc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `calc` [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let calc = Calc::new(); [INFO] [stderr] | ^^^^ help: consider using `_calc` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Add` [INFO] [stderr] --> src/operations.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Add, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Subtract` [INFO] [stderr] --> src/operations.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Subtract, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Multiply` [INFO] [stderr] --> src/operations.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Multiply, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Divide` [INFO] [stderr] --> src/operations.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | Divide [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn add(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:7:32 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn add(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn subtract(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn subtract(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn multiply(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn multiply(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn divide(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn divide(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match op { [INFO] [stderr] 32 | | &Op::Add => with_op(add, nums), [INFO] [stderr] 33 | | &Op::Subtract => with_op(subtract, nums), [INFO] [stderr] 34 | | &Op::Multiply => with_op(multiply, nums), [INFO] [stderr] 35 | | &Op::Divide => with_op(divide, nums) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *op { [INFO] [stderr] 32 | Op::Add => with_op(add, nums), [INFO] [stderr] 33 | Op::Subtract => with_op(subtract, nums), [INFO] [stderr] 34 | Op::Multiply => with_op(multiply, nums), [INFO] [stderr] 35 | Op::Divide => with_op(divide, nums) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `calc` [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let calc = Calc::new(); [INFO] [stderr] | ^^^^ help: consider using `_calc` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Add` [INFO] [stderr] --> src/operations.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Add, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Subtract` [INFO] [stderr] --> src/operations.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Subtract, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Multiply` [INFO] [stderr] --> src/operations.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | Multiply, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Divide` [INFO] [stderr] --> src/operations.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | Divide [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn add(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:7:32 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn add(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn subtract(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn subtract(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn multiply(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn multiply(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn divide(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/operations.rs:19:35 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn divide(num1: &usize, num2: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match op { [INFO] [stderr] 32 | | &Op::Add => with_op(add, nums), [INFO] [stderr] 33 | | &Op::Subtract => with_op(subtract, nums), [INFO] [stderr] 34 | | &Op::Multiply => with_op(multiply, nums), [INFO] [stderr] 35 | | &Op::Divide => with_op(divide, nums) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *op { [INFO] [stderr] 32 | Op::Add => with_op(add, nums), [INFO] [stderr] 33 | Op::Subtract => with_op(subtract, nums), [INFO] [stderr] 34 | Op::Multiply => with_op(multiply, nums), [INFO] [stderr] 35 | Op::Divide => with_op(divide, nums) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `"docker" "inspect" "7189639e07ee5022c84cf69eb4fc1376270ab4abb1163e93400c7d95b14fd2bd"` [INFO] running `"docker" "rm" "-f" "7189639e07ee5022c84cf69eb4fc1376270ab4abb1163e93400c7d95b14fd2bd"` [INFO] [stdout] 7189639e07ee5022c84cf69eb4fc1376270ab4abb1163e93400c7d95b14fd2bd