[INFO] updating cached repository lukad/rbf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lukad/rbf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lukad/rbf" "work/ex/clippy-test-run/sources/stable/gh/lukad/rbf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lukad/rbf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lukad/rbf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukad/rbf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukad/rbf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2287a5f21a40a14675178cd36bc1758e4d159660 [INFO] sha for GitHub repo lukad/rbf: 2287a5f21a40a14675178cd36bc1758e4d159660 [INFO] validating manifest of lukad/rbf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lukad/rbf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lukad/rbf [INFO] finished frobbing lukad/rbf [INFO] frobbed toml for lukad/rbf written to work/ex/clippy-test-run/sources/stable/gh/lukad/rbf/Cargo.toml [INFO] started frobbing lukad/rbf [INFO] finished frobbing lukad/rbf [INFO] frobbed toml for lukad/rbf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukad/rbf/Cargo.toml [INFO] crate lukad/rbf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lukad/rbf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lukad/rbf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c50faf2f0552115cbed9cd8bfff72e27febe97ad0e26439c43c16b8821f7e16 [INFO] running `"docker" "start" "-a" "0c50faf2f0552115cbed9cd8bfff72e27febe97ad0e26439c43c16b8821f7e16"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking combine v3.4.0 [INFO] [stderr] Checking rbf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `program { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `program { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `program { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `program { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `program { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `program { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(program: &'a Program) -> Machine { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | fn r(&mut self, prog: &Program) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/machine.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | while let Some(ins) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for ins in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(program: &'a Program) -> Machine { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | fn r(&mut self, prog: &Program) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/machine.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | while let Some(ins) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for ins in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / parser!{ [INFO] [stderr] 8 | | #[inline(always)] [INFO] [stderr] 9 | | fn program[I]()(I) -> Program [INFO] [stderr] 10 | | where [I: Stream] [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.71s [INFO] running `"docker" "inspect" "0c50faf2f0552115cbed9cd8bfff72e27febe97ad0e26439c43c16b8821f7e16"` [INFO] running `"docker" "rm" "-f" "0c50faf2f0552115cbed9cd8bfff72e27febe97ad0e26439c43c16b8821f7e16"` [INFO] [stdout] 0c50faf2f0552115cbed9cd8bfff72e27febe97ad0e26439c43c16b8821f7e16