[INFO] updating cached repository luckyuro/rsKata
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/luckyuro/rsKata
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/luckyuro/rsKata" "work/ex/clippy-test-run/sources/stable/gh/luckyuro/rsKata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luckyuro/rsKata'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/luckyuro/rsKata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luckyuro/rsKata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luckyuro/rsKata'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 197a1c32e87f5220e2a3d070d6becd4ef3e56416
[INFO] sha for GitHub repo luckyuro/rsKata: 197a1c32e87f5220e2a3d070d6becd4ef3e56416
[INFO] validating manifest of luckyuro/rsKata on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of luckyuro/rsKata on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing luckyuro/rsKata
[INFO] finished frobbing luckyuro/rsKata
[INFO] frobbed toml for luckyuro/rsKata written to work/ex/clippy-test-run/sources/stable/gh/luckyuro/rsKata/Cargo.toml
[INFO] started frobbing luckyuro/rsKata
[INFO] finished frobbing luckyuro/rsKata
[INFO] frobbed toml for luckyuro/rsKata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luckyuro/rsKata/Cargo.toml
[INFO] crate luckyuro/rsKata has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting luckyuro/rsKata against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luckyuro/rsKata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d36e4a6bd27524c6da6103a35acbaa93a4ed9bb9ef5b40c6b49f8dfbf14cf184
[INFO] running `"docker" "start" "-a" "d36e4a6bd27524c6da6103a35acbaa93a4ed9bb9ef5b40c6b49f8dfbf14cf184"`
[INFO] [stderr]     Checking kata v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/half_step.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         return mid - 0.5;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mid - 0.5`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/half_step.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         return mid + 0.5;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mid + 0.5`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/half_step.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return mid;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `mid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/new_benefactor.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/new_benefactor.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return Some(ans.ceil() as i32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ans.ceil() as i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/half_step.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         return mid - 0.5;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mid - 0.5`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/half_step.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         return mid + 0.5;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mid + 0.5`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/half_step.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return mid;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `mid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/new_benefactor.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/katas/new_benefactor.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return Some(ans.ceil() as i32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ans.ceil() as i32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/katas/divisors.rs:8:14
[INFO] [stderr]   |
[INFO] [stderr] 8 |     for i in 2u32..integer/2+1{
[INFO] [stderr]   |              ^^^^^^^^^^^^^^^^^ help: use: `2u32..=integer/2`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/katas/divisors.rs:13:8
[INFO] [stderr]    |
[INFO] [stderr] 13 |     if ret.len() == 0{
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ret.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/katas/dec_digits.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         mn = mn/10;
[INFO] [stderr]    |         ^^^^^^^^^^ help: replace it with: `mn /= 10`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]  --> src/katas/half_step.rs:7:15
[INFO] [stderr]   |
[INFO] [stderr] 7 |     let mid = (n as i32) as f64 + 0.5;
[INFO] [stderr]   |               ^^^^^^^^^^^^^^^^^ help: try: `f64::from((n as i32))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]  --> src/katas/consecutive_strings.rs:8:27
[INFO] [stderr]   |
[INFO] [stderr] 8 |     if l == 0 || k > l || k <= 0 {
[INFO] [stderr]   |                           ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]   = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using k == 0 instead
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `strarr`.
[INFO] [stderr]   --> src/katas/consecutive_strings.rs:13:14
[INFO] [stderr]    |
[INFO] [stderr] 13 |     for i in 0..k {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 13 |     for <item> in strarr.iter().take(k) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/katas/consecutive_strings.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |     for i in 1..l-k+1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `1..=l-k`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/katas/move_squared_strings.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |         .map(|x| String::from(x))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `kata`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/katas/divisors.rs:8:14
[INFO] [stderr]   |
[INFO] [stderr] 8 |     for i in 2u32..integer/2+1{
[INFO] [stderr]   |              ^^^^^^^^^^^^^^^^^ help: use: `2u32..=integer/2`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/katas/divisors.rs:13:8
[INFO] [stderr]    |
[INFO] [stderr] 13 |     if ret.len() == 0{
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ret.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/katas/dec_digits.rs:10:9
[INFO] [stderr]    |
[INFO] [stderr] 10 |         mn = mn/10;
[INFO] [stderr]    |         ^^^^^^^^^^ help: replace it with: `mn /= 10`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]  --> src/katas/half_step.rs:7:15
[INFO] [stderr]   |
[INFO] [stderr] 7 |     let mid = (n as i32) as f64 + 0.5;
[INFO] [stderr]   |               ^^^^^^^^^^^^^^^^^ help: try: `f64::from((n as i32))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]  --> src/katas/consecutive_strings.rs:8:27
[INFO] [stderr]   |
[INFO] [stderr] 8 |     if l == 0 || k > l || k <= 0 {
[INFO] [stderr]   |                           ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]   = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using k == 0 instead
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `strarr`.
[INFO] [stderr]   --> src/katas/consecutive_strings.rs:13:14
[INFO] [stderr]    |
[INFO] [stderr] 13 |     for i in 0..k {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 13 |     for <item> in strarr.iter().take(k) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/katas/consecutive_strings.rs:20:14
[INFO] [stderr]    |
[INFO] [stderr] 20 |     for i in 1..l-k+1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `1..=l-k`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/katas/move_squared_strings.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |         .map(|x| String::from(x))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `kata`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d36e4a6bd27524c6da6103a35acbaa93a4ed9bb9ef5b40c6b49f8dfbf14cf184"`
[INFO] running `"docker" "rm" "-f" "d36e4a6bd27524c6da6103a35acbaa93a4ed9bb9ef5b40c6b49f8dfbf14cf184"`
[INFO] [stdout] d36e4a6bd27524c6da6103a35acbaa93a4ed9bb9ef5b40c6b49f8dfbf14cf184