[INFO] updating cached repository luciusmagn/permutation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luciusmagn/permutation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luciusmagn/permutation" "work/ex/clippy-test-run/sources/stable/gh/luciusmagn/permutation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luciusmagn/permutation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luciusmagn/permutation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/permutation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/permutation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a133fbde6882b1df0a26aecc56c1e15627c400cd [INFO] sha for GitHub repo luciusmagn/permutation: a133fbde6882b1df0a26aecc56c1e15627c400cd [INFO] validating manifest of luciusmagn/permutation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luciusmagn/permutation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luciusmagn/permutation [INFO] finished frobbing luciusmagn/permutation [INFO] frobbed toml for luciusmagn/permutation written to work/ex/clippy-test-run/sources/stable/gh/luciusmagn/permutation/Cargo.toml [INFO] started frobbing luciusmagn/permutation [INFO] finished frobbing luciusmagn/permutation [INFO] frobbed toml for luciusmagn/permutation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/permutation/Cargo.toml [INFO] crate luciusmagn/permutation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luciusmagn/permutation against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luciusmagn/permutation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5cfb61be170b073802b8b95074ec60412ede7d79adbd499232fe8030378af70 [INFO] running `"docker" "start" "-a" "d5cfb61be170b073802b8b95074ec60412ede7d79adbd499232fe8030378af70"` [INFO] [stderr] Checking permutation v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | .map(|(pos, x)| Program { name: x, pos: pos }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | .map(|(pos, x)| Program { name: x, pos: pos }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | x.chars().skip(1).collect::().split('/').skip(1).next().expect("needs 2 arguments").parse::().expect("not a number"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | x.chars() [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 55 | | .skip(1) [INFO] [stderr] 56 | | .collect::() [INFO] [stderr] 57 | | .split('/') [INFO] [stderr] 58 | | .skip(1) [INFO] [stderr] 59 | | .next() [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | x.chars().skip(1).collect::().split('/').skip(1).next().expect("needs 2 arguments").parse::().expect("not a number"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | x.chars() [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 55 | | .skip(1) [INFO] [stderr] 56 | | .collect::() [INFO] [stderr] 57 | | .split('/') [INFO] [stderr] 58 | | .skip(1) [INFO] [stderr] 59 | | .next() [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "d5cfb61be170b073802b8b95074ec60412ede7d79adbd499232fe8030378af70"` [INFO] running `"docker" "rm" "-f" "d5cfb61be170b073802b8b95074ec60412ede7d79adbd499232fe8030378af70"` [INFO] [stdout] d5cfb61be170b073802b8b95074ec60412ede7d79adbd499232fe8030378af70