[INFO] updating cached repository lucascp/termite [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lucascp/termite [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lucascp/termite" "work/ex/clippy-test-run/sources/stable/gh/lucascp/termite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lucascp/termite'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lucascp/termite" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lucascp/termite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lucascp/termite'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 109eb247d972036f9c0be1bd8e5873ec5262af04 [INFO] sha for GitHub repo lucascp/termite: 109eb247d972036f9c0be1bd8e5873ec5262af04 [INFO] validating manifest of lucascp/termite on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lucascp/termite on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lucascp/termite [INFO] finished frobbing lucascp/termite [INFO] frobbed toml for lucascp/termite written to work/ex/clippy-test-run/sources/stable/gh/lucascp/termite/Cargo.toml [INFO] started frobbing lucascp/termite [INFO] finished frobbing lucascp/termite [INFO] frobbed toml for lucascp/termite written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lucascp/termite/Cargo.toml [INFO] crate lucascp/termite has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lucascp/termite against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lucascp/termite:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cfa3257f286b93d954df27ae38ac4054a590ef19662544e75934968da2a57406 [INFO] running `"docker" "start" "-a" "cfa3257f286b93d954df27ae38ac4054a590ef19662544e75934968da2a57406"` [INFO] [stderr] Checking strsim v0.5.2 [INFO] [stderr] Checking unicode-segmentation v0.1.3 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking termite v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/container.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/container.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shell.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | const PROMPT: &'static str = "λ "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shell.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | const PROMPT: &'static str = "λ "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable `tick_count` is assigned to, but never used [INFO] [stderr] --> src/main.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut tick_count: u64 = 0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_tick_count` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Container` [INFO] [stderr] --> src/container.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | struct Container { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/container.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | fn new(capacity: f64) -> Container { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Status` [INFO] [stderr] --> src/shell.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Status, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `tick_count` is assigned to, but never used [INFO] [stderr] --> src/main.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut tick_count: u64 = 0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_tick_count` instead [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/shell.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | if let Err(_) = matches { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 38 | | println!("Invalid command"); [INFO] [stderr] 39 | | continue; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________- help: try this: `if matches.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/shell.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(_) = matches.subcommand_matches("quit") { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 43 | | println!("Exiting termite"); [INFO] [stderr] 44 | | break; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("quit").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/shell.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / fn parse_input<'a>(input: &'a str) -> std::str::Split<'a, char> { [INFO] [stderr] 50 | | input.split(' ') [INFO] [stderr] 51 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Container` [INFO] [stderr] --> src/container.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | struct Container { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/container.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | fn new(capacity: f64) -> Container { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Status` [INFO] [stderr] --> src/shell.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Status, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/shell.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | if let Err(_) = matches { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 38 | | println!("Invalid command"); [INFO] [stderr] 39 | | continue; [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________- help: try this: `if matches.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/shell.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(_) = matches.subcommand_matches("quit") { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 43 | | println!("Exiting termite"); [INFO] [stderr] 44 | | break; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("quit").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/shell.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / fn parse_input<'a>(input: &'a str) -> std::str::Split<'a, char> { [INFO] [stderr] 50 | | input.split(' ') [INFO] [stderr] 51 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.14s [INFO] running `"docker" "inspect" "cfa3257f286b93d954df27ae38ac4054a590ef19662544e75934968da2a57406"` [INFO] running `"docker" "rm" "-f" "cfa3257f286b93d954df27ae38ac4054a590ef19662544e75934968da2a57406"` [INFO] [stdout] cfa3257f286b93d954df27ae38ac4054a590ef19662544e75934968da2a57406