[INFO] updating cached repository luan/raze [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/luan/raze [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/luan/raze" "work/ex/clippy-test-run/sources/stable/gh/luan/raze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/luan/raze'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/luan/raze" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luan/raze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luan/raze'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 566222ede8de1801bac2e6982306769b1ab1d9ec [INFO] sha for GitHub repo luan/raze: 566222ede8de1801bac2e6982306769b1ab1d9ec [INFO] validating manifest of luan/raze on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luan/raze on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luan/raze [INFO] finished frobbing luan/raze [INFO] frobbed toml for luan/raze written to work/ex/clippy-test-run/sources/stable/gh/luan/raze/Cargo.toml [INFO] started frobbing luan/raze [INFO] finished frobbing luan/raze [INFO] frobbed toml for luan/raze written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luan/raze/Cargo.toml [INFO] crate luan/raze has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luan/raze against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/luan/raze:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8d03c980c883dadaa3417fce35cccdf9d6a7250abb1f6320b16f7182dab18769 [INFO] running `"docker" "start" "-a" "8d03c980c883dadaa3417fce35cccdf9d6a7250abb1f6320b16f7182dab18769"` [INFO] [stderr] Checking raze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for y in 0..(2 * height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=2 * height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | for x in 0..(2 * width + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=2 * width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/direction.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn diff(&self) -> (i32, i32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/direction.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Direction::North => (0, -1), [INFO] [stderr] 27 | | &Direction::South => (0, 1), [INFO] [stderr] 28 | | &Direction::East => (1, 0), [INFO] [stderr] 29 | | &Direction::West => (-1, 0), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Direction::North => (0, -1), [INFO] [stderr] 27 | Direction::South => (0, 1), [INFO] [stderr] 28 | Direction::East => (1, 0), [INFO] [stderr] 29 | Direction::West => (-1, 0), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for y in 0..(2 * height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=2 * height` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | for x in 0..(2 * width + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=2 * width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/direction.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn diff(&self) -> (i32, i32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/direction.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Direction::North => (0, -1), [INFO] [stderr] 27 | | &Direction::South => (0, 1), [INFO] [stderr] 28 | | &Direction::East => (1, 0), [INFO] [stderr] 29 | | &Direction::West => (-1, 0), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Direction::North => (0, -1), [INFO] [stderr] 27 | Direction::South => (0, 1), [INFO] [stderr] 28 | Direction::East => (1, 0), [INFO] [stderr] 29 | Direction::West => (-1, 0), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "8d03c980c883dadaa3417fce35cccdf9d6a7250abb1f6320b16f7182dab18769"` [INFO] running `"docker" "rm" "-f" "8d03c980c883dadaa3417fce35cccdf9d6a7250abb1f6320b16f7182dab18769"` [INFO] [stdout] 8d03c980c883dadaa3417fce35cccdf9d6a7250abb1f6320b16f7182dab18769