[INFO] updating cached repository lreynolds18/cryptopals [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lreynolds18/cryptopals [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lreynolds18/cryptopals" "work/ex/clippy-test-run/sources/stable/gh/lreynolds18/cryptopals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lreynolds18/cryptopals'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lreynolds18/cryptopals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/cryptopals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/cryptopals'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ca45698352e224f5b07324ef270bf4eb368bb1f [INFO] sha for GitHub repo lreynolds18/cryptopals: 6ca45698352e224f5b07324ef270bf4eb368bb1f [INFO] validating manifest of lreynolds18/cryptopals on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lreynolds18/cryptopals on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lreynolds18/cryptopals [INFO] finished frobbing lreynolds18/cryptopals [INFO] frobbed toml for lreynolds18/cryptopals written to work/ex/clippy-test-run/sources/stable/gh/lreynolds18/cryptopals/Cargo.toml [INFO] started frobbing lreynolds18/cryptopals [INFO] finished frobbing lreynolds18/cryptopals [INFO] frobbed toml for lreynolds18/cryptopals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/cryptopals/Cargo.toml [INFO] crate lreynolds18/cryptopals has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lreynolds18/cryptopals against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/cryptopals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 82c395803ee075a0fb7c9b70ddd602e4368577d69d32b7190f85b568c24d1ce9 [INFO] running `"docker" "start" "-a" "82c395803ee075a0fb7c9b70ddd602e4368577d69d32b7190f85b568c24d1ce9"` [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | print!("Ans message: Now that the party is jumping\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | print!("Ans message: Now that the party is jumping\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/set1/helper.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | c += ((tmp & var) >> (7 - i as u8)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((tmp & var) >> (7 - i as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/set1/helper.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn char_freq(str_inp: &str, freq: &HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 175 | pub fn char_freq(str_inp: &str, freq: &HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/set1/helper.rs:179:24 [INFO] [stderr] | [INFO] [stderr] 179 | Some(f) => f.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/set1/helper.rs:218:39 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn get_aes_128_lookup_tables() -> (Vec, Vec, Vec, Vec, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:370:54 [INFO] [stderr] | [INFO] [stderr] 370 | pub fn inv_sub_bytes(state: &Storage, inverse_s_box: &Vec) -> Storage { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:397:12 [INFO] [stderr] | [INFO] [stderr] 397 | mul_9: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | mul_11: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | mul_13: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | mul_14: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: item `set1::storage::Storage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/set1/storage.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / impl Storage { [INFO] [stderr] 15 | | /* new -- empty constructor for storage [INFO] [stderr] 16 | | * Parameters: void [INFO] [stderr] 17 | | * Return: Storage (w/ data and data_type) [INFO] [stderr] ... | [INFO] [stderr] 429 | | } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `set1::storage::Storage` [INFO] [stderr] --> src/set1/storage.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Storage { [INFO] [stderr] 20 | | Storage { [INFO] [stderr] 21 | | data: Vec::new(), [INFO] [stderr] 22 | | data_type: String::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/storage.rs:45:34 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn new_init_vec(vec_inp: &Vec, data_type: &str) -> Storage { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/storage.rs:83:45 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn set_data_vec(&mut self, vec_inp: &Vec, data_type: &str) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/set1/storage.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn change_base(&mut self, new_init_base: &str) { [INFO] [stderr] 209 | | // TODO: REFACTOR [INFO] [stderr] 210 | | // this is gross [INFO] [stderr] 211 | | [INFO] [stderr] ... | [INFO] [stderr] 405 | | } [INFO] [stderr] 406 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in file_contents.enumerate()` or similar iterators [INFO] [stderr] --> src/set1/mod.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | for mut fc in file_contents { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/set1/mod.rs:200:15 [INFO] [stderr] | [INFO] [stderr] 200 | tmp = (hd1 + hd2 + hd3) as f64 / (3 * i) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(hd1 + hd2 + hd3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/set1/helper.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | c += ((tmp & var) >> (7 - i as u8)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((tmp & var) >> (7 - i as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/set1/helper.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn char_freq(str_inp: &str, freq: &HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 175 | pub fn char_freq(str_inp: &str, freq: &HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/set1/helper.rs:179:24 [INFO] [stderr] | [INFO] [stderr] 179 | Some(f) => f.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/set1/helper.rs:218:39 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn get_aes_128_lookup_tables() -> (Vec, Vec, Vec, Vec, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:370:54 [INFO] [stderr] | [INFO] [stderr] 370 | pub fn inv_sub_bytes(state: &Storage, inverse_s_box: &Vec) -> Storage { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:397:12 [INFO] [stderr] | [INFO] [stderr] 397 | mul_9: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | mul_11: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | mul_13: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/helper.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | mul_14: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: item `set1::storage::Storage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/set1/storage.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / impl Storage { [INFO] [stderr] 15 | | /* new -- empty constructor for storage [INFO] [stderr] 16 | | * Parameters: void [INFO] [stderr] 17 | | * Return: Storage (w/ data and data_type) [INFO] [stderr] ... | [INFO] [stderr] 429 | | } [INFO] [stderr] 430 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `set1::storage::Storage` [INFO] [stderr] --> src/set1/storage.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Storage { [INFO] [stderr] 20 | | Storage { [INFO] [stderr] 21 | | data: Vec::new(), [INFO] [stderr] 22 | | data_type: String::new(), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/storage.rs:45:34 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn new_init_vec(vec_inp: &Vec, data_type: &str) -> Storage { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/storage.rs:83:45 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn set_data_vec(&mut self, vec_inp: &Vec, data_type: &str) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/set1/storage.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn change_base(&mut self, new_init_base: &str) { [INFO] [stderr] 209 | | // TODO: REFACTOR [INFO] [stderr] 210 | | // this is gross [INFO] [stderr] 211 | | [INFO] [stderr] ... | [INFO] [stderr] 405 | | } [INFO] [stderr] 406 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused bitwise operation that must be used [INFO] [stderr] --> src/set1/storage.rs:952:9 [INFO] [stderr] | [INFO] [stderr] 952 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/set1/storage.rs:952:9 [INFO] [stderr] | [INFO] [stderr] 952 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused bitwise operation that must be used [INFO] [stderr] --> src/set1/storage.rs:960:9 [INFO] [stderr] | [INFO] [stderr] 960 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/set1/storage.rs:960:9 [INFO] [stderr] | [INFO] [stderr] 960 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused bitwise operation that must be used [INFO] [stderr] --> src/set1/storage.rs:968:9 [INFO] [stderr] | [INFO] [stderr] 968 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/set1/storage.rs:968:9 [INFO] [stderr] | [INFO] [stderr] 968 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused bitwise operation that must be used [INFO] [stderr] --> src/set1/storage.rs:975:9 [INFO] [stderr] | [INFO] [stderr] 975 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/set1/storage.rs:975:9 [INFO] [stderr] | [INFO] [stderr] 975 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused bitwise operation that must be used [INFO] [stderr] --> src/set1/storage.rs:983:9 [INFO] [stderr] | [INFO] [stderr] 983 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/set1/storage.rs:983:9 [INFO] [stderr] | [INFO] [stderr] 983 | &lhs ^ &rhs; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in file_contents.enumerate()` or similar iterators [INFO] [stderr] --> src/set1/mod.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | for mut fc in file_contents { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/set1/mod.rs:200:15 [INFO] [stderr] | [INFO] [stderr] 200 | tmp = (hd1 + hd2 + hd3) as f64 / (3 * i) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(hd1 + hd2 + hd3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `"docker" "inspect" "82c395803ee075a0fb7c9b70ddd602e4368577d69d32b7190f85b568c24d1ce9"` [INFO] running `"docker" "rm" "-f" "82c395803ee075a0fb7c9b70ddd602e4368577d69d32b7190f85b568c24d1ce9"` [INFO] [stdout] 82c395803ee075a0fb7c9b70ddd602e4368577d69d32b7190f85b568c24d1ce9