[INFO] updating cached repository lreynolds18/AOC [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lreynolds18/AOC [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lreynolds18/AOC" "work/ex/clippy-test-run/sources/stable/gh/lreynolds18/AOC"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lreynolds18/AOC'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lreynolds18/AOC" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/AOC"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/AOC'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f82660bed92b43a76100797f7d67a0e908dda24 [INFO] sha for GitHub repo lreynolds18/AOC: 7f82660bed92b43a76100797f7d67a0e908dda24 [INFO] validating manifest of lreynolds18/AOC on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lreynolds18/AOC on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lreynolds18/AOC [INFO] finished frobbing lreynolds18/AOC [INFO] frobbed toml for lreynolds18/AOC written to work/ex/clippy-test-run/sources/stable/gh/lreynolds18/AOC/Cargo.toml [INFO] started frobbing lreynolds18/AOC [INFO] finished frobbing lreynolds18/AOC [INFO] frobbed toml for lreynolds18/AOC written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/AOC/Cargo.toml [INFO] crate lreynolds18/AOC has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lreynolds18/AOC against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lreynolds18/AOC:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5a7a138e50eb52f6e080581cc49ebdb56875317a5c5e0cf02e86638cd86bd09 [INFO] running `"docker" "start" "-a" "d5a7a138e50eb52f6e080581cc49ebdb56875317a5c5e0cf02e86638cd86bd09"` [INFO] [stderr] Checking aoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/helper.rs:139:7 [INFO] [stderr] | [INFO] [stderr] 139 | guard_id: guard_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `guard_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code/helper.rs:139:7 [INFO] [stderr] | [INFO] [stderr] 139 | guard_id: guard_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `guard_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/code/day4.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn problem2(path: &str) -> i32 { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/code/helper.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/code/helper.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | .split("x") [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/code/day3.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | if unique == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `unique` [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/code/day4.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn problem2(path: &str) -> i32 { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/code/day4.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | d.entry(id).or_insert(Vec::new()).push(line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/code/helper.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/code/helper.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | .split("x") [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/code/day3.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | if unique == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `unique` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/code/day4.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | d.entry(id).or_insert(Vec::new()).push(line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "d5a7a138e50eb52f6e080581cc49ebdb56875317a5c5e0cf02e86638cd86bd09"` [INFO] running `"docker" "rm" "-f" "d5a7a138e50eb52f6e080581cc49ebdb56875317a5c5e0cf02e86638cd86bd09"` [INFO] [stdout] d5a7a138e50eb52f6e080581cc49ebdb56875317a5c5e0cf02e86638cd86bd09