[INFO] updating cached repository lowks/gettingrusty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lowks/gettingrusty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lowks/gettingrusty" "work/ex/clippy-test-run/sources/stable/gh/lowks/gettingrusty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lowks/gettingrusty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lowks/gettingrusty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lowks/gettingrusty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lowks/gettingrusty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c793a1888c8b5ef702b8ea63e1e91c9084c7e9a [INFO] sha for GitHub repo lowks/gettingrusty: 6c793a1888c8b5ef702b8ea63e1e91c9084c7e9a [INFO] validating manifest of lowks/gettingrusty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lowks/gettingrusty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lowks/gettingrusty [INFO] finished frobbing lowks/gettingrusty [INFO] frobbed toml for lowks/gettingrusty written to work/ex/clippy-test-run/sources/stable/gh/lowks/gettingrusty/Cargo.toml [INFO] started frobbing lowks/gettingrusty [INFO] finished frobbing lowks/gettingrusty [INFO] frobbed toml for lowks/gettingrusty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lowks/gettingrusty/Cargo.toml [INFO] crate lowks/gettingrusty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lowks/gettingrusty against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lowks/gettingrusty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd0b9d1e8cb3c1dc6cd4bc23ff1713ac873f77bc84fa2cfd5b054273beb13c47 [INFO] running `"docker" "start" "-a" "bd0b9d1e8cb3c1dc6cd4bc23ff1713ac873f77bc84fa2cfd5b054273beb13c47"` [INFO] [stderr] Checking gettingrusty v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/functional.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let e = [1, 2, 3, 4, 5, 6, 7, 8, 9]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/functional.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let e = [1, 2, 3, 4, 5, 6, 7, 8, 9]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/function_goodbye_world.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / pub mod goodbye_world { [INFO] [stderr] 3 | | pub fn print_good_bye_world() { [INFO] [stderr] 4 | | println!("Good Bye, cruel world inside of a function !"); [INFO] [stderr] 5 | | } [INFO] [stderr] 6 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/looping.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod looping { [INFO] [stderr] 2 | | fn print_stuff() { [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | for x in 1..15 { [INFO] [stderr] ... | [INFO] [stderr] 40 | | [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/string.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | wordy_reverse [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/string.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | let wordy_reverse = wordy [INFO] [stderr] | _________________________^ [INFO] [stderr] 6 | | .chars() [INFO] [stderr] 7 | | .rev() [INFO] [stderr] 8 | | // .flat_map(|g| g.chars()) [INFO] [stderr] 9 | | .collect::(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | 1 | 2 => return 0, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | _ => return 10, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/array_example.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod array_example { [INFO] [stderr] 2 | | use std::mem; [INFO] [stderr] 3 | | pub fn main() { [INFO] [stderr] 4 | | let xy: [i32; 5] = [1,2,3,4,5]; [INFO] [stderr] ... | [INFO] [stderr] 8 | | } [INFO] [stderr] 9 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tuple.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod tuple { [INFO] [stderr] 2 | | pub fn run() { [INFO] [stderr] 3 | | println!("\n\n#### Tuple Example ####"); [INFO] [stderr] 4 | | let long_tuple = (1u8, 2u16, 3u32, 4u64, [INFO] [stderr] ... | [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/functional.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod functional { [INFO] [stderr] 2 | | [INFO] [stderr] 3 | | pub fn product(input_array: &mut [i32]) -> i32 { [INFO] [stderr] 4 | | let x = input_array.iter() [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/functional.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/functional.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let x = input_array.iter() [INFO] [stderr] | _________________^ [INFO] [stderr] 5 | | .take(5) [INFO] [stderr] 6 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/functional.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/functional.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let x = input_array [INFO] [stderr] | _________________^ [INFO] [stderr] 20 | | .iter() [INFO] [stderr] 21 | | .count(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conditionals.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | return 10; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conditionals.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | } else { return 0; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/function_goodbye_world.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / pub mod goodbye_world { [INFO] [stderr] 3 | | pub fn print_good_bye_world() { [INFO] [stderr] 4 | | println!("Good Bye, cruel world inside of a function !"); [INFO] [stderr] 5 | | } [INFO] [stderr] 6 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/looping.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod looping { [INFO] [stderr] 2 | | fn print_stuff() { [INFO] [stderr] 3 | | [INFO] [stderr] 4 | | for x in 1..15 { [INFO] [stderr] ... | [INFO] [stderr] 40 | | [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/string.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | wordy_reverse [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/string.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | let wordy_reverse = wordy [INFO] [stderr] | _________________________^ [INFO] [stderr] 6 | | .chars() [INFO] [stderr] 7 | | .rev() [INFO] [stderr] 8 | | // .flat_map(|g| g.chars()) [INFO] [stderr] 9 | | .collect::(); [INFO] [stderr] | |____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | 1 | 2 => return 0, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | _ => return 10, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/array_example.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod array_example { [INFO] [stderr] 2 | | use std::mem; [INFO] [stderr] 3 | | pub fn main() { [INFO] [stderr] 4 | | let xy: [i32; 5] = [1,2,3,4,5]; [INFO] [stderr] ... | [INFO] [stderr] 8 | | } [INFO] [stderr] 9 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tuple.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod tuple { [INFO] [stderr] 2 | | pub fn run() { [INFO] [stderr] 3 | | println!("\n\n#### Tuple Example ####"); [INFO] [stderr] 4 | | let long_tuple = (1u8, 2u16, 3u32, 4u64, [INFO] [stderr] ... | [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/functional.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod functional { [INFO] [stderr] 2 | | [INFO] [stderr] 3 | | pub fn product(input_array: &mut [i32]) -> i32 { [INFO] [stderr] 4 | | let x = input_array.iter() [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/functional.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/functional.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let x = input_array.iter() [INFO] [stderr] | _________________^ [INFO] [stderr] 5 | | .take(5) [INFO] [stderr] 6 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/functional.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/functional.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let x = input_array [INFO] [stderr] | _________________^ [INFO] [stderr] 20 | | .iter() [INFO] [stderr] 21 | | .count(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conditionals.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | return 10; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conditionals.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | } else { return 0; } [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let z =` [INFO] [stderr] --> src/semicolons.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | let z = { [INFO] [stderr] | _________^ [INFO] [stderr] 12 | | let m = 5; [INFO] [stderr] 13 | | 2 * m; [INFO] [stderr] 14 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/semicolons.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | 2 * m; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/semicolons.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | 2 * m; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filesystem.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / match fs::create_dir("tmp") { [INFO] [stderr] 7 | | Err(why) => println!("! {:?}", why.kind()), [INFO] [stderr] 8 | | Ok(_) => {}, [INFO] [stderr] 9 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = fs::create_dir("tmp") { println!("! {:?}", why.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | .take(5) [INFO] [stderr] | _____________________^ [INFO] [stderr] 6 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:50:39 [INFO] [stderr] | [INFO] [stderr] 50 | println!("Sum is {}", a.iter().fold(0, |sum, i| sum + i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `item` is only used to index `strs`. [INFO] [stderr] --> src/functional.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | for item in 0..strs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for in &strs { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: for loop over `b.iter() [INFO] [stderr] .max()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/functional.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | for x in b.iter() [INFO] [stderr] | __________________^ [INFO] [stderr] 102 | | .max() { [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for x in b.iter() [INFO] [stderr] .max()` with `if let Some(x) = b.iter() [INFO] [stderr] .max()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `b.iter() [INFO] [stderr] .min()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/functional.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | for x in b.iter() [INFO] [stderr] | __________________^ [INFO] [stderr] 107 | | .min() { [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for x in b.iter() [INFO] [stderr] .min()` with `if let Some(x) = b.iter() [INFO] [stderr] .min()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | .take(5) [INFO] [stderr] | _____________________^ [INFO] [stderr] 119 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | .take(5) [INFO] [stderr] | _____________________^ [INFO] [stderr] 124 | | .fold(0, |a,b| a + b); [INFO] [stderr] | |_________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:132:41 [INFO] [stderr] | [INFO] [stderr] 132 | .filter(|&x| x % 3 == 0) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 133 | | .fold(0, |sum, i| sum + i); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: The function/method `min` doesn't need a mutable reference [INFO] [stderr] --> src/functional.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | println!("Min:: {}", min(&mut input_array2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!("HelloWorld", original_string.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!("HelloWorld", &(*original_string).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!("HelloWorld", &str::clone(original_string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gettingrusty`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let z =` [INFO] [stderr] --> src/semicolons.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | let z = { [INFO] [stderr] | _________^ [INFO] [stderr] 12 | | let m = 5; [INFO] [stderr] 13 | | 2 * m; [INFO] [stderr] 14 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/semicolons.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | 2 * m; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/semicolons.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | 2 * m; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/filesystem.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | / match fs::create_dir("tmp") { [INFO] [stderr] 7 | | Err(why) => println!("! {:?}", why.kind()), [INFO] [stderr] 8 | | Ok(_) => {}, [INFO] [stderr] 9 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = fs::create_dir("tmp") { println!("! {:?}", why.kind()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | .take(5) [INFO] [stderr] | _____________________^ [INFO] [stderr] 6 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:50:39 [INFO] [stderr] | [INFO] [stderr] 50 | println!("Sum is {}", a.iter().fold(0, |sum, i| sum + i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `item` is only used to index `strs`. [INFO] [stderr] --> src/functional.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | for item in 0..strs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for in &strs { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: for loop over `b.iter() [INFO] [stderr] .max()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/functional.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | for x in b.iter() [INFO] [stderr] | __________________^ [INFO] [stderr] 102 | | .max() { [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for x in b.iter() [INFO] [stderr] .max()` with `if let Some(x) = b.iter() [INFO] [stderr] .max()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `b.iter() [INFO] [stderr] .min()`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/functional.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | for x in b.iter() [INFO] [stderr] | __________________^ [INFO] [stderr] 107 | | .min() { [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for x in b.iter() [INFO] [stderr] .min()` with `if let Some(x) = b.iter() [INFO] [stderr] .min()` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | .take(5) [INFO] [stderr] | _____________________^ [INFO] [stderr] 119 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | .take(5) [INFO] [stderr] | _____________________^ [INFO] [stderr] 124 | | .fold(0, |a,b| a + b); [INFO] [stderr] | |_________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/functional.rs:132:41 [INFO] [stderr] | [INFO] [stderr] 132 | .filter(|&x| x % 3 == 0) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 133 | | .fold(0, |sum, i| sum + i); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: The function/method `min` doesn't need a mutable reference [INFO] [stderr] --> src/functional.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | println!("Min:: {}", min(&mut input_array2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `functional::min` doesn't need a mutable reference [INFO] [stderr] --> src/functional.rs:160:35 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(1, functional::min(&mut input_array)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!("HelloWorld", original_string.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!("HelloWorld", &(*original_string).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!("HelloWorld", &str::clone(original_string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gettingrusty`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bd0b9d1e8cb3c1dc6cd4bc23ff1713ac873f77bc84fa2cfd5b054273beb13c47"` [INFO] running `"docker" "rm" "-f" "bd0b9d1e8cb3c1dc6cd4bc23ff1713ac873f77bc84fa2cfd5b054273beb13c47"` [INFO] [stdout] bd0b9d1e8cb3c1dc6cd4bc23ff1713ac873f77bc84fa2cfd5b054273beb13c47