[INFO] updating cached repository losvedir/rust-zoo-calc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/losvedir/rust-zoo-calc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/losvedir/rust-zoo-calc" "work/ex/clippy-test-run/sources/stable/gh/losvedir/rust-zoo-calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/losvedir/rust-zoo-calc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/losvedir/rust-zoo-calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/losvedir/rust-zoo-calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/losvedir/rust-zoo-calc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f1b30292d0c0f3803db5ea2ed7b5befe57b27a64 [INFO] sha for GitHub repo losvedir/rust-zoo-calc: f1b30292d0c0f3803db5ea2ed7b5befe57b27a64 [INFO] validating manifest of losvedir/rust-zoo-calc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of losvedir/rust-zoo-calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing losvedir/rust-zoo-calc [INFO] finished frobbing losvedir/rust-zoo-calc [INFO] frobbed toml for losvedir/rust-zoo-calc written to work/ex/clippy-test-run/sources/stable/gh/losvedir/rust-zoo-calc/Cargo.toml [INFO] started frobbing losvedir/rust-zoo-calc [INFO] finished frobbing losvedir/rust-zoo-calc [INFO] frobbed toml for losvedir/rust-zoo-calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/losvedir/rust-zoo-calc/Cargo.toml [INFO] crate losvedir/rust-zoo-calc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting losvedir/rust-zoo-calc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/losvedir/rust-zoo-calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e5814756498a27969b7270adacbba22c07542d15698fbac03fbc41f5dd486e4 [INFO] running `"docker" "start" "-a" "1e5814756498a27969b7270adacbba22c07542d15698fbac03fbc41f5dd486e4"` [INFO] [stderr] Checking rust-zoo-calc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Expr::Numeral(i) => write!(f, "{}", i), [INFO] [stderr] 31 | | &Expr::Plus(ref i, ref j) => write!(f, "{} + {}", i, j), [INFO] [stderr] 32 | | &Expr::Minus(ref i, ref j) => write!(f, "{} - {}", i, j), [INFO] [stderr] ... | [INFO] [stderr] 35 | | &Expr::Negate(ref i) => write!(f, "-{}", i), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Expr::Numeral(i) => write!(f, "{}", i), [INFO] [stderr] 31 | Expr::Plus(ref i, ref j) => write!(f, "{} + {}", i, j), [INFO] [stderr] 32 | Expr::Minus(ref i, ref j) => write!(f, "{} - {}", i, j), [INFO] [stderr] 33 | Expr::Times(ref i, ref j) => write!(f, "{} * {}", i, j), [INFO] [stderr] 34 | Expr::Divide(ref i, ref j) => write!(f, "{} / {}", i, j), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | Expr::Negate(i) => eval(*i) * -1, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | fn char_is_digit(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | fn parse(toks: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:111:8 [INFO] [stderr] | [INFO] [stderr] 111 | if toks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `toks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | fn parse_expr(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:125:24 [INFO] [stderr] | [INFO] [stderr] 125 | fn parse_primary(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | fn parse_binary_ops_rhs(toks: &Vec, current_token: &mut usize, expr_precedence: i8, mut left_expr: Expr) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Expr::Numeral(i) => write!(f, "{}", i), [INFO] [stderr] 31 | | &Expr::Plus(ref i, ref j) => write!(f, "{} + {}", i, j), [INFO] [stderr] 32 | | &Expr::Minus(ref i, ref j) => write!(f, "{} - {}", i, j), [INFO] [stderr] ... | [INFO] [stderr] 35 | | &Expr::Negate(ref i) => write!(f, "-{}", i), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Expr::Numeral(i) => write!(f, "{}", i), [INFO] [stderr] 31 | Expr::Plus(ref i, ref j) => write!(f, "{} + {}", i, j), [INFO] [stderr] 32 | Expr::Minus(ref i, ref j) => write!(f, "{} - {}", i, j), [INFO] [stderr] 33 | Expr::Times(ref i, ref j) => write!(f, "{} * {}", i, j), [INFO] [stderr] 34 | Expr::Divide(ref i, ref j) => write!(f, "{} / {}", i, j), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:172:24 [INFO] [stderr] | [INFO] [stderr] 172 | fn parse_numeral(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:184:22 [INFO] [stderr] | [INFO] [stderr] 184 | fn parse_paren(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | Expr::Negate(i) => eval(*i) * -1, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | fn parse_negate(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | fn char_is_digit(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | fn parse(toks: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:111:8 [INFO] [stderr] | [INFO] [stderr] 111 | if toks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `toks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | fn parse_expr(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:229:28 [INFO] [stderr] | [INFO] [stderr] 229 | fn get_token<'a, 'b>(toks: &'a Vec, current_token: &'b mut usize) -> Result<&'a Tok, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:125:24 [INFO] [stderr] | [INFO] [stderr] 125 | fn parse_primary(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | fn parse_binary_ops_rhs(toks: &Vec, current_token: &mut usize, expr_precedence: i8, mut left_expr: Expr) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / io::stdin().read_line(&mut input) [INFO] [stderr] 246 | | .ok() [INFO] [stderr] 247 | | .expect("Could not read line."); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:172:24 [INFO] [stderr] | [INFO] [stderr] 172 | fn parse_numeral(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:184:22 [INFO] [stderr] | [INFO] [stderr] 184 | fn parse_paren(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | fn parse_negate(toks: &Vec, current_token: &mut usize) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:229:28 [INFO] [stderr] | [INFO] [stderr] 229 | fn get_token<'a, 'b>(toks: &'a Vec, current_token: &'b mut usize) -> Result<&'a Tok, &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Tok]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / io::stdin().read_line(&mut input) [INFO] [stderr] 246 | | .ok() [INFO] [stderr] 247 | | .expect("Could not read line."); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "1e5814756498a27969b7270adacbba22c07542d15698fbac03fbc41f5dd486e4"` [INFO] running `"docker" "rm" "-f" "1e5814756498a27969b7270adacbba22c07542d15698fbac03fbc41f5dd486e4"` [INFO] [stdout] 1e5814756498a27969b7270adacbba22c07542d15698fbac03fbc41f5dd486e4