[INFO] updating cached repository litonico/PathTracing
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/litonico/PathTracing
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/litonico/PathTracing" "work/ex/clippy-test-run/sources/stable/gh/litonico/PathTracing"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/litonico/PathTracing'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/litonico/PathTracing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/litonico/PathTracing"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/litonico/PathTracing'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 336e66d2b1822fce0aa86b17e5ef3b77be7629b1
[INFO] sha for GitHub repo litonico/PathTracing: 336e66d2b1822fce0aa86b17e5ef3b77be7629b1
[INFO] validating manifest of litonico/PathTracing on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of litonico/PathTracing on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing litonico/PathTracing
[INFO] finished frobbing litonico/PathTracing
[INFO] frobbed toml for litonico/PathTracing written to work/ex/clippy-test-run/sources/stable/gh/litonico/PathTracing/Cargo.toml
[INFO] started frobbing litonico/PathTracing
[INFO] finished frobbing litonico/PathTracing
[INFO] frobbed toml for litonico/PathTracing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/litonico/PathTracing/Cargo.toml
[INFO] crate litonico/PathTracing has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting litonico/PathTracing against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/litonico/PathTracing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fb121a25f8848b765b677e095a2e63a9d4cce174d68a864180669a91075c6ca7
[INFO] running `"docker" "start" "-a" "fb121a25f8848b765b677e095a2e63a9d4cce174d68a864180669a91075c6ca7"`
[INFO] [stderr]     Checking pathtracer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math.rs:56:14
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Vec3{x:x, y:y, z:z}
[INFO] [stderr]    |              ^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math.rs:56:19
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Vec3{x:x, y:y, z:z}
[INFO] [stderr]    |                   ^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math.rs:56:24
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Vec3{x:x, y:y, z:z}
[INFO] [stderr]    |                        ^^^ help: replace it with: `z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:141:16
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Point3{x:x, y:y, z:z}
[INFO] [stderr]     |                ^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:141:21
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Point3{x:x, y:y, z:z}
[INFO] [stderr]     |                     ^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:141:26
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Point3{x:x, y:y, z:z}
[INFO] [stderr]     |                          ^^^ help: replace it with: `z`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/geometry.rs:97:17
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 distance: distance,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:163:9
[INFO] [stderr]     |
[INFO] [stderr] 163 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:190:9
[INFO] [stderr]     |
[INFO] [stderr] 190 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:213:9
[INFO] [stderr]     |
[INFO] [stderr] 213 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         camera: camera,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `camera`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math.rs:56:14
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Vec3{x:x, y:y, z:z}
[INFO] [stderr]    |              ^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math.rs:56:19
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Vec3{x:x, y:y, z:z}
[INFO] [stderr]    |                   ^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/math.rs:56:24
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Vec3{x:x, y:y, z:z}
[INFO] [stderr]    |                        ^^^ help: replace it with: `z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:141:16
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Point3{x:x, y:y, z:z}
[INFO] [stderr]     |                ^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:141:21
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Point3{x:x, y:y, z:z}
[INFO] [stderr]     |                     ^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:141:26
[INFO] [stderr]     |
[INFO] [stderr] 141 |         Point3{x:x, y:y, z:z}
[INFO] [stderr]     |                          ^^^ help: replace it with: `z`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/geometry.rs:97:17
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 distance: distance,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:163:9
[INFO] [stderr]     |
[INFO] [stderr] 163 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:190:9
[INFO] [stderr]     |
[INFO] [stderr] 190 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scene.rs:213:9
[INFO] [stderr]     |
[INFO] [stderr] 213 |         image_plane: image_plane,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_plane`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         camera: camera,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `camera`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             return None
[INFO] [stderr]    |             ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             return None
[INFO] [stderr]    |             ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 | /             return Some(Intersection{
[INFO] [stderr] 46 | |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 47 | |                 point: intersection_point,
[INFO] [stderr] 48 | |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 49 | |             })
[INFO] [stderr]    | |______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 45 |             Some(Intersection{
[INFO] [stderr] 46 |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 47 |                 point: intersection_point,
[INFO] [stderr] 48 |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 49 |             })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 | /             return Some(Intersection{
[INFO] [stderr] 65 | |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 66 | |                 point: intersection_point,
[INFO] [stderr] 67 | |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 68 | |             })
[INFO] [stderr]    | |______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 64 |             Some(Intersection{
[INFO] [stderr] 65 |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 66 |                 point: intersection_point,
[INFO] [stderr] 67 |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 68 |             })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/geometry.rs:96:13
[INFO] [stderr]     |
[INFO] [stderr] 96  | /             return Some(Intersection{
[INFO] [stderr] 97  | |                 distance: distance,
[INFO] [stderr] 98  | |                 point: ray.position(distance),
[INFO] [stderr] 99  | |                 normal: self.normal
[INFO] [stderr] 100 | |             })
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 96  |             Some(Intersection{
[INFO] [stderr] 97  |                 distance: distance,
[INFO] [stderr] 98  |                 point: ray.position(distance),
[INFO] [stderr] 99  |                 normal: self.normal
[INFO] [stderr] 100 |             })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/geometry.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             return None
[INFO] [stderr]     |             ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused macro definition
[INFO] [stderr]    --> src/scene.rs:105:1
[INFO] [stderr]     |
[INFO] [stderr] 105 | / macro_rules! assert_ray_approx_eq(
[INFO] [stderr] 106 | |     ($given: expr, $expected: expr) => ({
[INFO] [stderr] 107 | |         let (given_val, expected_val) = (&($given), &($expected));
[INFO] [stderr] 108 | |         let eps = 0.000001;
[INFO] [stderr] ...   |
[INFO] [stderr] 120 | |     })
[INFO] [stderr] 121 | | );
[INFO] [stderr]     | |__^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_macros)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bounces`
[INFO] [stderr]   --> src/renderer.rs:23:41
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn render_ray(scene: &Scene, ray: &Ray, bounces: u8) -> Color {
[INFO] [stderr]    |                                         ^^^^^^^ help: consider using `_bounces` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `intersection`
[INFO] [stderr]   --> src/renderer.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |         Some(intersection) => WHITE, // TODO
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: consider using `_intersection` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `scene`
[INFO] [stderr]   --> src/main.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let scene = init_test_scene();
[INFO] [stderr]    |         ^^^^^ help: consider using `_scene` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:38:13
[INFO] [stderr]    |
[INFO] [stderr] 38 |             return None
[INFO] [stderr]    |             ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             return None
[INFO] [stderr]    |             ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 | /             return Some(Intersection{
[INFO] [stderr] 46 | |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 47 | |                 point: intersection_point,
[INFO] [stderr] 48 | |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 49 | |             })
[INFO] [stderr]    | |______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 45 |             Some(Intersection{
[INFO] [stderr] 46 |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 47 |                 point: intersection_point,
[INFO] [stderr] 48 |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 49 |             })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 | /             return Some(Intersection{
[INFO] [stderr] 65 | |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 66 | |                 point: intersection_point,
[INFO] [stderr] 67 | |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 68 | |             })
[INFO] [stderr]    | |______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 64 |             Some(Intersection{
[INFO] [stderr] 65 |                 distance: intersection_point.distance_from(ray.origin),
[INFO] [stderr] 66 |                 point: intersection_point,
[INFO] [stderr] 67 |                 normal: (self.position - intersection_point).normalize(),
[INFO] [stderr] 68 |             })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/geometry.rs:96:13
[INFO] [stderr]     |
[INFO] [stderr] 96  | /             return Some(Intersection{
[INFO] [stderr] 97  | |                 distance: distance,
[INFO] [stderr] 98  | |                 point: ray.position(distance),
[INFO] [stderr] 99  | |                 normal: self.normal
[INFO] [stderr] 100 | |             })
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 96  |             Some(Intersection{
[INFO] [stderr] 97  |                 distance: distance,
[INFO] [stderr] 98  |                 point: ray.position(distance),
[INFO] [stderr] 99  |                 normal: self.normal
[INFO] [stderr] 100 |             })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/geometry.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             return None
[INFO] [stderr]     |             ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 137 | /     assert_ray_approx_eq!(
[INFO] [stderr] 138 | |         camera.get_ray(0,0),
[INFO] [stderr] 139 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(1.0,0.5,0.5).normalize())
[INFO] [stderr] 140 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 142 | /     assert_ray_approx_eq!(
[INFO] [stderr] 143 | |         camera.get_ray(1,1),
[INFO] [stderr] 144 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(1.0,0.0,0.0))
[INFO] [stderr] 145 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 147 | /     assert_ray_approx_eq!(
[INFO] [stderr] 148 | |         camera.get_ray(2,2),
[INFO] [stderr] 149 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(1.0,-0.5,-0.5).normalize())
[INFO] [stderr] 150 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 165 | /     assert_ray_approx_eq!(
[INFO] [stderr] 166 | |         camera.get_ray(0,0),
[INFO] [stderr] 167 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(0.5,0.5,1.0).normalize())
[INFO] [stderr] 168 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 169 | /     assert_ray_approx_eq!(
[INFO] [stderr] 170 | |         camera.get_ray(1,1),
[INFO] [stderr] 171 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(0.0,0.0,1.0))
[INFO] [stderr] 172 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 173 | /     assert_ray_approx_eq!(
[INFO] [stderr] 174 | |         camera.get_ray(2,2),
[INFO] [stderr] 175 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(0.5,-0.5,1.0).normalize())
[INFO] [stderr] 176 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:194:54
[INFO] [stderr]     |
[INFO] [stderr] 194 |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(2.41421356,0.5,0.5).normalize())
[INFO] [stderr]     |                                                      ^^^^^^^^^^ help: consider: `2.414_213_56`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 192 | /     assert_ray_approx_eq!(
[INFO] [stderr] 193 | |         camera.get_ray(0,0),
[INFO] [stderr] 194 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(2.41421356,0.5,0.5).normalize())
[INFO] [stderr] 195 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:198:54
[INFO] [stderr]     |
[INFO] [stderr] 198 |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(2.41421356,-0.5,-0.5).normalize())
[INFO] [stderr]     |                                                      ^^^^^^^^^^ help: consider: `2.414_213_56`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 196 | /     assert_ray_approx_eq!(
[INFO] [stderr] 197 | |         camera.get_ray(2,2),
[INFO] [stderr] 198 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(2.41421356,-0.5,-0.5).normalize())
[INFO] [stderr] 199 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 215 | /     assert_ray_approx_eq!(
[INFO] [stderr] 216 | |         camera.get_ray(0,0),
[INFO] [stderr] 217 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(1.0,0.5,0.5).normalize())
[INFO] [stderr] 218 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 219 | /     assert_ray_approx_eq!(
[INFO] [stderr] 220 | |         camera.get_ray(2,2),
[INFO] [stderr] 221 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(1.0,0.0,0.0))
[INFO] [stderr] 222 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/scene.rs:108:19
[INFO] [stderr]     |
[INFO] [stderr] 108 |           let eps = 0.000001;
[INFO] [stderr]     |                     ^^^^^^^^ help: consider: `0.000_001`
[INFO] [stderr] ...
[INFO] [stderr] 223 | /     assert_ray_approx_eq!(
[INFO] [stderr] 224 | |         camera.get_ray(4,4),
[INFO] [stderr] 225 | |         Ray::new(Point3::new(0.0,0.0,0.0), Vec3::new(1.0,-0.5,-0.5).normalize())
[INFO] [stderr] 226 | |     );
[INFO] [stderr]     | |______- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `height`
[INFO] [stderr]  --> src/renderer.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     height: u32,
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/geometry.rs:39:55
[INFO] [stderr]    |
[INFO] [stderr] 39 |           } else if closest_pass_distance > self.radius {
[INFO] [stderr]    |  _______________________________________________________^
[INFO] [stderr] 40 | |             // Ray is too far away to hit
[INFO] [stderr] 41 | |             return None
[INFO] [stderr] 42 | |         } else if closest_pass_distance == self.radius {
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/geometry.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |           if dot <= 0.0 {
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 37 | |             // The sphere is behind the ray
[INFO] [stderr] 38 | |             return None
[INFO] [stderr] 39 | |         } else if closest_pass_distance > self.radius {
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/geometry.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 |         } else if closest_pass_distance == self.radius {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(closest_pass_distance - self.radius).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/geometry.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 |         } else if closest_pass_distance == self.radius {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:51:27
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let image_width = p.width as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^ help: try: `f64::from(p.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:51:44
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let image_width = p.width as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.pixel_density)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let image_height = p.height as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^ help: try: `f64::from(p.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:52:46
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let image_height = p.height as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.pixel_density)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:62:40
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let distance_to_image = 1.0 / (self.fov as f64 * 0.5).to_radians().tan();
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^ help: try: `f64::from(self.fov)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:71:42
[INFO] [stderr]    |
[INFO] [stderr] 71 |                         horizontal.scale(image_x as f64 * x_offset) -
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^ help: try: `f64::from(image_x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:72:40
[INFO] [stderr]    |
[INFO] [stderr] 72 |                         vertical.scale(image_y as f64 * y_offset)).normalize()
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^ help: try: `f64::from(image_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix*3 + iy*w`
[INFO] [stderr]   --> src/renderer.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |         self.image[ix*3 + iy*w + 0] = color.r;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/renderer.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let ref p = scene.camera.image_plane;
[INFO] [stderr]    |     ----^^^^^---------------------------- help: try: `let p = &scene.camera.image_plane;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pathtracer`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `bounces`
[INFO] [stderr]   --> src/renderer.rs:23:41
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn render_ray(scene: &Scene, ray: &Ray, bounces: u8) -> Color {
[INFO] [stderr]    |                                         ^^^^^^^ help: consider using `_bounces` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `intersection`
[INFO] [stderr]   --> src/renderer.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |         Some(intersection) => WHITE, // TODO
[INFO] [stderr]    |              ^^^^^^^^^^^^ help: consider using `_intersection` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `scene`
[INFO] [stderr]   --> src/main.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let scene = init_test_scene();
[INFO] [stderr]    |         ^^^^^ help: consider using `_scene` instead
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `height`
[INFO] [stderr]  --> src/renderer.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     height: u32,
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/geometry.rs:39:55
[INFO] [stderr]    |
[INFO] [stderr] 39 |           } else if closest_pass_distance > self.radius {
[INFO] [stderr]    |  _______________________________________________________^
[INFO] [stderr] 40 | |             // Ray is too far away to hit
[INFO] [stderr] 41 | |             return None
[INFO] [stderr] 42 | |         } else if closest_pass_distance == self.radius {
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/geometry.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |           if dot <= 0.0 {
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 37 | |             // The sphere is behind the ray
[INFO] [stderr] 38 | |             return None
[INFO] [stderr] 39 | |         } else if closest_pass_distance > self.radius {
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/geometry.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 |         } else if closest_pass_distance == self.radius {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(closest_pass_distance - self.radius).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/geometry.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 |         } else if closest_pass_distance == self.radius {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:51:27
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let image_width = p.width as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^ help: try: `f64::from(p.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:51:44
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let image_width = p.width as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.pixel_density)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let image_height = p.height as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^ help: try: `f64::from(p.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:52:46
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let image_height = p.height as f64 * p.pixel_density as f64;
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.pixel_density)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:62:40
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let distance_to_image = 1.0 / (self.fov as f64 * 0.5).to_radians().tan();
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^ help: try: `f64::from(self.fov)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:71:42
[INFO] [stderr]    |
[INFO] [stderr] 71 |                         horizontal.scale(image_x as f64 * x_offset) -
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^ help: try: `f64::from(image_x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/scene.rs:72:40
[INFO] [stderr]    |
[INFO] [stderr] 72 |                         vertical.scale(image_y as f64 * y_offset)).normalize()
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^ help: try: `f64::from(image_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: function `test_getting_a_ray_from_camera_understands_FOV` should have a snake case name such as `test_getting_a_ray_from_camera_understands_fov`
[INFO] [stderr]    --> src/scene.rs:180:1
[INFO] [stderr]     |
[INFO] [stderr] 180 | / fn test_getting_a_ray_from_camera_understands_FOV() {
[INFO] [stderr] 181 | |     let image_plane = ImagePlane {
[INFO] [stderr] 182 | |         width: 2,
[INFO] [stderr] 183 | |         height: 2,
[INFO] [stderr] ...   |
[INFO] [stderr] 199 | |     );
[INFO] [stderr] 200 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix*3 + iy*w`
[INFO] [stderr]   --> src/renderer.rs:16:20
[INFO] [stderr]    |
[INFO] [stderr] 16 |         self.image[ix*3 + iy*w + 0] = color.r;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/renderer.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let ref p = scene.camera.image_plane;
[INFO] [stderr]    |     ----^^^^^---------------------------- help: try: `let p = &scene.camera.image_plane;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `pathtracer`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "fb121a25f8848b765b677e095a2e63a9d4cce174d68a864180669a91075c6ca7"`
[INFO] running `"docker" "rm" "-f" "fb121a25f8848b765b677e095a2e63a9d4cce174d68a864180669a91075c6ca7"`
[INFO] [stdout] fb121a25f8848b765b677e095a2e63a9d4cce174d68a864180669a91075c6ca7