[INFO] updating cached repository lisongmin/jpeg-recover [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lisongmin/jpeg-recover [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lisongmin/jpeg-recover" "work/ex/clippy-test-run/sources/stable/gh/lisongmin/jpeg-recover"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lisongmin/jpeg-recover'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lisongmin/jpeg-recover" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lisongmin/jpeg-recover"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lisongmin/jpeg-recover'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d3f9c14ca8d7db8c5d66e6e24708f3cc1b593ccb [INFO] sha for GitHub repo lisongmin/jpeg-recover: d3f9c14ca8d7db8c5d66e6e24708f3cc1b593ccb [INFO] validating manifest of lisongmin/jpeg-recover on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lisongmin/jpeg-recover on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lisongmin/jpeg-recover [INFO] finished frobbing lisongmin/jpeg-recover [INFO] frobbed toml for lisongmin/jpeg-recover written to work/ex/clippy-test-run/sources/stable/gh/lisongmin/jpeg-recover/Cargo.toml [INFO] started frobbing lisongmin/jpeg-recover [INFO] finished frobbing lisongmin/jpeg-recover [INFO] frobbed toml for lisongmin/jpeg-recover written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lisongmin/jpeg-recover/Cargo.toml [INFO] crate lisongmin/jpeg-recover has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lisongmin/jpeg-recover against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lisongmin/jpeg-recover:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c526d497f545bd773057f3000d7e6ca671e05ab9497fe5fedd9f6ab41037ae3a [INFO] running `"docker" "start" "-a" "c526d497f545bd773057f3000d7e6ca671e05ab9497fe5fedd9f6ab41037ae3a"` [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking jpeg-recover v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:169:25 [INFO] [stderr] | [INFO] [stderr] 169 | soi: soi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `soi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:169:25 [INFO] [stderr] | [INFO] [stderr] 169 | soi: soi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `soi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | / if mmap[x..x + 2] == soi_flag { [INFO] [stderr] 147 | | if &mmap[x + 6..x + 10] == b"Exif" || &mmap[x + 6..x + 10] == b"JFIF" { [INFO] [stderr] 148 | | soi = x; [INFO] [stderr] 149 | | matched = true; [INFO] [stderr] 150 | | break; [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | if mmap[x..x + 2] == soi_flag && (&mmap[x + 6..x + 10] == b"Exif" || &mmap[x + 6..x + 10] == b"JFIF") { [INFO] [stderr] 147 | soi = x; [INFO] [stderr] 148 | matched = true; [INFO] [stderr] 149 | break; [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | / if mmap[x..x + 2] == soi_flag { [INFO] [stderr] 147 | | if &mmap[x + 6..x + 10] == b"Exif" || &mmap[x + 6..x + 10] == b"JFIF" { [INFO] [stderr] 148 | | soi = x; [INFO] [stderr] 149 | | matched = true; [INFO] [stderr] 150 | | break; [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | if mmap[x..x + 2] == soi_flag && (&mmap[x + 6..x + 10] == b"Exif" || &mmap[x + 6..x + 10] == b"JFIF") { [INFO] [stderr] 147 | soi = x; [INFO] [stderr] 148 | matched = true; [INFO] [stderr] 149 | break; [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match create_dir(out_path) { [INFO] [stderr] 96 | | Err(e) => panic!("Can not create directory {}, detail: {}", output_dir, e), [INFO] [stderr] 97 | | Ok(_) => (), [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = create_dir(out_path) { panic!("Can not create directory {}, detail: {}", output_dir, e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | soi = x; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | soi += type_flag_pos; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | if &mmap[x..x + 2] == eoi_flag { [INFO] [stderr] | ---------------^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `mmap[x..x + 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | } else if &mmap[x..x + 2] == soi_flag { [INFO] [stderr] | ---------------^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `mmap[x..x + 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match create_dir(out_path) { [INFO] [stderr] 96 | | Err(e) => panic!("Can not create directory {}, detail: {}", output_dir, e), [INFO] [stderr] 97 | | Ok(_) => (), [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = create_dir(out_path) { panic!("Can not create directory {}, detail: {}", output_dir, e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/main.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | soi = x; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | soi += type_flag_pos; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | if &mmap[x..x + 2] == eoi_flag { [INFO] [stderr] | ---------------^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `mmap[x..x + 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | } else if &mmap[x..x + 2] == soi_flag { [INFO] [stderr] | ---------------^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `mmap[x..x + 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.74s [INFO] running `"docker" "inspect" "c526d497f545bd773057f3000d7e6ca671e05ab9497fe5fedd9f6ab41037ae3a"` [INFO] running `"docker" "rm" "-f" "c526d497f545bd773057f3000d7e6ca671e05ab9497fe5fedd9f6ab41037ae3a"` [INFO] [stdout] c526d497f545bd773057f3000d7e6ca671e05ab9497fe5fedd9f6ab41037ae3a