[INFO] updating cached repository linde12/chip8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/linde12/chip8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/linde12/chip8" "work/ex/clippy-test-run/sources/stable/gh/linde12/chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/linde12/chip8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/linde12/chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/linde12/chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/linde12/chip8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cbff4529fb7e76758a14ae835e8243a2aa01e91b [INFO] sha for GitHub repo linde12/chip8: cbff4529fb7e76758a14ae835e8243a2aa01e91b [INFO] validating manifest of linde12/chip8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linde12/chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linde12/chip8 [INFO] finished frobbing linde12/chip8 [INFO] frobbed toml for linde12/chip8 written to work/ex/clippy-test-run/sources/stable/gh/linde12/chip8/Cargo.toml [INFO] started frobbing linde12/chip8 [INFO] finished frobbing linde12/chip8 [INFO] frobbed toml for linde12/chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/linde12/chip8/Cargo.toml [INFO] crate linde12/chip8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linde12/chip8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/linde12/chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3724093946c6752991e379c195e6fd834ac0efb7a327995b60af7ebd3ac5081 [INFO] running `"docker" "start" "-a" "c3724093946c6752991e379c195e6fd834ac0efb7a327995b60af7ebd3ac5081"` [INFO] [stderr] Checking chip88 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | mmu: mmu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mmu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | mmu: mmu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mmu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | op if high_nib == 0x1 => Ok(Op::JP(Operand::Addr(0xFFFF))), [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | op if high_nib == 0x2 => Ok(Op::CALL(Operand::Addr(0xFFFF))), [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | op if high_nib == 0x4 => Ok(Op::SNE( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | op if high_nib == 0x5 => Ok(Op::SE( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | op if high_nib == 0x6 => Ok(Op::LD( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | op if high_nib == 0x7 => Ok(Op::ADD( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | op if high_nib == 0x9 => Ok(Op::SNE( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | op if high_nib == 0xA => Ok(Op::LD( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | op if high_nib == 0xB => Ok(Op::JP(Operand::Addr(0xFFFA))), [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CLS` [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CLS, // Clear [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RET` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | RET, // Return [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RND` [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | RND(Operand, Operand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DRW` [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | DRW(Operand, Operand, Operand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKP` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | SKP(Operand), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKNP` [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | SKNP(Operand), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_byte` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | fn read_byte(&self, index: usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg8` [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | reg8: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | let word: u16 = ((self.mem[index] as u16) << 8) + self.mem[index + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:63 [INFO] [stderr] | [INFO] [stderr] 84 | let word: u16 = ((self.mem[index] as u16) << 8) + self.mem[index + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[index + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:140:76 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(Op::SE(Operand::Register(reg), Operand::Byte(0xFFFF))); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0xFFFF` (decimal `65535`) does not fit into an `u8` and will become `255u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:146:31 [INFO] [stderr] | [INFO] [stderr] 146 | Operand::Byte(0xFFFF), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0xFFFF` (decimal `65535`) does not fit into an `u8` and will become `255u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:158:31 [INFO] [stderr] | [INFO] [stderr] 158 | Operand::Byte(0xFFFF), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0xFFFF` (decimal `65535`) does not fit into an `u8` and will become `255u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / loop { [INFO] [stderr] 216 | | match cpu.read_instruction() { [INFO] [stderr] 217 | | Ok(op) => println!("{:?}", op), [INFO] [stderr] 218 | | Err(_) => break, // TODO: inform user [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(op) = cpu.read_instruction() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | op if high_nib == 0x1 => Ok(Op::JP(Operand::Addr(0xFFFF))), [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | op if high_nib == 0x2 => Ok(Op::CALL(Operand::Addr(0xFFFF))), [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | op if high_nib == 0x4 => Ok(Op::SNE( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | op if high_nib == 0x5 => Ok(Op::SE( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | op if high_nib == 0x6 => Ok(Op::LD( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | op if high_nib == 0x7 => Ok(Op::ADD( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | op if high_nib == 0x9 => Ok(Op::SNE( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | op if high_nib == 0xA => Ok(Op::LD( [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/main.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | op if high_nib == 0xB => Ok(Op::JP(Operand::Addr(0xFFFA))), [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CLS` [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | CLS, // Clear [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RET` [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | RET, // Return [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RND` [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | RND(Operand, Operand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DRW` [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | DRW(Operand, Operand, Operand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKP` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | SKP(Operand), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKNP` [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | SKNP(Operand), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_byte` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | fn read_byte(&self, index: usize) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg8` [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | reg8: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | let word: u16 = ((self.mem[index] as u16) << 8) + self.mem[index + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:63 [INFO] [stderr] | [INFO] [stderr] 84 | let word: u16 = ((self.mem[index] as u16) << 8) + self.mem[index + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.mem[index + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:140:76 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(Op::SE(Operand::Register(reg), Operand::Byte(0xFFFF))); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0xFFFF` (decimal `65535`) does not fit into an `u8` and will become `255u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:146:31 [INFO] [stderr] | [INFO] [stderr] 146 | Operand::Byte(0xFFFF), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0xFFFF` (decimal `65535`) does not fit into an `u8` and will become `255u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/main.rs:158:31 [INFO] [stderr] | [INFO] [stderr] 158 | Operand::Byte(0xFFFF), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0xFFFF` (decimal `65535`) does not fit into an `u8` and will become `255u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:215:5 [INFO] [stderr] | [INFO] [stderr] 215 | / loop { [INFO] [stderr] 216 | | match cpu.read_instruction() { [INFO] [stderr] 217 | | Ok(op) => println!("{:?}", op), [INFO] [stderr] 218 | | Err(_) => break, // TODO: inform user [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(op) = cpu.read_instruction() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "c3724093946c6752991e379c195e6fd834ac0efb7a327995b60af7ebd3ac5081"` [INFO] running `"docker" "rm" "-f" "c3724093946c6752991e379c195e6fd834ac0efb7a327995b60af7ebd3ac5081"` [INFO] [stdout] c3724093946c6752991e379c195e6fd834ac0efb7a327995b60af7ebd3ac5081