[INFO] updating cached repository lilydjwg/chinese-num [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lilydjwg/chinese-num [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lilydjwg/chinese-num" "work/ex/clippy-test-run/sources/stable/gh/lilydjwg/chinese-num"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lilydjwg/chinese-num'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lilydjwg/chinese-num" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilydjwg/chinese-num"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilydjwg/chinese-num'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d25b72640b0c44a433525bb560ea5d552444bd0 [INFO] sha for GitHub repo lilydjwg/chinese-num: 0d25b72640b0c44a433525bb560ea5d552444bd0 [INFO] validating manifest of lilydjwg/chinese-num on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lilydjwg/chinese-num on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lilydjwg/chinese-num [INFO] finished frobbing lilydjwg/chinese-num [INFO] frobbed toml for lilydjwg/chinese-num written to work/ex/clippy-test-run/sources/stable/gh/lilydjwg/chinese-num/Cargo.toml [INFO] started frobbing lilydjwg/chinese-num [INFO] finished frobbing lilydjwg/chinese-num [INFO] frobbed toml for lilydjwg/chinese-num written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilydjwg/chinese-num/Cargo.toml [INFO] crate lilydjwg/chinese-num has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lilydjwg/chinese-num against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lilydjwg/chinese-num:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1109c06b33c28e673b07153bd70a0f332a7e3858ca450cbcd7596af453e8a7cd [INFO] running `"docker" "start" "-a" "1109c06b33c28e673b07153bd70a0f332a7e3858ca450cbcd7596af453e8a7cd"` [INFO] [stderr] Checking chinese-num v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | if !n.chars().all(|x| x.is_digit(10)) || n.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | |(i, c)| ((c - '0' as u8) as usize, digit_pos_to_name(i))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:108:6 [INFO] [stderr] | [INFO] [stderr] 108 | if r.chars().last().unwrap() == '个' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `r.ends_with('个')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | if !n.chars().all(|x| x.is_digit(10)) || n.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | |(i, c)| ((c - '0' as u8) as usize, digit_pos_to_name(i))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:108:6 [INFO] [stderr] | [INFO] [stderr] 108 | if r.chars().last().unwrap() == '个' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `r.ends_with('个')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "1109c06b33c28e673b07153bd70a0f332a7e3858ca450cbcd7596af453e8a7cd"` [INFO] running `"docker" "rm" "-f" "1109c06b33c28e673b07153bd70a0f332a7e3858ca450cbcd7596af453e8a7cd"` [INFO] [stdout] 1109c06b33c28e673b07153bd70a0f332a7e3858ca450cbcd7596af453e8a7cd