[INFO] updating cached repository lfn3/rs-advent
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/lfn3/rs-advent
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/lfn3/rs-advent" "work/ex/clippy-test-run/sources/stable/gh/lfn3/rs-advent"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lfn3/rs-advent'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/lfn3/rs-advent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lfn3/rs-advent"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lfn3/rs-advent'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0cd62ac239d19477eaffc88b660bb16a793f6cbf
[INFO] sha for GitHub repo lfn3/rs-advent: 0cd62ac239d19477eaffc88b660bb16a793f6cbf
[INFO] validating manifest of lfn3/rs-advent on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lfn3/rs-advent on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lfn3/rs-advent
[INFO] finished frobbing lfn3/rs-advent
[INFO] frobbed toml for lfn3/rs-advent written to work/ex/clippy-test-run/sources/stable/gh/lfn3/rs-advent/Cargo.toml
[INFO] started frobbing lfn3/rs-advent
[INFO] finished frobbing lfn3/rs-advent
[INFO] frobbed toml for lfn3/rs-advent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lfn3/rs-advent/Cargo.toml
[INFO] crate lfn3/rs-advent has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lfn3/rs-advent against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lfn3/rs-advent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8f648a8705a5db2ab98cc762751aaf0a5048b6999bbf89576f6b11df15d013be
[INFO] running `"docker" "start" "-a" "8f648a8705a5db2ab98cc762751aaf0a5048b6999bbf89576f6b11df15d013be"`
[INFO] [stderr]     Checking rs-advent v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eight.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return data.take(count).collect();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data.take(count).collect()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eight.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return (children_count, metadata_count);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(children_count, metadata_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/one.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             return Some(None); //This is weird, but scan stops as soon as you return None
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(None)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eight.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return data.take(count).collect();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data.take(count).collect()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/eight.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return (children_count, metadata_count);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(children_count, metadata_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/nine.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 |         146373,
[INFO] [stderr]    |         ^^^^^^ help: consider: `146_373`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/one.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 |             return Some(None); //This is weird, but scan stops as soon as you return None
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(None)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/eight.rs:1:17
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/eight.rs:9:22
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn solve_part_one(s: &String) -> usize {
[INFO] [stderr]   |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/five.rs:3:17
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/five.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 | fn solve_part_one(s: &String) -> String {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |     reduce(&mut s.chars().into_iter())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/five.rs:48:14
[INFO] [stderr]    |
[INFO] [stderr] 48 |     for p in 'a' as u8..'z' as u8 {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/five.rs:48:25
[INFO] [stderr]    |
[INFO] [stderr] 48 |     for p in 'a' as u8..'z' as u8 {
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:50:48
[INFO] [stderr]    |
[INFO] [stderr] 50 |             best.min(reduce_without(p as char, s.clone().chars().into_iter().borrow_mut()).len());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.clone().chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/nine.rs:1:17
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/nine.rs:9:22
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn solve_part_one(s: &String) -> usize {
[INFO] [stderr]   |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/nine.rs:10:36
[INFO] [stderr]    |
[INFO] [stderr] 10 |     let split: Vec<&str> = s.split(" ").collect();
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/nine.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let players: usize = split.get(0).unwrap().parse().unwrap();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/nine.rs:13:30
[INFO] [stderr]    |
[INFO] [stderr] 13 |     let last_marble: usize = split.get(6).unwrap().parse().unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[6]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/one.rs:3:17
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/one.rs:8:22
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn testable_solve(s: &String) -> (i32, i32) {
[INFO] [stderr]   |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/one.rs:21:22
[INFO] [stderr]    |
[INFO] [stderr] 21 | fn solve_part_one(s: &String) -> i32 {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/one.rs:23:37
[INFO] [stderr]    |
[INFO] [stderr] 23 |           .map(|l| l.parse().unwrap())
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 24 | |         .fold(0, |acc, change: i32| acc + change)
[INFO] [stderr]    | |_________________________________________________^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/one.rs:36:22
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn solve_part_two(s: &String) -> i32 {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/one.rs:47:34
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 return Some(Some(acc.clone()));
[INFO] [stderr]    |                                  ^^^^^^^^^^^ help: try dereferencing it: `*acc`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/two.rs:3:17
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/two.rs:7:26
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn testable_solve(s: &String) -> usize {
[INFO] [stderr]   |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/two.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     letters.values().into_iter().any(|count| *count == n)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `letters.values()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/eight.rs:1:17
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/eight.rs:9:22
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn solve_part_one(s: &String) -> usize {
[INFO] [stderr]   |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/five.rs:3:17
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/five.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 | fn solve_part_one(s: &String) -> String {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |     reduce(&mut s.chars().into_iter())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/five.rs:48:14
[INFO] [stderr]    |
[INFO] [stderr] 48 |     for p in 'a' as u8..'z' as u8 {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/five.rs:48:25
[INFO] [stderr]    |
[INFO] [stderr] 48 |     for p in 'a' as u8..'z' as u8 {
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:50:48
[INFO] [stderr]    |
[INFO] [stderr] 50 |             best.min(reduce_without(p as char, s.clone().chars().into_iter().borrow_mut()).len());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.clone().chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:77:29
[INFO] [stderr]    |
[INFO] [stderr] 77 |         reduce_without('a', "dabAcCaCBAcCcaDA".chars().into_iter().borrow_mut())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `"dabAcCaCBAcCcaDA".chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:81:29
[INFO] [stderr]    |
[INFO] [stderr] 81 |         reduce_without('b', "dabAcCaCBAcCcaDA".chars().into_iter().borrow_mut())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `"dabAcCaCBAcCcaDA".chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:85:29
[INFO] [stderr]    |
[INFO] [stderr] 85 |         reduce_without('c', "dabAcCaCBAcCcaDA".chars().into_iter().borrow_mut())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `"dabAcCaCBAcCcaDA".chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/five.rs:89:29
[INFO] [stderr]    |
[INFO] [stderr] 89 |         reduce_without('d', "dabAcCaCBAcCcaDA".chars().into_iter().borrow_mut())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `"dabAcCaCBAcCcaDA".chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/nine.rs:1:17
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/nine.rs:9:22
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn solve_part_one(s: &String) -> usize {
[INFO] [stderr]   |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/nine.rs:10:36
[INFO] [stderr]    |
[INFO] [stderr] 10 |     let split: Vec<&str> = s.split(" ").collect();
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/nine.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let players: usize = split.get(0).unwrap().parse().unwrap();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/nine.rs:13:30
[INFO] [stderr]    |
[INFO] [stderr] 13 |     let last_marble: usize = split.get(6).unwrap().parse().unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[6]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/one.rs:3:17
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/one.rs:8:22
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn testable_solve(s: &String) -> (i32, i32) {
[INFO] [stderr]   |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/one.rs:21:22
[INFO] [stderr]    |
[INFO] [stderr] 21 | fn solve_part_one(s: &String) -> i32 {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/one.rs:23:37
[INFO] [stderr]    |
[INFO] [stderr] 23 |           .map(|l| l.parse().unwrap())
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 24 | |         .fold(0, |acc, change: i32| acc + change)
[INFO] [stderr]    | |_________________________________________________^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/one.rs:36:22
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn solve_part_two(s: &String) -> i32 {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/one.rs:47:34
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 return Some(Some(acc.clone()));
[INFO] [stderr]    |                                  ^^^^^^^^^^^ help: try dereferencing it: `*acc`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/two.rs:3:17
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn solve(s: &String) {
[INFO] [stderr]   |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/two.rs:7:26
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn testable_solve(s: &String) -> usize {
[INFO] [stderr]   |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/two.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     letters.values().into_iter().any(|count| *count == n)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `letters.values()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.23s
[INFO] running `"docker" "inspect" "8f648a8705a5db2ab98cc762751aaf0a5048b6999bbf89576f6b11df15d013be"`
[INFO] running `"docker" "rm" "-f" "8f648a8705a5db2ab98cc762751aaf0a5048b6999bbf89576f6b11df15d013be"`
[INFO] [stdout] 8f648a8705a5db2ab98cc762751aaf0a5048b6999bbf89576f6b11df15d013be