[INFO] updating cached repository levzhazeschi/portfolio-tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/levzhazeschi/portfolio-tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/levzhazeschi/portfolio-tools" "work/ex/clippy-test-run/sources/stable/gh/levzhazeschi/portfolio-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/levzhazeschi/portfolio-tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/levzhazeschi/portfolio-tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levzhazeschi/portfolio-tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levzhazeschi/portfolio-tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7db30c04f4fc2d9c7c0f22f2bc1e9816eaef8634 [INFO] sha for GitHub repo levzhazeschi/portfolio-tools: 7db30c04f4fc2d9c7c0f22f2bc1e9816eaef8634 [INFO] validating manifest of levzhazeschi/portfolio-tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of levzhazeschi/portfolio-tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing levzhazeschi/portfolio-tools [INFO] finished frobbing levzhazeschi/portfolio-tools [INFO] frobbed toml for levzhazeschi/portfolio-tools written to work/ex/clippy-test-run/sources/stable/gh/levzhazeschi/portfolio-tools/Cargo.toml [INFO] started frobbing levzhazeschi/portfolio-tools [INFO] finished frobbing levzhazeschi/portfolio-tools [INFO] frobbed toml for levzhazeschi/portfolio-tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levzhazeschi/portfolio-tools/Cargo.toml [INFO] crate levzhazeschi/portfolio-tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting levzhazeschi/portfolio-tools against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/levzhazeschi/portfolio-tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 423d3392c6fbfd4d23893ad0d708a681699a8a17a04518c0c38a8143254e0d6e [INFO] running `"docker" "start" "-a" "423d3392c6fbfd4d23893ad0d708a681699a8a17a04518c0c38a8143254e0d6e"` [INFO] [stderr] Checking portfolio-tools v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/text_io.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | Err(err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/text_io.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | Err(err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/text_io.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn read_portfolio<'a>(file_name: &str) -> Option> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/text_io.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn read_portfolio<'a>(file_name: &str) -> Option> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/text_io.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if words.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/text_io.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if words.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "423d3392c6fbfd4d23893ad0d708a681699a8a17a04518c0c38a8143254e0d6e"` [INFO] running `"docker" "rm" "-f" "423d3392c6fbfd4d23893ad0d708a681699a8a17a04518c0c38a8143254e0d6e"` [INFO] [stdout] 423d3392c6fbfd4d23893ad0d708a681699a8a17a04518c0c38a8143254e0d6e