[INFO] updating cached repository leviathan88/learning-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/leviathan88/learning-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/leviathan88/learning-rust" "work/ex/clippy-test-run/sources/stable/gh/leviathan88/learning-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/leviathan88/learning-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/leviathan88/learning-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leviathan88/learning-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leviathan88/learning-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0d1d56441ec730a685fdda56ddeb44da5f4bb23 [INFO] sha for GitHub repo leviathan88/learning-rust: e0d1d56441ec730a685fdda56ddeb44da5f4bb23 [INFO] validating manifest of leviathan88/learning-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of leviathan88/learning-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing leviathan88/learning-rust [INFO] finished frobbing leviathan88/learning-rust [INFO] frobbed toml for leviathan88/learning-rust written to work/ex/clippy-test-run/sources/stable/gh/leviathan88/learning-rust/Cargo.toml [INFO] started frobbing leviathan88/learning-rust [INFO] finished frobbing leviathan88/learning-rust [INFO] frobbed toml for leviathan88/learning-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leviathan88/learning-rust/Cargo.toml [INFO] crate leviathan88/learning-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting leviathan88/learning-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leviathan88/learning-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5d7ff9bd6d256e5709e0d76136ee829aeb0c1e9c56f8abc95650179310601b5 [INFO] running `"docker" "start" "-a" "a5d7ff9bd6d256e5709e0d76136ee829aeb0c1e9c56f8abc95650179310601b5"` [INFO] [stderr] Checking learning-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `gcd` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn gcd(mut n: u64, mut m: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | / let t = m; [INFO] [stderr] 10 | | m = n; [INFO] [stderr] 11 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | / let t = m; [INFO] [stderr] 10 | | m = n; [INFO] [stderr] 11 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "a5d7ff9bd6d256e5709e0d76136ee829aeb0c1e9c56f8abc95650179310601b5"` [INFO] running `"docker" "rm" "-f" "a5d7ff9bd6d256e5709e0d76136ee829aeb0c1e9c56f8abc95650179310601b5"` [INFO] [stdout] a5d7ff9bd6d256e5709e0d76136ee829aeb0c1e9c56f8abc95650179310601b5