[INFO] updating cached repository leshow/finger-tokio [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/leshow/finger-tokio [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/leshow/finger-tokio" "work/ex/clippy-test-run/sources/stable/gh/leshow/finger-tokio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/leshow/finger-tokio'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/leshow/finger-tokio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/finger-tokio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/finger-tokio'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6663b59d84d7cf64e6320e26afafea2793ec7da0 [INFO] sha for GitHub repo leshow/finger-tokio: 6663b59d84d7cf64e6320e26afafea2793ec7da0 [INFO] validating manifest of leshow/finger-tokio on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of leshow/finger-tokio on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing leshow/finger-tokio [INFO] finished frobbing leshow/finger-tokio [INFO] frobbed toml for leshow/finger-tokio written to work/ex/clippy-test-run/sources/stable/gh/leshow/finger-tokio/Cargo.toml [INFO] started frobbing leshow/finger-tokio [INFO] finished frobbing leshow/finger-tokio [INFO] frobbed toml for leshow/finger-tokio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/finger-tokio/Cargo.toml [INFO] crate leshow/finger-tokio has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting leshow/finger-tokio against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/leshow/finger-tokio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f4576b1550eaae7cbb80085f9d3355b2b122e91cfef1d10f222dcbf454dc475 [INFO] running `"docker" "start" "-a" "3f4576b1550eaae7cbb80085f9d3355b2b122e91cfef1d10f222dcbf454dc475"` [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking hostname v0.1.3 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking bytes v0.4.4 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking echo-proto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/proto.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn to_resp(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:83:19 [INFO] [stderr] | [INFO] [stderr] 83 | query.map(|entry| FingerResponse::Local(entry)).boxed() // not proxying requests for now, maybe unnecessary for daemon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FingerResponse::Local` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/proto.rs:136:20 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn to_resp(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | Ok(part.next().ok_or(FingerError::parse(e))?.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FingerError::parse(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | let addr = format!("0.0.0.0:12345").parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"0.0.0.0:12345".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:83:19 [INFO] [stderr] | [INFO] [stderr] 83 | query.map(|entry| FingerResponse::Local(entry)).boxed() // not proxying requests for now, maybe unnecessary for daemon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FingerResponse::Local` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | Ok(part.next().ok_or(FingerError::parse(e))?.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FingerError::parse(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | let addr = format!("0.0.0.0:12345").parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"0.0.0.0:12345".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.72s [INFO] running `"docker" "inspect" "3f4576b1550eaae7cbb80085f9d3355b2b122e91cfef1d10f222dcbf454dc475"` [INFO] running `"docker" "rm" "-f" "3f4576b1550eaae7cbb80085f9d3355b2b122e91cfef1d10f222dcbf454dc475"` [INFO] [stdout] 3f4576b1550eaae7cbb80085f9d3355b2b122e91cfef1d10f222dcbf454dc475