[INFO] updating cached repository lesguillemets/curly-octo-funicular [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lesguillemets/curly-octo-funicular [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lesguillemets/curly-octo-funicular" "work/ex/clippy-test-run/sources/stable/gh/lesguillemets/curly-octo-funicular"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lesguillemets/curly-octo-funicular'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lesguillemets/curly-octo-funicular" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lesguillemets/curly-octo-funicular"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lesguillemets/curly-octo-funicular'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bda6392dece8b454886281db0d4d85f7e1381432 [INFO] sha for GitHub repo lesguillemets/curly-octo-funicular: bda6392dece8b454886281db0d4d85f7e1381432 [INFO] validating manifest of lesguillemets/curly-octo-funicular on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lesguillemets/curly-octo-funicular on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lesguillemets/curly-octo-funicular [INFO] finished frobbing lesguillemets/curly-octo-funicular [INFO] frobbed toml for lesguillemets/curly-octo-funicular written to work/ex/clippy-test-run/sources/stable/gh/lesguillemets/curly-octo-funicular/Cargo.toml [INFO] started frobbing lesguillemets/curly-octo-funicular [INFO] finished frobbing lesguillemets/curly-octo-funicular [INFO] frobbed toml for lesguillemets/curly-octo-funicular written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lesguillemets/curly-octo-funicular/Cargo.toml [INFO] crate lesguillemets/curly-octo-funicular has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lesguillemets/curly-octo-funicular against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lesguillemets/curly-octo-funicular:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0460fd01b01eb0f28a3284e8111b4ed2d15597bddfde5f83d6f3f314d17ab09f [INFO] running `"docker" "start" "-a" "0460fd01b01eb0f28a3284e8111b4ed2d15597bddfde5f83d6f3f314d17ab09f"` [INFO] [stderr] Checking reversi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/board.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/board.rs:96:31 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn print_count(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/face.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/face.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn flip(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:17:43 [INFO] [stderr] | [INFO] [stderr] 17 | fn main_loop(board: &Board, player: Face) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/board.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/board.rs:96:31 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn print_count(&self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/face.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/face.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn flip(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:17:43 [INFO] [stderr] | [INFO] [stderr] 17 | fn main_loop(board: &Board, player: Face) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | fn main_loop(board: &Board, player: Face) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] ... [INFO] [stderr] 22 | main_loop(&b, player.not()) [INFO] [stderr] | --------------------------- recursive call site [INFO] [stderr] ... [INFO] [stderr] 26 | main_loop(board, player) [INFO] [stderr] | ------------------------ recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: method is never used: `count_bw` [INFO] [stderr] --> src/board.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn count_bw(&self) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_count` [INFO] [stderr] --> src/board.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn print_count(&self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `flip` [INFO] [stderr] --> src/face.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn flip(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/board.rs:27:40 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn at(&self, loc: (i8, i8)) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/board.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if let Some(_) = self.at(loc) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 37 | | self.0[loc.0 as usize][loc.1 as usize] = Some(player); [INFO] [stderr] 38 | | Ok(()) [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | Err("out of bounds?".to_owned()) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________- help: try this: `if self.at(loc).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/board.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 'a' as u8..'a' as u8 + SIZE as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | fn main_loop(board: &Board, player: Face) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] ... [INFO] [stderr] 22 | main_loop(&b, player.not()) [INFO] [stderr] | --------------------------- recursive call site [INFO] [stderr] ... [INFO] [stderr] 26 | main_loop(board, player) [INFO] [stderr] | ------------------------ recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/board.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 'a' as u8..'a' as u8 + SIZE as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/face.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn not(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: method is never used: `count_bw` [INFO] [stderr] --> src/board.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn count_bw(&self) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_count` [INFO] [stderr] --> src/board.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn print_count(&self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `flip` [INFO] [stderr] --> src/face.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn flip(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/board.rs:27:40 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn at(&self, loc: (i8, i8)) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/board.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if let Some(_) = self.at(loc) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 37 | | self.0[loc.0 as usize][loc.1 as usize] = Some(player); [INFO] [stderr] 38 | | Ok(()) [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | Err("out of bounds?".to_owned()) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________- help: try this: `if self.at(loc).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/board.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 'a' as u8..'a' as u8 + SIZE as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/board.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 'a' as u8..'a' as u8 + SIZE as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/face.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn not(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "0460fd01b01eb0f28a3284e8111b4ed2d15597bddfde5f83d6f3f314d17ab09f"` [INFO] running `"docker" "rm" "-f" "0460fd01b01eb0f28a3284e8111b4ed2d15597bddfde5f83d6f3f314d17ab09f"` [INFO] [stdout] 0460fd01b01eb0f28a3284e8111b4ed2d15597bddfde5f83d6f3f314d17ab09f