[INFO] updating cached repository lensvol/rotten13 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lensvol/rotten13 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lensvol/rotten13" "work/ex/clippy-test-run/sources/stable/gh/lensvol/rotten13"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lensvol/rotten13'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lensvol/rotten13" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lensvol/rotten13"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lensvol/rotten13'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c50f1752c7537a56d236a6fbd70c0ca8f99bf1a0 [INFO] sha for GitHub repo lensvol/rotten13: c50f1752c7537a56d236a6fbd70c0ca8f99bf1a0 [INFO] validating manifest of lensvol/rotten13 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lensvol/rotten13 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lensvol/rotten13 [INFO] finished frobbing lensvol/rotten13 [INFO] frobbed toml for lensvol/rotten13 written to work/ex/clippy-test-run/sources/stable/gh/lensvol/rotten13/Cargo.toml [INFO] started frobbing lensvol/rotten13 [INFO] finished frobbing lensvol/rotten13 [INFO] frobbed toml for lensvol/rotten13 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lensvol/rotten13/Cargo.toml [INFO] crate lensvol/rotten13 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lensvol/rotten13 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lensvol/rotten13:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1d282f1a9c0ca523d4c0e65a226323a0fdc725f5205aad6b4822ec04b160d7a [INFO] running `"docker" "start" "-a" "c1d282f1a9c0ca523d4c0e65a226323a0fdc725f5205aad6b4822ec04b160d7a"` [INFO] [stderr] Checking rotten13 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | 'a'...'z' => 'a' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | 'A'...'Z' => 'A' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | .map_or_else(|| rotate_stdin(), |filename| rotate_file(filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `rotate_stdin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:55 [INFO] [stderr] | [INFO] [stderr] 41 | .map_or_else(|| rotate_stdin(), |filename| rotate_file(filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `rotate_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | 'a'...'z' => 'a' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:11:22 [INFO] [stderr] | [INFO] [stderr] 11 | 'A'...'Z' => 'A' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | .map_or_else(|| rotate_stdin(), |filename| rotate_file(filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `rotate_stdin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:41:55 [INFO] [stderr] | [INFO] [stderr] 41 | .map_or_else(|| rotate_stdin(), |filename| rotate_file(filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `rotate_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.27s [INFO] running `"docker" "inspect" "c1d282f1a9c0ca523d4c0e65a226323a0fdc725f5205aad6b4822ec04b160d7a"` [INFO] running `"docker" "rm" "-f" "c1d282f1a9c0ca523d4c0e65a226323a0fdc725f5205aad6b4822ec04b160d7a"` [INFO] [stdout] c1d282f1a9c0ca523d4c0e65a226323a0fdc725f5205aad6b4822ec04b160d7a