[INFO] updating cached repository lecrepuscule/Rust-collections [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lecrepuscule/Rust-collections [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lecrepuscule/Rust-collections" "work/ex/clippy-test-run/sources/stable/gh/lecrepuscule/Rust-collections"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lecrepuscule/Rust-collections'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lecrepuscule/Rust-collections" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lecrepuscule/Rust-collections"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lecrepuscule/Rust-collections'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7dc37c16f1b49c50b816e882c091ea7ccdbc1082 [INFO] sha for GitHub repo lecrepuscule/Rust-collections: 7dc37c16f1b49c50b816e882c091ea7ccdbc1082 [INFO] validating manifest of lecrepuscule/Rust-collections on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lecrepuscule/Rust-collections on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lecrepuscule/Rust-collections [INFO] finished frobbing lecrepuscule/Rust-collections [INFO] frobbed toml for lecrepuscule/Rust-collections written to work/ex/clippy-test-run/sources/stable/gh/lecrepuscule/Rust-collections/Cargo.toml [INFO] started frobbing lecrepuscule/Rust-collections [INFO] finished frobbing lecrepuscule/Rust-collections [INFO] frobbed toml for lecrepuscule/Rust-collections written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lecrepuscule/Rust-collections/Cargo.toml [INFO] crate lecrepuscule/Rust-collections has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lecrepuscule/Rust-collections against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lecrepuscule/Rust-collections:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fd43c5e10fbfc129d2fa275e3363359c13fed93671dc1153ec983d8b4b2b52f [INFO] running `"docker" "start" "-a" "6fd43c5e10fbfc129d2fa275e3363359c13fed93671dc1153ec983d8b4b2b52f"` [INFO] [stderr] Checking collections v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean_median_mode.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn get_mean(list: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean_median_mode.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn get_median(list: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean_median_mode.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn get_mode(list: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/pig_latin.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn pig_latin(input_string: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean_median_mode.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn get_mean(list: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean_median_mode.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn get_median(list: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mean_median_mode.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn get_mode(list: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/pig_latin.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn pig_latin(input_string: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "6fd43c5e10fbfc129d2fa275e3363359c13fed93671dc1153ec983d8b4b2b52f"` [INFO] running `"docker" "rm" "-f" "6fd43c5e10fbfc129d2fa275e3363359c13fed93671dc1153ec983d8b4b2b52f"` [INFO] [stdout] 6fd43c5e10fbfc129d2fa275e3363359c13fed93671dc1153ec983d8b4b2b52f