[INFO] updating cached repository lbialy/advent-of-code-2017-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lbialy/advent-of-code-2017-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lbialy/advent-of-code-2017-rust" "work/ex/clippy-test-run/sources/stable/gh/lbialy/advent-of-code-2017-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lbialy/advent-of-code-2017-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lbialy/advent-of-code-2017-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lbialy/advent-of-code-2017-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lbialy/advent-of-code-2017-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6607a3d3185a8c65eebc386d51b4c26efe242cb1 [INFO] sha for GitHub repo lbialy/advent-of-code-2017-rust: 6607a3d3185a8c65eebc386d51b4c26efe242cb1 [INFO] validating manifest of lbialy/advent-of-code-2017-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lbialy/advent-of-code-2017-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lbialy/advent-of-code-2017-rust [INFO] finished frobbing lbialy/advent-of-code-2017-rust [INFO] frobbed toml for lbialy/advent-of-code-2017-rust written to work/ex/clippy-test-run/sources/stable/gh/lbialy/advent-of-code-2017-rust/Cargo.toml [INFO] started frobbing lbialy/advent-of-code-2017-rust [INFO] finished frobbing lbialy/advent-of-code-2017-rust [INFO] frobbed toml for lbialy/advent-of-code-2017-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lbialy/advent-of-code-2017-rust/Cargo.toml [INFO] crate lbialy/advent-of-code-2017-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lbialy/advent-of-code-2017-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lbialy/advent-of-code-2017-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1f354ceaeddc5390faaf9bcb21c43340aff34f63a050e11c87c5abe5ab3d961 [INFO] running `"docker" "start" "-a" "f1f354ceaeddc5390faaf9bcb21c43340aff34f63a050e11c87c5abe5ab3d961"` [INFO] [stderr] Checking advent-of-code-2017-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:90:10 [INFO] [stderr] | [INFO] [stderr] 90 | (self.get(idx % self.len()).unwrap(), self.get((idx + next_offset) % self.len()).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self[idx % self.len()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:90:10 [INFO] [stderr] | [INFO] [stderr] 90 | (self.get(idx % self.len()).unwrap(), self.get((idx + next_offset) % self.len()).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self[idx % self.len()]` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:90:47 [INFO] [stderr] | [INFO] [stderr] 90 | (self.get(idx % self.len()).unwrap(), self.get((idx + next_offset) % self.len()).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self[(idx + next_offset) % self.len()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/day1.rs:90:47 [INFO] [stderr] | [INFO] [stderr] 90 | (self.get(idx % self.len()).unwrap(), self.get((idx + next_offset) % self.len()).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self[(idx + next_offset) % self.len()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:93:46 [INFO] [stderr] | [INFO] [stderr] 93 | let lines: Vec<&str> = spreadsheet.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|line| line.split("\t").collect::>()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day2.rs:128:19 [INFO] [stderr] | [INFO] [stderr] 128 | matches.iter().fold(0, |acc, curr| acc + curr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:93:46 [INFO] [stderr] | [INFO] [stderr] 93 | let lines: Vec<&str> = spreadsheet.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|line| line.split("\t").collect::>()) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day2.rs:128:19 [INFO] [stderr] | [INFO] [stderr] 128 | matches.iter().fold(0, |acc, curr| acc + curr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "f1f354ceaeddc5390faaf9bcb21c43340aff34f63a050e11c87c5abe5ab3d961"` [INFO] running `"docker" "rm" "-f" "f1f354ceaeddc5390faaf9bcb21c43340aff34f63a050e11c87c5abe5ab3d961"` [INFO] [stdout] f1f354ceaeddc5390faaf9bcb21c43340aff34f63a050e11c87c5abe5ab3d961