[INFO] updating cached repository lazear/cosmoline [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lazear/cosmoline [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/cosmoline" "work/ex/clippy-test-run/sources/stable/gh/lazear/cosmoline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lazear/cosmoline'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lazear/cosmoline" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/cosmoline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/cosmoline'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 03a2055ed5cac33b47e4cb59c2b86f474eb8ea0d [INFO] sha for GitHub repo lazear/cosmoline: 03a2055ed5cac33b47e4cb59c2b86f474eb8ea0d [INFO] validating manifest of lazear/cosmoline on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazear/cosmoline on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazear/cosmoline [INFO] finished frobbing lazear/cosmoline [INFO] frobbed toml for lazear/cosmoline written to work/ex/clippy-test-run/sources/stable/gh/lazear/cosmoline/Cargo.toml [INFO] started frobbing lazear/cosmoline [INFO] finished frobbing lazear/cosmoline [INFO] frobbed toml for lazear/cosmoline written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/cosmoline/Cargo.toml [INFO] crate lazear/cosmoline has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazear/cosmoline against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lazear/cosmoline:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf90b5cfe480243dc982cf2691894e53d64fe90b328de4a2e08ff5933b80d222 [INFO] running `"docker" "start" "-a" "bf90b5cfe480243dc982cf2691894e53d64fe90b328de4a2e08ff5933b80d222"` [INFO] [stderr] Checking cosmoline v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.input.peek().map(|c| *c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: The function/method `push_str` doesn't need a mutable reference [INFO] [stderr] --> src/lexer.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | m.push_str(&mut s); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.input.peek().map(|c| *c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: The function/method `push_str` doesn't need a mutable reference [INFO] [stderr] --> src/lexer.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | m.push_str(&mut s); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "bf90b5cfe480243dc982cf2691894e53d64fe90b328de4a2e08ff5933b80d222"` [INFO] running `"docker" "rm" "-f" "bf90b5cfe480243dc982cf2691894e53d64fe90b328de4a2e08ff5933b80d222"` [INFO] [stdout] bf90b5cfe480243dc982cf2691894e53d64fe90b328de4a2e08ff5933b80d222