[INFO] updating cached repository lasagnaphil/minesweeper-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lasagnaphil/minesweeper-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lasagnaphil/minesweeper-rs" "work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/minesweeper-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/minesweeper-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lasagnaphil/minesweeper-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/minesweeper-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/minesweeper-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 47ba8090057e4dc2fb8b7ae575499ce6169f51b5 [INFO] sha for GitHub repo lasagnaphil/minesweeper-rs: 47ba8090057e4dc2fb8b7ae575499ce6169f51b5 [INFO] validating manifest of lasagnaphil/minesweeper-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lasagnaphil/minesweeper-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lasagnaphil/minesweeper-rs [INFO] finished frobbing lasagnaphil/minesweeper-rs [INFO] frobbed toml for lasagnaphil/minesweeper-rs written to work/ex/clippy-test-run/sources/stable/gh/lasagnaphil/minesweeper-rs/Cargo.toml [INFO] started frobbing lasagnaphil/minesweeper-rs [INFO] finished frobbing lasagnaphil/minesweeper-rs [INFO] frobbed toml for lasagnaphil/minesweeper-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/minesweeper-rs/Cargo.toml [INFO] crate lasagnaphil/minesweeper-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lasagnaphil/minesweeper-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lasagnaphil/minesweeper-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48c0943304042c08fe204915d250b7c454d01959392db521b7eef0b90418de51 [INFO] running `"docker" "start" "-a" "48c0943304042c08fe204915d250b7c454d01959392db521b7eef0b90418de51"` [INFO] [stderr] Checking itertools v0.6.1 [INFO] [stderr] Checking minesweeper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | kind: kind, uncovered: false, marked: MarkType::No [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | kind: kind, uncovered: false, marked: MarkType::No [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `sample`, `thread_rng` [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `MouseEvent` [INFO] [stderr] --> src/main.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | use termion::event::{Key, Event, MouseEvent}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `color`, `style` [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | use termion::{color, style, cursor}; [INFO] [stderr] | ^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:120:54 [INFO] [stderr] | [INFO] [stderr] 120 | let list = (0..self.width).cartesian_product((0..self.height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:120:54 [INFO] [stderr] | [INFO] [stderr] 120 | let list = (0..self.width).cartesian_product((0..self.height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused imports: `sample`, `thread_rng` [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `MouseEvent` [INFO] [stderr] --> src/main.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | use termion::event::{Key, Event, MouseEvent}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `color`, `style` [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | use termion::{color, style, cursor}; [INFO] [stderr] | ^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:120:54 [INFO] [stderr] | [INFO] [stderr] 120 | let list = (0..self.width).cartesian_product((0..self.height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:120:54 [INFO] [stderr] | [INFO] [stderr] 120 | let list = (0..self.width).cartesian_product((0..self.height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: variable `gameConfig` should have a snake case name such as `game_config` [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | let gameConfig = match matches.value_of("DIFFICULTY") { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `gameConfig` should have a snake case name such as `game_config` [INFO] [stderr] --> src/main.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | let gameConfig = match matches.value_of("DIFFICULTY") { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.25s [INFO] running `"docker" "inspect" "48c0943304042c08fe204915d250b7c454d01959392db521b7eef0b90418de51"` [INFO] running `"docker" "rm" "-f" "48c0943304042c08fe204915d250b7c454d01959392db521b7eef0b90418de51"` [INFO] [stdout] 48c0943304042c08fe204915d250b7c454d01959392db521b7eef0b90418de51