[INFO] updating cached repository larspensjo/paul_heckel_diff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/larspensjo/paul_heckel_diff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/larspensjo/paul_heckel_diff" "work/ex/clippy-test-run/sources/stable/gh/larspensjo/paul_heckel_diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/larspensjo/paul_heckel_diff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/larspensjo/paul_heckel_diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larspensjo/paul_heckel_diff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larspensjo/paul_heckel_diff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec648dc2dd37e2cff9d60947a34e481dc4a4f3bc [INFO] sha for GitHub repo larspensjo/paul_heckel_diff: ec648dc2dd37e2cff9d60947a34e481dc4a4f3bc [INFO] validating manifest of larspensjo/paul_heckel_diff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of larspensjo/paul_heckel_diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing larspensjo/paul_heckel_diff [INFO] finished frobbing larspensjo/paul_heckel_diff [INFO] frobbed toml for larspensjo/paul_heckel_diff written to work/ex/clippy-test-run/sources/stable/gh/larspensjo/paul_heckel_diff/Cargo.toml [INFO] started frobbing larspensjo/paul_heckel_diff [INFO] finished frobbing larspensjo/paul_heckel_diff [INFO] frobbed toml for larspensjo/paul_heckel_diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larspensjo/paul_heckel_diff/Cargo.toml [INFO] crate larspensjo/paul_heckel_diff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting larspensjo/paul_heckel_diff against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/larspensjo/paul_heckel_diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b98e6b946f3b61a57703a21727939d931066be6b8edb04802ca19fbfdcdf968 [INFO] running `"docker" "start" "-a" "6b98e6b946f3b61a57703a21727939d931066be6b8edb04802ca19fbfdcdf968"` [INFO] [stderr] Checking paul_heckel_diff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | old_file: old_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `old_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | new_file: new_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:105:3 [INFO] [stderr] | [INFO] [stderr] 105 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | old_file: old_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `old_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | new_file: new_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:105:3 [INFO] [stderr] | [INFO] [stderr] 105 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:142 [INFO] [stderr] | [INFO] [stderr] 35 | let old_file : Vec<&str> = "BEGIN a mass of latin words falls upon the relevant facts like soft snow , covering up the details . END".split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:164 [INFO] [stderr] | [INFO] [stderr] 36 | let new_file : Vec<&str> = "BEGIN much writing is like snow , a mass of long words and phrases falls upon the relevant facts covering up the details . END".split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | fn new(old_file : &'a Vec, new_file : &'a Vec) -> Diff<'a, T> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn new(old_file : &'a Vec, new_file : &'a Vec) -> Diff<'a, T> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:34 [INFO] [stderr] | [INFO] [stderr] 98 | fn pretty_print_file(file : &Vec, mapping : &Vec) where T : Display { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | fn pretty_print_file(file : &Vec, mapping : &Vec) where T : Display { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Reference]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | fn create_symbol_table(file : &Vec) -> SymbolTable { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | if let &Reference::Confirmed(_) = reference { [INFO] [stderr] | _____________^ [INFO] [stderr] 183 | | if let Some(&Reference::Confirmed(_)) = self.symbol_table_old.get(symbol) { [INFO] [stderr] 184 | | out.push(symbol.clone()); [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 182 | if let Reference::Confirmed(_) = *reference { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:142 [INFO] [stderr] | [INFO] [stderr] 35 | let old_file : Vec<&str> = "BEGIN a mass of latin words falls upon the relevant facts like soft snow , covering up the details . END".split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:164 [INFO] [stderr] | [INFO] [stderr] 36 | let new_file : Vec<&str> = "BEGIN much writing is like snow , a mass of long words and phrases falls upon the relevant facts covering up the details . END".split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | fn new(old_file : &'a Vec, new_file : &'a Vec) -> Diff<'a, T> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:48:43 [INFO] [stderr] | [INFO] [stderr] 48 | fn new(old_file : &'a Vec, new_file : &'a Vec) -> Diff<'a, T> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:34 [INFO] [stderr] | [INFO] [stderr] 98 | fn pretty_print_file(file : &Vec, mapping : &Vec) where T : Display { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | fn pretty_print_file(file : &Vec, mapping : &Vec) where T : Display { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Reference]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | fn create_symbol_table(file : &Vec) -> SymbolTable { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:182:4 [INFO] [stderr] | [INFO] [stderr] 182 | if let &Reference::Confirmed(_) = reference { [INFO] [stderr] | _____________^ [INFO] [stderr] 183 | | if let Some(&Reference::Confirmed(_)) = self.symbol_table_old.get(symbol) { [INFO] [stderr] 184 | | out.push(symbol.clone()); [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 182 | if let Reference::Confirmed(_) = *reference { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "6b98e6b946f3b61a57703a21727939d931066be6b8edb04802ca19fbfdcdf968"` [INFO] running `"docker" "rm" "-f" "6b98e6b946f3b61a57703a21727939d931066be6b8edb04802ca19fbfdcdf968"` [INFO] [stdout] 6b98e6b946f3b61a57703a21727939d931066be6b8edb04802ca19fbfdcdf968