[INFO] updating cached repository lans98/transactions [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lans98/transactions [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lans98/transactions" "work/ex/clippy-test-run/sources/stable/gh/lans98/transactions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lans98/transactions'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lans98/transactions" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lans98/transactions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lans98/transactions'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0cd181b45a523c2559e23a4359599e248565410f [INFO] sha for GitHub repo lans98/transactions: 0cd181b45a523c2559e23a4359599e248565410f [INFO] validating manifest of lans98/transactions on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lans98/transactions on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lans98/transactions [INFO] finished frobbing lans98/transactions [INFO] frobbed toml for lans98/transactions written to work/ex/clippy-test-run/sources/stable/gh/lans98/transactions/Cargo.toml [INFO] started frobbing lans98/transactions [INFO] finished frobbing lans98/transactions [INFO] frobbed toml for lans98/transactions written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lans98/transactions/Cargo.toml [INFO] crate lans98/transactions has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lans98/transactions against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lans98/transactions:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a62ab21a98cd90437ac97d76471b4600a2ee2f663723d162f028036ec1ae85a2 [INFO] running `"docker" "start" "-a" "a62ab21a98cd90437ac97d76471b4600a2ee2f663723d162f028036ec1ae85a2"` [INFO] [stderr] Checking transactions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | let val = self.vars.get(&(x as *const T)).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.vars[&(x as *const T)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: The function/method `add_val` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | 'b' => cc.add_val(&mut x, -n)?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `add_val` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | 'e' => cc.add_val(&mut y, n)?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `add_val` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | 'h' => cc.add_val(&mut x, m)?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | let val = self.vars.get(&(x as *const T)).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.vars[&(x as *const T)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: The function/method `add_val` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | 'b' => cc.add_val(&mut x, -n)?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `add_val` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | 'e' => cc.add_val(&mut y, n)?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `add_val` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | 'h' => cc.add_val(&mut x, m)?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "a62ab21a98cd90437ac97d76471b4600a2ee2f663723d162f028036ec1ae85a2"` [INFO] running `"docker" "rm" "-f" "a62ab21a98cd90437ac97d76471b4600a2ee2f663723d162f028036ec1ae85a2"` [INFO] [stdout] a62ab21a98cd90437ac97d76471b4600a2ee2f663723d162f028036ec1ae85a2