[INFO] updating cached repository lachlansneff/minim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/lachlansneff/minim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/lachlansneff/minim" "work/ex/clippy-test-run/sources/stable/gh/lachlansneff/minim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/lachlansneff/minim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/lachlansneff/minim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/minim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/minim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7680e55328fd96b811dc8a54625f9b85d61f7121 [INFO] sha for GitHub repo lachlansneff/minim: 7680e55328fd96b811dc8a54625f9b85d61f7121 [INFO] validating manifest of lachlansneff/minim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lachlansneff/minim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lachlansneff/minim [INFO] finished frobbing lachlansneff/minim [INFO] frobbed toml for lachlansneff/minim written to work/ex/clippy-test-run/sources/stable/gh/lachlansneff/minim/Cargo.toml [INFO] started frobbing lachlansneff/minim [INFO] finished frobbing lachlansneff/minim [INFO] frobbed toml for lachlansneff/minim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/minim/Cargo.toml [INFO] crate lachlansneff/minim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lachlansneff/minim against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/lachlansneff/minim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50bcd8c364c6771e72e2b7a384dc368cdc494d103df80c9e881497afe6a8fe8a [INFO] running `"docker" "start" "-a" "50bcd8c364c6771e72e2b7a384dc368cdc494d103df80c9e881497afe6a8fe8a"` [INFO] [stderr] Checking minim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | Instruction::TernaryAssign(a, b, c, d, e, f) => self.ternary_assign(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:85:55 [INFO] [stderr] | [INFO] [stderr] 85 | Instruction::TernaryAssign(a, b, c, d, e, f) => self.ternary_assign(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | Instruction::TernaryGoto(a, b, c, d, e, f) => self.ternary_goto(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:86:53 [INFO] [stderr] | [INFO] [stderr] 86 | Instruction::TernaryGoto(a, b, c, d, e, f) => self.ternary_goto(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | Instruction::TernaryAssign(a, b, c, d, e, f) => self.ternary_assign(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:85:55 [INFO] [stderr] | [INFO] [stderr] 85 | Instruction::TernaryAssign(a, b, c, d, e, f) => self.ternary_assign(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | Instruction::TernaryGoto(a, b, c, d, e, f) => self.ternary_goto(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/runtime/runtime.rs:86:53 [INFO] [stderr] | [INFO] [stderr] 86 | Instruction::TernaryGoto(a, b, c, d, e, f) => self.ternary_goto(a, b, c, d, e, f), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/runtime/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod runtime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `self` [INFO] [stderr] --> src/runtime/runtime.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{self, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/runtime/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod runtime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `self` [INFO] [stderr] --> src/runtime/runtime.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{self, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value_type` [INFO] [stderr] --> src/runtime/runtime.rs:121:29 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn input(&mut self, value_type: ValueType, value: Value) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_value_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/runtime/runtime.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn input(&mut self, value_type: ValueType, value: Value) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/runtime/runtime.rs:125:36 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn create_label(&mut self, label: Label) { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/runtime/runtime.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn goto_label(&mut self, label: Label) { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cell` [INFO] [stderr] --> src/runtime/runtime.rs:133:38 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_cell` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk0` [INFO] [stderr] --> src/runtime/runtime.rs:133:55 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `eq` [INFO] [stderr] --> src/runtime/runtime.rs:133:68 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_eq` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk1` [INFO] [stderr] --> src/runtime/runtime.rs:133:82 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v0` [INFO] [stderr] --> src/runtime/runtime.rs:133:95 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v1` [INFO] [stderr] --> src/runtime/runtime.rs:133:106 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/runtime/runtime.rs:137:36 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk0` [INFO] [stderr] --> src/runtime/runtime.rs:137:50 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `eq` [INFO] [stderr] --> src/runtime/runtime.rs:137:63 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_eq` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk1` [INFO] [stderr] --> src/runtime/runtime.rs:137:77 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v0` [INFO] [stderr] --> src/runtime/runtime.rs:137:90 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v1` [INFO] [stderr] --> src/runtime/runtime.rs:137:101 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value_type` [INFO] [stderr] --> src/runtime/runtime.rs:121:29 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn input(&mut self, value_type: ValueType, value: Value) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_value_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/runtime/runtime.rs:121:52 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn input(&mut self, value_type: ValueType, value: Value) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/runtime/runtime.rs:125:36 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn create_label(&mut self, label: Label) { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/runtime/runtime.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn goto_label(&mut self, label: Label) { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cell` [INFO] [stderr] --> src/runtime/runtime.rs:133:38 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_cell` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk0` [INFO] [stderr] --> src/runtime/runtime.rs:133:55 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `eq` [INFO] [stderr] --> src/runtime/runtime.rs:133:68 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_eq` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk1` [INFO] [stderr] --> src/runtime/runtime.rs:133:82 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v0` [INFO] [stderr] --> src/runtime/runtime.rs:133:95 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v1` [INFO] [stderr] --> src/runtime/runtime.rs:133:106 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn ternary_assign(&mut self, cell: MemAccess, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/runtime/runtime.rs:137:36 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk0` [INFO] [stderr] --> src/runtime/runtime.rs:137:50 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `eq` [INFO] [stderr] --> src/runtime/runtime.rs:137:63 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_eq` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `chk1` [INFO] [stderr] --> src/runtime/runtime.rs:137:77 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^^^ help: consider using `_chk1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v0` [INFO] [stderr] --> src/runtime/runtime.rs:137:90 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v1` [INFO] [stderr] --> src/runtime/runtime.rs:137:101 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn ternary_goto(&mut self, label: Label, chk0: Value, eq: Equality, chk1: Value, v0: Value, v1: Value) { [INFO] [stderr] | ^^ help: consider using `_v1` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `labels` [INFO] [stderr] --> src/runtime/runtime.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | labels: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `labels` [INFO] [stderr] --> src/runtime/runtime.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | labels: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `runtime::runtime::Runtime` [INFO] [stderr] --> src/runtime/runtime.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Runtime { [INFO] [stderr] 26 | | Runtime { [INFO] [stderr] 27 | | values: vec![], [INFO] [stderr] 28 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for runtime::runtime::Runtime { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'm' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'i' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:70 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'i' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:81 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'm' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/runtime/runtime.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 46 | | // code is ascii code [INFO] [stderr] 47 | | [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/runtime/runtime.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | if bytes[0..6].eq(&start_bytes) { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 43 | | // code is bytecode [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/runtime/runtime.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / loop { [INFO] [stderr] 60 | | match self.next() { [INFO] [stderr] 61 | | Some(x) => self.execute_instruction(x), [INFO] [stderr] 62 | | None => break, [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(x) = self.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/runtime/runtime.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 68 | | if self.instruction_pointer >= self.program.len() { [INFO] [stderr] 69 | | // reached end of program [INFO] [stderr] 70 | | Option::None [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `runtime::runtime::Runtime` [INFO] [stderr] --> src/runtime/runtime.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Runtime { [INFO] [stderr] 26 | | Runtime { [INFO] [stderr] 27 | | values: vec![], [INFO] [stderr] 28 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | impl Default for runtime::runtime::Runtime { [INFO] [stderr] 25 | fn default() -> Self { [INFO] [stderr] 26 | Self::new() [INFO] [stderr] 27 | } [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'm' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'i' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:70 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'i' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/runtime/runtime.rs:41:81 [INFO] [stderr] | [INFO] [stderr] 41 | let start_bytes: [u8; 6] = ['m' as u8, 'i' as u8, 'n' as u8, 'i' as u8, 'm' as u8, 0]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'm' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/runtime/runtime.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 46 | | // code is ascii code [INFO] [stderr] 47 | | [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/runtime/runtime.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | if bytes[0..6].eq(&start_bytes) { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 43 | | // code is bytecode [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/runtime/runtime.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / loop { [INFO] [stderr] 60 | | match self.next() { [INFO] [stderr] 61 | | Some(x) => self.execute_instruction(x), [INFO] [stderr] 62 | | None => break, [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(x) = self.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/runtime/runtime.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 68 | | if self.instruction_pointer >= self.program.len() { [INFO] [stderr] 69 | | // reached end of program [INFO] [stderr] 70 | | Option::None [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let ret =` [INFO] [stderr] --> src/runtime/runtime.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let ret = self.values.insert(cell_index, v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let ret =` [INFO] [stderr] --> src/runtime/runtime.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let ret = self.values.insert(cell_index, v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/runtime/runtime.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | fn get_value(&mut self, value: Box) -> i64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/runtime/runtime.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | fn get_mem_value(&self, mem: Box) -> i64 { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/runtime/runtime.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | MemAccess::CellNum(i) => i as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/runtime/runtime.rs:169:31 [INFO] [stderr] | [INFO] [stderr] 169 | Literal::Index => self.runtime_values.current_index as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.runtime_values.current_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/runtime/runtime.rs:170:34 [INFO] [stderr] | [INFO] [stderr] 170 | Literal::LastCell => self.runtime_values.last_modified as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.runtime_values.last_modified)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/runtime/runtime.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | fn get_value(&mut self, value: Box) -> i64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/runtime/runtime.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | fn get_mem_value(&self, mem: Box) -> i64 { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/runtime/runtime.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | MemAccess::CellNum(i) => i as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/runtime/runtime.rs:169:31 [INFO] [stderr] | [INFO] [stderr] 169 | Literal::Index => self.runtime_values.current_index as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.runtime_values.current_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/runtime/runtime.rs:170:34 [INFO] [stderr] | [INFO] [stderr] 170 | Literal::LastCell => self.runtime_values.last_modified as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.runtime_values.last_modified)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `minim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `minim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "50bcd8c364c6771e72e2b7a384dc368cdc494d103df80c9e881497afe6a8fe8a"` [INFO] running `"docker" "rm" "-f" "50bcd8c364c6771e72e2b7a384dc368cdc494d103df80c9e881497afe6a8fe8a"` [INFO] [stdout] 50bcd8c364c6771e72e2b7a384dc368cdc494d103df80c9e881497afe6a8fe8a