[INFO] updating cached repository la10736/rust_thread_concurrent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/la10736/rust_thread_concurrent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/la10736/rust_thread_concurrent" "work/ex/clippy-test-run/sources/stable/gh/la10736/rust_thread_concurrent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/la10736/rust_thread_concurrent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/la10736/rust_thread_concurrent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/la10736/rust_thread_concurrent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/la10736/rust_thread_concurrent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6bb04848860cdedb1994388eca2038d1b80f0abd [INFO] sha for GitHub repo la10736/rust_thread_concurrent: 6bb04848860cdedb1994388eca2038d1b80f0abd [INFO] validating manifest of la10736/rust_thread_concurrent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of la10736/rust_thread_concurrent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing la10736/rust_thread_concurrent [INFO] finished frobbing la10736/rust_thread_concurrent [INFO] frobbed toml for la10736/rust_thread_concurrent written to work/ex/clippy-test-run/sources/stable/gh/la10736/rust_thread_concurrent/Cargo.toml [INFO] started frobbing la10736/rust_thread_concurrent [INFO] finished frobbing la10736/rust_thread_concurrent [INFO] frobbed toml for la10736/rust_thread_concurrent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/la10736/rust_thread_concurrent/Cargo.toml [INFO] crate la10736/rust_thread_concurrent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting la10736/rust_thread_concurrent against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/la10736/rust_thread_concurrent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 106615613f4198150f86c06b5bbf8fc2a09a3ae202edf849931f36c6cb2fc71d [INFO] running `"docker" "start" "-a" "106615613f4198150f86c06b5bbf8fc2a09a3ae202edf849931f36c6cb2fc71d"` [INFO] [stderr] Checking concurrent2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:5:37 [INFO] [stderr] | [INFO] [stderr] 5 | let r_val = std::sync::Arc::new(std::sync::Mutex::new(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | let result = r_val.lock().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r_val.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:5:37 [INFO] [stderr] | [INFO] [stderr] 5 | let r_val = std::sync::Arc::new(std::sync::Mutex::new(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | let result = r_val.lock().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `r_val.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "106615613f4198150f86c06b5bbf8fc2a09a3ae202edf849931f36c6cb2fc71d"` [INFO] running `"docker" "rm" "-f" "106615613f4198150f86c06b5bbf8fc2a09a3ae202edf849931f36c6cb2fc71d"` [INFO] [stdout] 106615613f4198150f86c06b5bbf8fc2a09a3ae202edf849931f36c6cb2fc71d