[INFO] updating cached repository kurennon/farkle.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kurennon/farkle.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kurennon/farkle.rs" "work/ex/clippy-test-run/sources/stable/gh/kurennon/farkle.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kurennon/farkle.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kurennon/farkle.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurennon/farkle.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurennon/farkle.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d83066e506fa1bb406d4e9e14bf5fc7526235372 [INFO] sha for GitHub repo kurennon/farkle.rs: d83066e506fa1bb406d4e9e14bf5fc7526235372 [INFO] validating manifest of kurennon/farkle.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kurennon/farkle.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kurennon/farkle.rs [INFO] finished frobbing kurennon/farkle.rs [INFO] frobbed toml for kurennon/farkle.rs written to work/ex/clippy-test-run/sources/stable/gh/kurennon/farkle.rs/Cargo.toml [INFO] started frobbing kurennon/farkle.rs [INFO] finished frobbing kurennon/farkle.rs [INFO] frobbed toml for kurennon/farkle.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurennon/farkle.rs/Cargo.toml [INFO] crate kurennon/farkle.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kurennon/farkle.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kurennon/farkle.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb59ba440f417647f584cbf826c3eacb45aeccc3fc30ff088c2edf0136785b4f [INFO] running `"docker" "start" "-a" "fb59ba440f417647f584cbf826c3eacb45aeccc3fc30ff088c2edf0136785b4f"` [INFO] [stderr] Checking farkle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:49:6 [INFO] [stderr] | [INFO] [stderr] 49 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:49:6 [INFO] [stderr] | [INFO] [stderr] 49 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:19:64 [INFO] [stderr] | [INFO] [stderr] 19 | while (!player.on_board() && round_score < 500) || re_roll == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `re_roll` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | if re_roll == false { // Player picked to stop playing [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!re_roll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | fn roll_dice(distribution: &Uniform, dice_num: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Uniform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `dots` is used to index `freq` [INFO] [stderr] --> src/main.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | for dots in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for (dots, ) in freq.iter().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | score += 100 * (triple + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(triple + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:170:32 [INFO] [stderr] | [INFO] [stderr] 170 | score += 100 * (triple + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(triple + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:19:64 [INFO] [stderr] | [INFO] [stderr] 19 | while (!player.on_board() && round_score < 500) || re_roll == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `re_roll` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | if re_roll == false { // Player picked to stop playing [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!re_roll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | fn roll_dice(distribution: &Uniform, dice_num: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Uniform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `dots` is used to index `freq` [INFO] [stderr] --> src/main.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | for dots in 0..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for (dots, ) in freq.iter().enumerate().take(6) { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:152:36 [INFO] [stderr] | [INFO] [stderr] 152 | score += 100 * (triple + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(triple + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:170:32 [INFO] [stderr] | [INFO] [stderr] 170 | score += 100 * (triple + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(triple + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "fb59ba440f417647f584cbf826c3eacb45aeccc3fc30ff088c2edf0136785b4f"` [INFO] running `"docker" "rm" "-f" "fb59ba440f417647f584cbf826c3eacb45aeccc3fc30ff088c2edf0136785b4f"` [INFO] [stdout] fb59ba440f417647f584cbf826c3eacb45aeccc3fc30ff088c2edf0136785b4f