[INFO] updating cached repository ksimon93/rustendo64 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ksimon93/rustendo64 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ksimon93/rustendo64" "work/ex/clippy-test-run/sources/stable/gh/ksimon93/rustendo64"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ksimon93/rustendo64'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ksimon93/rustendo64" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ksimon93/rustendo64"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ksimon93/rustendo64'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4783d02d334a12b7af6f10ad850ec3566af9807 [INFO] sha for GitHub repo ksimon93/rustendo64: f4783d02d334a12b7af6f10ad850ec3566af9807 [INFO] validating manifest of ksimon93/rustendo64 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ksimon93/rustendo64 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ksimon93/rustendo64 [INFO] finished frobbing ksimon93/rustendo64 [INFO] frobbed toml for ksimon93/rustendo64 written to work/ex/clippy-test-run/sources/stable/gh/ksimon93/rustendo64/Cargo.toml [INFO] started frobbing ksimon93/rustendo64 [INFO] finished frobbing ksimon93/rustendo64 [INFO] frobbed toml for ksimon93/rustendo64 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ksimon93/rustendo64/Cargo.toml [INFO] crate ksimon93/rustendo64 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ksimon93/rustendo64 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ksimon93/rustendo64:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d64724db8f901d757589f42efb68639201a95526ee543553f75ead8d78f5962 [INFO] running `"docker" "start" "-a" "5d64724db8f901d757589f42efb68639201a95526ee543553f75ead8d78f5962"` [INFO] [stderr] Checking rustendo64 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n64.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | cpu: cpu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | interconnect: interconnect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interconnect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | pif_rom: pif_rom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pif_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n64.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | cpu: cpu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | interconnect: interconnect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interconnect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | pif_rom: pif_rom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pif_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let rom = read_bin(rom_file_name); [INFO] [stderr] | ^^^ help: consider using `_rom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_gpr` [INFO] [stderr] --> src/cpu.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | reg_gpr: [u64; NUM_GPR], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_fpr` [INFO] [stderr] --> src/cpu.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | reg_fpr: [f64; NUM_GPR], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_pc` [INFO] [stderr] --> src/cpu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | reg_pc: u64, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_hi` [INFO] [stderr] --> src/cpu.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | reg_hi: u64, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_lo` [INFO] [stderr] --> src/cpu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | reg_lo: u64, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_llbit` [INFO] [stderr] --> src/cpu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | reg_llbit: bool, // TODO: Enum type [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_fcr0` [INFO] [stderr] --> src/cpu.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | reg_fcr0: u32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_fcr31` [INFO] [stderr] --> src/cpu.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | reg_fcr31: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `interconnect` [INFO] [stderr] --> src/cpu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | interconnect: interconnect::Interconnect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DxxDxx` [INFO] [stderr] --> src/cpu.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | DxxDxx, // TODO: Better name? [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RFU` [INFO] [stderr] --> src/cpu.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | RFU, // Reserved for Future Use [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LittleEndian` [INFO] [stderr] --> src/cpu.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | LittleEndian, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_ROM_SIZE` [INFO] [stderr] --> src/interconnect.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const PIF_ROM_SIZE: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pif_rom` [INFO] [stderr] --> src/interconnect.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | pif_rom: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ram` [INFO] [stderr] --> src/interconnect.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | ram: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/cpu.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / loop { [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let rom = read_bin(rom_file_name); [INFO] [stderr] | ^^^ help: consider using `_rom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_gpr` [INFO] [stderr] --> src/cpu.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | reg_gpr: [u64; NUM_GPR], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_fpr` [INFO] [stderr] --> src/cpu.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | reg_fpr: [f64; NUM_GPR], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_pc` [INFO] [stderr] --> src/cpu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | reg_pc: u64, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_hi` [INFO] [stderr] --> src/cpu.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | reg_hi: u64, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_lo` [INFO] [stderr] --> src/cpu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | reg_lo: u64, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_llbit` [INFO] [stderr] --> src/cpu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | reg_llbit: bool, // TODO: Enum type [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_fcr0` [INFO] [stderr] --> src/cpu.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | reg_fcr0: u32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reg_fcr31` [INFO] [stderr] --> src/cpu.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | reg_fcr31: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `interconnect` [INFO] [stderr] --> src/cpu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | interconnect: interconnect::Interconnect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DxxDxx` [INFO] [stderr] --> src/cpu.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | DxxDxx, // TODO: Better name? [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RFU` [INFO] [stderr] --> src/cpu.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | RFU, // Reserved for Future Use [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LittleEndian` [INFO] [stderr] --> src/cpu.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | LittleEndian, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_ROM_SIZE` [INFO] [stderr] --> src/interconnect.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const PIF_ROM_SIZE: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pif_rom` [INFO] [stderr] --> src/interconnect.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | pif_rom: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ram` [INFO] [stderr] --> src/interconnect.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | ram: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/cpu.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / loop { [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "5d64724db8f901d757589f42efb68639201a95526ee543553f75ead8d78f5962"` [INFO] running `"docker" "rm" "-f" "5d64724db8f901d757589f42efb68639201a95526ee543553f75ead8d78f5962"` [INFO] [stdout] 5d64724db8f901d757589f42efb68639201a95526ee543553f75ead8d78f5962