[INFO] updating cached repository krstoff/error
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/krstoff/error
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/krstoff/error" "work/ex/clippy-test-run/sources/stable/gh/krstoff/error"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/krstoff/error'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/krstoff/error" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krstoff/error"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krstoff/error'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6979828654a6a9a3ed97e2ba0390518a667839c8
[INFO] sha for GitHub repo krstoff/error: 6979828654a6a9a3ed97e2ba0390518a667839c8
[INFO] validating manifest of krstoff/error on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of krstoff/error on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing krstoff/error
[INFO] finished frobbing krstoff/error
[INFO] frobbed toml for krstoff/error written to work/ex/clippy-test-run/sources/stable/gh/krstoff/error/Cargo.toml
[INFO] started frobbing krstoff/error
[INFO] finished frobbing krstoff/error
[INFO] frobbed toml for krstoff/error written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krstoff/error/Cargo.toml
[INFO] crate krstoff/error has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting krstoff/error against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krstoff/error:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8ff34fa87f4b646494d6efaa7d5cd41345888ac2c1a3c1ff82cf77591b01f6aa
[INFO] running `"docker" "start" "-a" "8ff34fa87f4b646494d6efaa7d5cd41345888ac2c1a3c1ff82cf77591b01f6aa"`
[INFO] [stderr]     Checking error v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parse/lex.rs:113:13
[INFO] [stderr]     |
[INFO] [stderr] 113 |             src: src,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parse/lex.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |             string_pool: string_pool,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string_pool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parse/lex.rs:113:13
[INFO] [stderr]     |
[INFO] [stderr] 113 |             src: src,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `src`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parse/lex.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |             string_pool: string_pool,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string_pool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parse/interning.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return id;
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse/lex.rs:261:9
[INFO] [stderr]     |
[INFO] [stderr] 261 |         return Some(symbol);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(symbol)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse/lex.rs:270:9
[INFO] [stderr]     |
[INFO] [stderr] 270 |         return self.peek;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parse/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | mod parse;
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse/parse.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return left;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `left`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parse/interning.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return id;
[INFO] [stderr]    |         ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse/lex.rs:261:9
[INFO] [stderr]     |
[INFO] [stderr] 261 |         return Some(symbol);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(symbol)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse/lex.rs:270:9
[INFO] [stderr]     |
[INFO] [stderr] 270 |         return self.peek;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.peek`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/parse/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | mod parse;
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parse/parse.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return left;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `left`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: private type `parse::parse::BinOp` in public interface (error E0446)
[INFO] [stderr]   --> src/parse/parse.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         op: BinOp,
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(private_in_public)] on by default
[INFO] [stderr]    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]    = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: private type `parse::parse::UnOp` in public interface (error E0446)
[INFO] [stderr]   --> src/parse/parse.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         op: UnOp,
[INFO] [stderr]    |         ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]    = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `print`
[INFO] [stderr]   --> src/parse/lex.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn print(&self, string_pool: &StringPool) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `Statement`
[INFO] [stderr]    --> src/parse/parse.rs:152:1
[INFO] [stderr]     |
[INFO] [stderr] 152 | pub enum Statement {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `statement`
[INFO] [stderr]    --> src/parse/parse.rs:156:1
[INFO] [stderr]     |
[INFO] [stderr] 156 | pub fn statement(token_stream: &mut TokenStream) -> Box<Statement> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parse/interning.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         match self.ids.get(s) {
[INFO] [stderr] 23 | |             Some(id) => { return *id; }
[INFO] [stderr] 24 | |             None => { }
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(id) = self.ids.get(s) { return *id; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parse/lex.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         match self {
[INFO] [stderr] 43 | |             &Int(i) => print!("{}", i),
[INFO] [stderr] 44 | |             &Ident(id) => print!("{}", string_pool.get(id)),
[INFO] [stderr] 45 | |             &Semicolon => print!(";"),
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |             &Or => print!("||"),
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 42 |         match *self {
[INFO] [stderr] 43 |             Int(i) => print!("{}", i),
[INFO] [stderr] 44 |             Ident(id) => print!("{}", string_pool.get(id)),
[INFO] [stderr] 45 |             Semicolon => print!(";"),
[INFO] [stderr] 46 |             OpenBrace => print!("{{"),
[INFO] [stderr] 47 |             CloseBrace => print!("}}"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parse/lex.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 | /         match self {
[INFO] [stderr] 71 | |             &Int(i) => write!(f, "{}", i),
[INFO] [stderr] 72 | |             &Ident(id) => write!(f, "string_id:{}", id),
[INFO] [stderr] 73 | |             &Semicolon => write!(f, ";"),
[INFO] [stderr] ...  |
[INFO] [stderr] 91 | |             &Or => write!(f, "||"),
[INFO] [stderr] 92 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 70 |         match *self {
[INFO] [stderr] 71 |             Int(i) => write!(f, "{}", i),
[INFO] [stderr] 72 |             Ident(id) => write!(f, "string_id:{}", id),
[INFO] [stderr] 73 |             Semicolon => write!(f, ";"),
[INFO] [stderr] 74 |             OpenBrace => write!(f, "{{"),
[INFO] [stderr] 75 |             CloseBrace => write!(f, "}}"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parse/parse.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     match e {
[INFO] [stderr] 27 | |         &IntLiteral(i) => print!("{}", i),
[INFO] [stderr] 28 | |         &Expression::BinOp { op, ref left, ref right } => {
[INFO] [stderr] 29 | |             print!("(");
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         }
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 26 |     match *e {
[INFO] [stderr] 27 |         IntLiteral(i) => print!("{}", i),
[INFO] [stderr] 28 |         Expression::BinOp { op, ref left, ref right } => {
[INFO] [stderr] 29 |             print!("(");
[INFO] [stderr] 30 |             print!("{} ", match op {
[INFO] [stderr] 31 |                 BinOp::Add => "+",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: private type `parse::parse::BinOp` in public interface (error E0446)
[INFO] [stderr]   --> src/parse/parse.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         op: BinOp,
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(private_in_public)] on by default
[INFO] [stderr]    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]    = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: private type `parse::parse::UnOp` in public interface (error E0446)
[INFO] [stderr]   --> src/parse/parse.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         op: UnOp,
[INFO] [stderr]    |         ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[INFO] [stderr]    = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
[INFO] [stderr] 
[INFO] [stderr] warning: you probably are missing some parameter in your format string
[INFO] [stderr]   --> src/parse/parse.rs:72:26
[INFO] [stderr]    |
[INFO] [stderr] 72 |         None => { panic!("Could not parse. Expected {:?}, but stream abruptly ended.") }
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::panic_params)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `print`
[INFO] [stderr]   --> src/parse/lex.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn print(&self, string_pool: &StringPool) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `Statement`
[INFO] [stderr]    --> src/parse/parse.rs:152:1
[INFO] [stderr]     |
[INFO] [stderr] 152 | pub enum Statement {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `statement`
[INFO] [stderr]    --> src/parse/parse.rs:156:1
[INFO] [stderr]     |
[INFO] [stderr] 156 | pub fn statement(token_stream: &mut TokenStream) -> Box<Statement> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parse/interning.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         match self.ids.get(s) {
[INFO] [stderr] 23 | |             Some(id) => { return *id; }
[INFO] [stderr] 24 | |             None => { }
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(id) = self.ids.get(s) { return *id; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parse/lex.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 | /         match self {
[INFO] [stderr] 43 | |             &Int(i) => print!("{}", i),
[INFO] [stderr] 44 | |             &Ident(id) => print!("{}", string_pool.get(id)),
[INFO] [stderr] 45 | |             &Semicolon => print!(";"),
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |             &Or => print!("||"),
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 42 |         match *self {
[INFO] [stderr] 43 |             Int(i) => print!("{}", i),
[INFO] [stderr] 44 |             Ident(id) => print!("{}", string_pool.get(id)),
[INFO] [stderr] 45 |             Semicolon => print!(";"),
[INFO] [stderr] 46 |             OpenBrace => print!("{{"),
[INFO] [stderr] 47 |             CloseBrace => print!("}}"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parse/lex.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 | /         match self {
[INFO] [stderr] 71 | |             &Int(i) => write!(f, "{}", i),
[INFO] [stderr] 72 | |             &Ident(id) => write!(f, "string_id:{}", id),
[INFO] [stderr] 73 | |             &Semicolon => write!(f, ";"),
[INFO] [stderr] ...  |
[INFO] [stderr] 91 | |             &Or => write!(f, "||"),
[INFO] [stderr] 92 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 70 |         match *self {
[INFO] [stderr] 71 |             Int(i) => write!(f, "{}", i),
[INFO] [stderr] 72 |             Ident(id) => write!(f, "string_id:{}", id),
[INFO] [stderr] 73 |             Semicolon => write!(f, ";"),
[INFO] [stderr] 74 |             OpenBrace => write!(f, "{{"),
[INFO] [stderr] 75 |             CloseBrace => write!(f, "}}"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parse/parse.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     match e {
[INFO] [stderr] 27 | |         &IntLiteral(i) => print!("{}", i),
[INFO] [stderr] 28 | |         &Expression::BinOp { op, ref left, ref right } => {
[INFO] [stderr] 29 | |             print!("(");
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         }
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 26 |     match *e {
[INFO] [stderr] 27 |         IntLiteral(i) => print!("{}", i),
[INFO] [stderr] 28 |         Expression::BinOp { op, ref left, ref right } => {
[INFO] [stderr] 29 |             print!("(");
[INFO] [stderr] 30 |             print!("{} ", match op {
[INFO] [stderr] 31 |                 BinOp::Add => "+",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you probably are missing some parameter in your format string
[INFO] [stderr]   --> src/parse/parse.rs:72:26
[INFO] [stderr]    |
[INFO] [stderr] 72 |         None => { panic!("Could not parse. Expected {:?}, but stream abruptly ended.") }
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::panic_params)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.52s
[INFO] running `"docker" "inspect" "8ff34fa87f4b646494d6efaa7d5cd41345888ac2c1a3c1ff82cf77591b01f6aa"`
[INFO] running `"docker" "rm" "-f" "8ff34fa87f4b646494d6efaa7d5cd41345888ac2c1a3c1ff82cf77591b01f6aa"`
[INFO] [stdout] 8ff34fa87f4b646494d6efaa7d5cd41345888ac2c1a3c1ff82cf77591b01f6aa