[INFO] updating cached repository krixon/knights-tour-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/krixon/knights-tour-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/krixon/knights-tour-rs" "work/ex/clippy-test-run/sources/stable/gh/krixon/knights-tour-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/krixon/knights-tour-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/krixon/knights-tour-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krixon/knights-tour-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krixon/knights-tour-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9cc5756bff781871a102a765ec74a3ea0f5bc3b6 [INFO] sha for GitHub repo krixon/knights-tour-rs: 9cc5756bff781871a102a765ec74a3ea0f5bc3b6 [INFO] validating manifest of krixon/knights-tour-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of krixon/knights-tour-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing krixon/knights-tour-rs [INFO] finished frobbing krixon/knights-tour-rs [INFO] frobbed toml for krixon/knights-tour-rs written to work/ex/clippy-test-run/sources/stable/gh/krixon/knights-tour-rs/Cargo.toml [INFO] started frobbing krixon/knights-tour-rs [INFO] finished frobbing krixon/knights-tour-rs [INFO] frobbed toml for krixon/knights-tour-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krixon/knights-tour-rs/Cargo.toml [INFO] crate krixon/knights-tour-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting krixon/knights-tour-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krixon/knights-tour-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15918ed81aab529cf7faee9e2a80b3c565e4bb150cb4abeb9aca636efcc2a729 [INFO] running `"docker" "start" "-a" "15918ed81aab529cf7faee9e2a80b3c565e4bb150cb4abeb9aca636efcc2a729"` [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking knights_tour v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | Graph {nodes: nodes} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:15 [INFO] [stderr] | [INFO] [stderr] 102 | Edge {pheromone: pheromone, target: target} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pheromone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | Edge {pheromone: pheromone, target: target} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:120:14 [INFO] [stderr] | [INFO] [stderr] 120 | Ant {start: start, current: start, tabu: tabu, moves: Vec::with_capacity(64)} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:120:44 [INFO] [stderr] | [INFO] [stderr] 120 | Ant {start: start, current: start, tabu: tabu, moves: Vec::with_capacity(64)} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tabu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | p_evap_rate: p_evap_rate [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p_evap_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | Graph {nodes: nodes} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:15 [INFO] [stderr] | [INFO] [stderr] 102 | Edge {pheromone: pheromone, target: target} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pheromone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | Edge {pheromone: pheromone, target: target} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:120:14 [INFO] [stderr] | [INFO] [stderr] 120 | Ant {start: start, current: start, tabu: tabu, moves: Vec::with_capacity(64)} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:120:44 [INFO] [stderr] | [INFO] [stderr] 120 | Ant {start: start, current: start, tabu: tabu, moves: Vec::with_capacity(64)} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tabu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | p_evap_rate: p_evap_rate [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p_evap_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:247:43 [INFO] [stderr] | [INFO] [stderr] 247 | let mut tour_finder = TourFinder::new(0.000001, 0.25); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:247:43 [INFO] [stderr] | [INFO] [stderr] 247 | let mut tour_finder = TourFinder::new(0.000001, 0.25); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | for x in min_x..max_x + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `min_x..=max_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | for y in min_y..max_y + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `min_y..=max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:46 [INFO] [stderr] | [INFO] [stderr] 62 | fn evaporate_pheromones(&mut self, rate: &f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | for x in min_x..max_x + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `min_x..=max_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | for y in min_y..max_y + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `min_y..=max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:46 [INFO] [stderr] | [INFO] [stderr] 62 | fn evaporate_pheromones(&mut self, rate: &f32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.53s [INFO] running `"docker" "inspect" "15918ed81aab529cf7faee9e2a80b3c565e4bb150cb4abeb9aca636efcc2a729"` [INFO] running `"docker" "rm" "-f" "15918ed81aab529cf7faee9e2a80b3c565e4bb150cb4abeb9aca636efcc2a729"` [INFO] [stdout] 15918ed81aab529cf7faee9e2a80b3c565e4bb150cb4abeb9aca636efcc2a729