[INFO] updating cached repository krahul84/ConnectFour [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/krahul84/ConnectFour [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/krahul84/ConnectFour" "work/ex/clippy-test-run/sources/stable/gh/krahul84/ConnectFour"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/krahul84/ConnectFour'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/krahul84/ConnectFour" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krahul84/ConnectFour"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krahul84/ConnectFour'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a57491cf7632dd59f2c49bcdc98d7a991086d5b2 [INFO] sha for GitHub repo krahul84/ConnectFour: a57491cf7632dd59f2c49bcdc98d7a991086d5b2 [INFO] validating manifest of krahul84/ConnectFour on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of krahul84/ConnectFour on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing krahul84/ConnectFour [INFO] finished frobbing krahul84/ConnectFour [INFO] frobbed toml for krahul84/ConnectFour written to work/ex/clippy-test-run/sources/stable/gh/krahul84/ConnectFour/Cargo.toml [INFO] started frobbing krahul84/ConnectFour [INFO] finished frobbing krahul84/ConnectFour [INFO] frobbed toml for krahul84/ConnectFour written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krahul84/ConnectFour/Cargo.toml [INFO] crate krahul84/ConnectFour has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting krahul84/ConnectFour against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/krahul84/ConnectFour:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e4d518b1993bdd00a5c0e915613a125fdff251ba3d3af62372da1e88bd5c15a [INFO] running `"docker" "start" "-a" "9e4d518b1993bdd00a5c0e915613a125fdff251ba3d3af62372da1e88bd5c15a"` [INFO] [stderr] Checking ConnectFour v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | row_size: row_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `row_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | col_size: col_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `col_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | row_size: row_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `row_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | col_size: col_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `col_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | _ => return Err(()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | _ => return Err(()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: crate `ConnectFour` should have a snake case name such as `connect_four` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | pub fn check_player(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | / match grid.winner() { [INFO] [stderr] 298 | | Some(winner) => { [INFO] [stderr] 299 | | println!("The winner is Player {}", winner); [INFO] [stderr] 300 | | break; [INFO] [stderr] 301 | | }, [INFO] [stderr] 302 | | None => {}, [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 297 | if let Some(winner) = grid.winner() { [INFO] [stderr] 298 | println!("The winner is Player {}", winner); [INFO] [stderr] 299 | break; [INFO] [stderr] 300 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: crate `ConnectFour` should have a snake case name such as `connect_four` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | pub fn check_player(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | / match grid.winner() { [INFO] [stderr] 298 | | Some(winner) => { [INFO] [stderr] 299 | | println!("The winner is Player {}", winner); [INFO] [stderr] 300 | | break; [INFO] [stderr] 301 | | }, [INFO] [stderr] 302 | | None => {}, [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 297 | if let Some(winner) = grid.winner() { [INFO] [stderr] 298 | println!("The winner is Player {}", winner); [INFO] [stderr] 299 | break; [INFO] [stderr] 300 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "9e4d518b1993bdd00a5c0e915613a125fdff251ba3d3af62372da1e88bd5c15a"` [INFO] running `"docker" "rm" "-f" "9e4d518b1993bdd00a5c0e915613a125fdff251ba3d3af62372da1e88bd5c15a"` [INFO] [stdout] 9e4d518b1993bdd00a5c0e915613a125fdff251ba3d3af62372da1e88bd5c15a