[INFO] updating cached repository kr-b/dna_encoder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kr-b/dna_encoder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kr-b/dna_encoder" "work/ex/clippy-test-run/sources/stable/gh/kr-b/dna_encoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kr-b/dna_encoder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kr-b/dna_encoder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kr-b/dna_encoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kr-b/dna_encoder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6766acd78e8b56b7ba1698a9bebe8231d872bf00 [INFO] sha for GitHub repo kr-b/dna_encoder: 6766acd78e8b56b7ba1698a9bebe8231d872bf00 [INFO] validating manifest of kr-b/dna_encoder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kr-b/dna_encoder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kr-b/dna_encoder [INFO] finished frobbing kr-b/dna_encoder [INFO] frobbed toml for kr-b/dna_encoder written to work/ex/clippy-test-run/sources/stable/gh/kr-b/dna_encoder/Cargo.toml [INFO] started frobbing kr-b/dna_encoder [INFO] finished frobbing kr-b/dna_encoder [INFO] frobbed toml for kr-b/dna_encoder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kr-b/dna_encoder/Cargo.toml [INFO] crate kr-b/dna_encoder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kr-b/dna_encoder against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kr-b/dna_encoder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50f009cb7a7371314b3c3cd8061782fba5d7c09f1567ea9c05c36e55a835c2ab [INFO] running `"docker" "start" "-a" "50f009cb7a7371314b3c3cd8061782fba5d7c09f1567ea9c05c36e55a835c2ab"` [INFO] [stderr] Checking dna_encoder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | return [b1, b2, b3, b4] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | return [b1, b2, b3, b4] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[b1, b2, b3, b4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 4..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in args.iter().skip(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | let mut n = bit.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `bit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | let mut n = input.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:143:20 [INFO] [stderr] | [INFO] [stderr] 143 | if *bit != ' ' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:168:39 [INFO] [stderr] | [INFO] [stderr] 168 | out += (base.pow(i as u32)) * (*bit as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(*bit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 4..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in args.iter().skip(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | let mut n = bit.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `bit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | let mut n = input.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:143:20 [INFO] [stderr] | [INFO] [stderr] 143 | if *bit != ' ' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:168:39 [INFO] [stderr] | [INFO] [stderr] 168 | out += (base.pow(i as u32)) * (*bit as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(*bit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "50f009cb7a7371314b3c3cd8061782fba5d7c09f1567ea9c05c36e55a835c2ab"` [INFO] running `"docker" "rm" "-f" "50f009cb7a7371314b3c3cd8061782fba5d7c09f1567ea9c05c36e55a835c2ab"` [INFO] [stdout] 50f009cb7a7371314b3c3cd8061782fba5d7c09f1567ea9c05c36e55a835c2ab