[INFO] updating cached repository kpcyrd/labsh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kpcyrd/labsh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kpcyrd/labsh" "work/ex/clippy-test-run/sources/stable/gh/kpcyrd/labsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kpcyrd/labsh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kpcyrd/labsh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/labsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/labsh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a765225cb368e475d1ce4bd31c58a4205fbda156 [INFO] sha for GitHub repo kpcyrd/labsh: a765225cb368e475d1ce4bd31c58a4205fbda156 [INFO] validating manifest of kpcyrd/labsh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kpcyrd/labsh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kpcyrd/labsh [INFO] finished frobbing kpcyrd/labsh [INFO] frobbed toml for kpcyrd/labsh written to work/ex/clippy-test-run/sources/stable/gh/kpcyrd/labsh/Cargo.toml [INFO] started frobbing kpcyrd/labsh [INFO] finished frobbing kpcyrd/labsh [INFO] frobbed toml for kpcyrd/labsh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/labsh/Cargo.toml [INFO] crate kpcyrd/labsh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kpcyrd/labsh against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kpcyrd/labsh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6385f4f3db192caa9808c1d46fac160c7da1a8bcff499046e446d65103c1ecd5 [INFO] running `"docker" "start" "-a" "6385f4f3db192caa9808c1d46fac160c7da1a8bcff499046e446d65103c1ecd5"` [INFO] [stderr] Checking serde v1.0.2 [INFO] [stderr] Checking toml v0.4.0 [INFO] [stderr] Checking labsh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | tasks: tasks [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tasks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/build.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | tasks: tasks [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tasks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/build.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/config.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | for (name, options) in tasks.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match config.get("image") { [INFO] [stderr] 71 | | Some(image) => { [INFO] [stderr] 72 | | let image = image.as_str().unwrap(); [INFO] [stderr] 73 | | tasks.push(Task::new("docker", vec!["build", "--pull", "-t", image, "--", path])); [INFO] [stderr] ... | [INFO] [stderr] 76 | | None => {}, [INFO] [stderr] 77 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(image) = config.get("image") { [INFO] [stderr] 71 | let image = image.as_str().unwrap(); [INFO] [stderr] 72 | tasks.push(Task::new("docker", vec!["build", "--pull", "-t", image, "--", path])); [INFO] [stderr] 73 | tasks.push(Task::new("docker", vec!["push", "--", image])); [INFO] [stderr] 74 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/config.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | for (name, options) in tasks.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match config.get("image") { [INFO] [stderr] 71 | | Some(image) => { [INFO] [stderr] 72 | | let image = image.as_str().unwrap(); [INFO] [stderr] 73 | | tasks.push(Task::new("docker", vec!["build", "--pull", "-t", image, "--", path])); [INFO] [stderr] ... | [INFO] [stderr] 76 | | None => {}, [INFO] [stderr] 77 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(image) = config.get("image") { [INFO] [stderr] 71 | let image = image.as_str().unwrap(); [INFO] [stderr] 72 | tasks.push(Task::new("docker", vec!["build", "--pull", "-t", image, "--", path])); [INFO] [stderr] 73 | tasks.push(Task::new("docker", vec!["push", "--", image])); [INFO] [stderr] 74 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.35s [INFO] running `"docker" "inspect" "6385f4f3db192caa9808c1d46fac160c7da1a8bcff499046e446d65103c1ecd5"` [INFO] running `"docker" "rm" "-f" "6385f4f3db192caa9808c1d46fac160c7da1a8bcff499046e446d65103c1ecd5"` [INFO] [stdout] 6385f4f3db192caa9808c1d46fac160c7da1a8bcff499046e446d65103c1ecd5