[INFO] updating cached repository kolybasov/fm_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kolybasov/fm_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kolybasov/fm_tree" "work/ex/clippy-test-run/sources/stable/gh/kolybasov/fm_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kolybasov/fm_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kolybasov/fm_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolybasov/fm_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolybasov/fm_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a26f097d080e912075c4862e1c669373c4098f9f [INFO] sha for GitHub repo kolybasov/fm_tree: a26f097d080e912075c4862e1c669373c4098f9f [INFO] validating manifest of kolybasov/fm_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kolybasov/fm_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kolybasov/fm_tree [INFO] finished frobbing kolybasov/fm_tree [INFO] frobbed toml for kolybasov/fm_tree written to work/ex/clippy-test-run/sources/stable/gh/kolybasov/fm_tree/Cargo.toml [INFO] started frobbing kolybasov/fm_tree [INFO] finished frobbing kolybasov/fm_tree [INFO] frobbed toml for kolybasov/fm_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolybasov/fm_tree/Cargo.toml [INFO] crate kolybasov/fm_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kolybasov/fm_tree against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolybasov/fm_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c493f9e6b44032aa3231951df289bdd36fe6c158cd65d5d2e8dbd992d944d43 [INFO] running `"docker" "start" "-a" "9c493f9e6b44032aa3231951df289bdd36fe6c158cd65d5d2e8dbd992d944d43"` [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking fm_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fs_tree.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fs_tree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | write!(acc, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fs_tree.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/fs_tree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | write!(acc, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/fs_tree.rs:55:46 [INFO] [stderr] | [INFO] [stderr] 55 | for (idx, child) in (&self.children).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/fs_tree.rs:55:46 [INFO] [stderr] | [INFO] [stderr] 55 | for (idx, child) in (&self.children).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.42s [INFO] running `"docker" "inspect" "9c493f9e6b44032aa3231951df289bdd36fe6c158cd65d5d2e8dbd992d944d43"` [INFO] running `"docker" "rm" "-f" "9c493f9e6b44032aa3231951df289bdd36fe6c158cd65d5d2e8dbd992d944d43"` [INFO] [stdout] 9c493f9e6b44032aa3231951df289bdd36fe6c158cd65d5d2e8dbd992d944d43