[INFO] updating cached repository kojole-sandbox/piyokvs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kojole-sandbox/piyokvs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kojole-sandbox/piyokvs" "work/ex/clippy-test-run/sources/stable/gh/kojole-sandbox/piyokvs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kojole-sandbox/piyokvs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kojole-sandbox/piyokvs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole-sandbox/piyokvs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole-sandbox/piyokvs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 13c83777166a8950e8c92677f6cf7da14a621922 [INFO] sha for GitHub repo kojole-sandbox/piyokvs: 13c83777166a8950e8c92677f6cf7da14a621922 [INFO] validating manifest of kojole-sandbox/piyokvs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kojole-sandbox/piyokvs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kojole-sandbox/piyokvs [INFO] finished frobbing kojole-sandbox/piyokvs [INFO] frobbed toml for kojole-sandbox/piyokvs written to work/ex/clippy-test-run/sources/stable/gh/kojole-sandbox/piyokvs/Cargo.toml [INFO] started frobbing kojole-sandbox/piyokvs [INFO] finished frobbing kojole-sandbox/piyokvs [INFO] frobbed toml for kojole-sandbox/piyokvs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole-sandbox/piyokvs/Cargo.toml [INFO] crate kojole-sandbox/piyokvs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kojole-sandbox/piyokvs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole-sandbox/piyokvs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34e4db3b4bd8f45cffb9b379c81171fb56b1d4cdd173894a7e10f3dc5e690cd1 [INFO] running `"docker" "start" "-a" "34e4db3b4bd8f45cffb9b379c81171fb56b1d4cdd173894a7e10f3dc5e690cd1"` [INFO] [stderr] Checking piyokvs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::SingleCache` [INFO] [stderr] --> src/cache.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> SingleCache { [INFO] [stderr] 53 | | SingleCache { [INFO] [stderr] 54 | | entry: Mutex::new(Default::default()), [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | if let Some(i) = self.keys.get(&key).map(|i| *i) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.keys.get(&key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | write_zeros(&mut file, (n_data as u64) * (size_of::() as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(n_data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:42:19 [INFO] [stderr] | [INFO] [stderr] 42 | let pos = key as u64 * size_of::() as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | let pos = key as u64 * size_of::() as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/storage.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | let ptr: *mut u8 = transmute(dst); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `dst as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/storage.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | let ptr: *const u8 = transmute(src); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `src as *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:82:57 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(buffer.lock(key).unwrap().value, key as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:96:31 [INFO] [stderr] | [INFO] [stderr] 96 | *entry.as_mut() = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:122:39 [INFO] [stderr] | [INFO] [stderr] 122 | *entry.as_mut() = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | *entry.as_mut() = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:174:39 [INFO] [stderr] | [INFO] [stderr] 174 | *entry.as_mut() = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::SingleCache` [INFO] [stderr] --> src/cache.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> SingleCache { [INFO] [stderr] 53 | | SingleCache { [INFO] [stderr] 54 | | entry: Mutex::new(Default::default()), [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | if let Some(i) = self.keys.get(&key).map(|i| *i) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.keys.get(&key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:320:24 [INFO] [stderr] | [INFO] [stderr] 320 | let mut keys = lane.keys.keys().map(|key| *key).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lane.keys.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:348:24 [INFO] [stderr] | [INFO] [stderr] 348 | let mut keys = lane.keys.keys().map(|key| *key).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lane.keys.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:376:24 [INFO] [stderr] | [INFO] [stderr] 376 | let mut keys = lane.keys.keys().map(|key| *key).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lane.keys.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/cache.rs:404:24 [INFO] [stderr] | [INFO] [stderr] 404 | let mut keys = lane.keys.keys().map(|key| *key).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `lane.keys.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | write_zeros(&mut file, (n_data as u64) * (size_of::() as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(n_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:42:19 [INFO] [stderr] | [INFO] [stderr] 42 | let pos = key as u64 * size_of::() as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | let pos = key as u64 * size_of::() as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/storage.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | let ptr: *mut u8 = transmute(dst); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `dst as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/storage.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | let ptr: *const u8 = transmute(src); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `src as *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::StorageMock` [INFO] [stderr] --> src/storage.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> StorageMock { [INFO] [stderr] 117 | | StorageMock { [INFO] [stderr] 118 | | data: HashMap::new(), [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 110 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:187:34 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(data, key as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:198:28 [INFO] [stderr] | [INFO] [stderr] 198 | let mut data = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:224:36 [INFO] [stderr] | [INFO] [stderr] 224 | let mut data = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:245:28 [INFO] [stderr] | [INFO] [stderr] 245 | let mut data = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/storage.rs:271:36 [INFO] [stderr] | [INFO] [stderr] 271 | let mut data = key as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/integration_test.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | assert_eq!(sum, n_data as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(n_data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/integration_test.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(sum, n_data as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(n_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "34e4db3b4bd8f45cffb9b379c81171fb56b1d4cdd173894a7e10f3dc5e690cd1"` [INFO] running `"docker" "rm" "-f" "34e4db3b4bd8f45cffb9b379c81171fb56b1d4cdd173894a7e10f3dc5e690cd1"` [INFO] [stdout] 34e4db3b4bd8f45cffb9b379c81171fb56b1d4cdd173894a7e10f3dc5e690cd1