[INFO] updating cached repository kohnakagawa/simple_md [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kohnakagawa/simple_md [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kohnakagawa/simple_md" "work/ex/clippy-test-run/sources/stable/gh/kohnakagawa/simple_md"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kohnakagawa/simple_md'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kohnakagawa/simple_md" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kohnakagawa/simple_md"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kohnakagawa/simple_md'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a18c56cf7b280d82acc11dee26cd5e3a03393bc8 [INFO] sha for GitHub repo kohnakagawa/simple_md: a18c56cf7b280d82acc11dee26cd5e3a03393bc8 [INFO] validating manifest of kohnakagawa/simple_md on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kohnakagawa/simple_md on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kohnakagawa/simple_md [INFO] finished frobbing kohnakagawa/simple_md [INFO] frobbed toml for kohnakagawa/simple_md written to work/ex/clippy-test-run/sources/stable/gh/kohnakagawa/simple_md/Cargo.toml [INFO] started frobbing kohnakagawa/simple_md [INFO] finished frobbing kohnakagawa/simple_md [INFO] frobbed toml for kohnakagawa/simple_md written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kohnakagawa/simple_md/Cargo.toml [INFO] crate kohnakagawa/simple_md has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kohnakagawa/simple_md against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kohnakagawa/simple_md:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0f7b7fbc3c82f2b8a06d2a48e90c016c373b2396ceca9a25c6676447e985406 [INFO] running `"docker" "start" "-a" "b0f7b7fbc3c82f2b8a06d2a48e90c016c373b2396ceca9a25c6676447e985406"` [INFO] [stderr] Checking rand v0.4.1 [INFO] [stderr] Checking md_simple v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/f64vec3.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | F64vec3 {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/f64vec3.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | F64vec3 {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/f64vec3.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | F64vec3 {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configmaker.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | density: density [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `density` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configmaker.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | density: density [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `density` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/configmaker.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | let z = (iz as f64) * s; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variables.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | Atom {r: r, v: v} [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variables.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | Atom {r: r, v: v} [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parameter.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | cl: cl, [INFO] [stderr] | ^^^^^^ help: replace it with: `cl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parameter.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | c0: c0, [INFO] [stderr] | ^^^^^^ help: replace it with: `c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/f64vec3.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | F64vec3 {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/f64vec3.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | F64vec3 {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/f64vec3.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | F64vec3 {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configmaker.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | density: density [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `density` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configmaker.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | density: density [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `density` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/configmaker.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | let z = (iz as f64) * s; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variables.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | Atom {r: r, v: v} [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/variables.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | Atom {r: r, v: v} [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parameter.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | cl: cl, [INFO] [stderr] | ^^^^^^ help: replace it with: `cl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parameter.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | c0: c0, [INFO] [stderr] | ^^^^^^ help: replace it with: `c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parameter.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | steps: 100000, [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parameter.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | steps: 100000, [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `norm` [INFO] [stderr] --> src/utils/f64vec3.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn norm(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/configmaker.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | let x = (ix as f64) * s; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(ix)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/configmaker.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | let y = (iy as f64) * s; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(iy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/configmaker.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | let z = (iz as f64) * s; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(iz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/variables.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | f.write(b"xyz file format\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: method is never used: `norm` [INFO] [stderr] --> src/utils/f64vec3.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn norm(&self) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fcalculator.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | pairs: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Pair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fcalculator.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | pointer: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fcalculator.rs:84:43 [INFO] [stderr] | [INFO] [stderr] 84 | sorted_list: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fcalculator.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | (0..n_atoms).into_iter().for_each(|i| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n_atoms)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `sorted_list`. [INFO] [stderr] --> src/fcalculator.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | for k in pointer[i]..pointer[i+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for in sorted_list.iter().take(pointer[i+1]).skip(pointer[i]) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/configmaker.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | let x = (ix as f64) * s; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(ix)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/configmaker.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | let y = (iy as f64) * s; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(iy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/configmaker.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | let z = (iz as f64) * s; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(iz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/meshlist.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | param.box_len.x / mx as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(mx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/meshlist.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | param.box_len.y / my as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(my)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/variables.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | f.write(b"xyz file format\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/meshlist.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | param.box_len.z / mz as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(mz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/meshlist.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / let partner: usize; [INFO] [stderr] 142 | | if i < j { [INFO] [stderr] 143 | | key = i; [INFO] [stderr] 144 | | partner = j; [INFO] [stderr] ... | [INFO] [stderr] 147 | | partner = i; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let partner = if i < j { ..; j } else { ..; i };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fcalculator.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | pairs: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Pair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fcalculator.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | pointer: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fcalculator.rs:84:43 [INFO] [stderr] | [INFO] [stderr] 84 | sorted_list: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fcalculator.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | (0..n_atoms).into_iter().for_each(|i| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n_atoms)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `sorted_list`. [INFO] [stderr] --> src/fcalculator.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | for k in pointer[i]..pointer[i+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for in sorted_list.iter().take(pointer[i+1]).skip(pointer[i]) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/meshlist.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | param.box_len.x / mx as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(mx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/meshlist.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | param.box_len.y / my as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(my)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/meshlist.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | param.box_len.z / mz as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(mz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:34:36 [INFO] [stderr] | [INFO] [stderr] 34 | pairs: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Pair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/meshlist.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / let partner: usize; [INFO] [stderr] 142 | | if i < j { [INFO] [stderr] 143 | | key = i; [INFO] [stderr] 144 | | partner = j; [INFO] [stderr] ... | [INFO] [stderr] 147 | | partner = i; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let partner = if i < j { ..; j } else { ..; i };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mdsystem.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(input_dir: &String) -> MDSystem { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:34:36 [INFO] [stderr] | [INFO] [stderr] 34 | pairs: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Pair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mdsystem.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(input_dir: &String) -> MDSystem { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `md_simple`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `md_simple`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b0f7b7fbc3c82f2b8a06d2a48e90c016c373b2396ceca9a25c6676447e985406"` [INFO] running `"docker" "rm" "-f" "b0f7b7fbc3c82f2b8a06d2a48e90c016c373b2396ceca9a25c6676447e985406"` [INFO] [stdout] b0f7b7fbc3c82f2b8a06d2a48e90c016c373b2396ceca9a25c6676447e985406