[INFO] updating cached repository kogai/tetris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kogai/tetris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/tetris" "work/ex/clippy-test-run/sources/stable/gh/kogai/tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kogai/tetris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/tetris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/tetris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc9559b92ff95da9e8a4d603b6e481171f7d1d2c [INFO] sha for GitHub repo kogai/tetris: bc9559b92ff95da9e8a4d603b6e481171f7d1d2c [INFO] validating manifest of kogai/tetris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kogai/tetris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kogai/tetris [INFO] finished frobbing kogai/tetris [INFO] frobbed toml for kogai/tetris written to work/ex/clippy-test-run/sources/stable/gh/kogai/tetris/Cargo.toml [INFO] started frobbing kogai/tetris [INFO] finished frobbing kogai/tetris [INFO] frobbed toml for kogai/tetris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/tetris/Cargo.toml [INFO] crate kogai/tetris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kogai/tetris against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/tetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7bb283f32d633b03b304aec82902bdced76ea7e15a5dcc0f98488f7dc38b979 [INFO] running `"docker" "start" "-a" "d7bb283f32d633b03b304aec82902bdced76ea7e15a5dcc0f98488f7dc38b979"` [INFO] [stderr] Checking tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | Controller { tx: tx } [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shape.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/command.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | Controller { tx: tx } [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `send` [INFO] [stderr] --> src/command.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn send(&self, command: Command) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/command.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/command.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `send` [INFO] [stderr] --> src/command.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn send(&self, command: Command) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/command.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/command.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn show(grid: &Grid) -> String { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn show(grid: &Grid) -> String { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shape.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match self { [INFO] [stderr] 117 | | &Square(ref inner) => Square(inner.move_to(command)), [INFO] [stderr] 118 | | &BracketL(ref inner) => BracketL(inner.move_to(command)), [INFO] [stderr] 119 | | &BracketR(ref inner) => BracketR(inner.move_to(command)), [INFO] [stderr] 120 | | &Straight(ref inner) => Straight(inner.move_to(command)), [INFO] [stderr] 121 | | &TLike(ref inner) => TLike(inner.move_to(command)), [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *self { [INFO] [stderr] 117 | Square(ref inner) => Square(inner.move_to(command)), [INFO] [stderr] 118 | BracketL(ref inner) => BracketL(inner.move_to(command)), [INFO] [stderr] 119 | BracketR(ref inner) => BracketR(inner.move_to(command)), [INFO] [stderr] 120 | Straight(ref inner) => Straight(inner.move_to(command)), [INFO] [stderr] 121 | TLike(ref inner) => TLike(inner.move_to(command)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shape.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match self { [INFO] [stderr] 128 | | &Square(ref inner) | [INFO] [stderr] 129 | | &BracketL(ref inner) | [INFO] [stderr] 130 | | &BracketR(ref inner) | [INFO] [stderr] 131 | | &Straight(ref inner) | [INFO] [stderr] 132 | | &TLike(ref inner) => inner.get_positions(), [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *self { [INFO] [stderr] 128 | Square(ref inner) | [INFO] [stderr] 129 | BracketL(ref inner) | [INFO] [stderr] 130 | BracketR(ref inner) | [INFO] [stderr] 131 | Straight(ref inner) | [INFO] [stderr] 132 | TLike(ref inner) => inner.get_positions(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shape.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | / match self { [INFO] [stderr] 141 | | &Square(ref inner) | [INFO] [stderr] 142 | | &BracketL(ref inner) | [INFO] [stderr] 143 | | &BracketR(ref inner) | [INFO] [stderr] 144 | | &Straight(ref inner) | [INFO] [stderr] 145 | | &TLike(ref inner) => show(&inner.grid), [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 140 | match *self { [INFO] [stderr] 141 | Square(ref inner) | [INFO] [stderr] 142 | BracketL(ref inner) | [INFO] [stderr] 143 | BracketR(ref inner) | [INFO] [stderr] 144 | Straight(ref inner) | [INFO] [stderr] 145 | TLike(ref inner) => show(&inner.grid), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shape.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match self { [INFO] [stderr] 117 | | &Square(ref inner) => Square(inner.move_to(command)), [INFO] [stderr] 118 | | &BracketL(ref inner) => BracketL(inner.move_to(command)), [INFO] [stderr] 119 | | &BracketR(ref inner) => BracketR(inner.move_to(command)), [INFO] [stderr] 120 | | &Straight(ref inner) => Straight(inner.move_to(command)), [INFO] [stderr] 121 | | &TLike(ref inner) => TLike(inner.move_to(command)), [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *self { [INFO] [stderr] 117 | Square(ref inner) => Square(inner.move_to(command)), [INFO] [stderr] 118 | BracketL(ref inner) => BracketL(inner.move_to(command)), [INFO] [stderr] 119 | BracketR(ref inner) => BracketR(inner.move_to(command)), [INFO] [stderr] 120 | Straight(ref inner) => Straight(inner.move_to(command)), [INFO] [stderr] 121 | TLike(ref inner) => TLike(inner.move_to(command)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shape.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match self { [INFO] [stderr] 128 | | &Square(ref inner) | [INFO] [stderr] 129 | | &BracketL(ref inner) | [INFO] [stderr] 130 | | &BracketR(ref inner) | [INFO] [stderr] 131 | | &Straight(ref inner) | [INFO] [stderr] 132 | | &TLike(ref inner) => inner.get_positions(), [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *self { [INFO] [stderr] 128 | Square(ref inner) | [INFO] [stderr] 129 | BracketL(ref inner) | [INFO] [stderr] 130 | BracketR(ref inner) | [INFO] [stderr] 131 | Straight(ref inner) | [INFO] [stderr] 132 | TLike(ref inner) => inner.get_positions(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/shape.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | / match self { [INFO] [stderr] 141 | | &Square(ref inner) | [INFO] [stderr] 142 | | &BracketL(ref inner) | [INFO] [stderr] 143 | | &BracketR(ref inner) | [INFO] [stderr] 144 | | &Straight(ref inner) | [INFO] [stderr] 145 | | &TLike(ref inner) => show(&inner.grid), [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 140 | match *self { [INFO] [stderr] 141 | Square(ref inner) | [INFO] [stderr] 142 | BracketL(ref inner) | [INFO] [stderr] 143 | BracketR(ref inner) | [INFO] [stderr] 144 | Straight(ref inner) | [INFO] [stderr] 145 | TLike(ref inner) => show(&inner.grid), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.55s [INFO] running `"docker" "inspect" "d7bb283f32d633b03b304aec82902bdced76ea7e15a5dcc0f98488f7dc38b979"` [INFO] running `"docker" "rm" "-f" "d7bb283f32d633b03b304aec82902bdced76ea7e15a5dcc0f98488f7dc38b979"` [INFO] [stdout] d7bb283f32d633b03b304aec82902bdced76ea7e15a5dcc0f98488f7dc38b979