[INFO] updating cached repository kogai/rust-ds-flatfs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kogai/rust-ds-flatfs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kogai/rust-ds-flatfs" "work/ex/clippy-test-run/sources/stable/gh/kogai/rust-ds-flatfs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kogai/rust-ds-flatfs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kogai/rust-ds-flatfs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/rust-ds-flatfs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/rust-ds-flatfs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2a7a5fcac8509296bb5e275c7702ed4da413dbd2
[INFO] sha for GitHub repo kogai/rust-ds-flatfs: 2a7a5fcac8509296bb5e275c7702ed4da413dbd2
[INFO] validating manifest of kogai/rust-ds-flatfs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kogai/rust-ds-flatfs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kogai/rust-ds-flatfs
[INFO] finished frobbing kogai/rust-ds-flatfs
[INFO] frobbed toml for kogai/rust-ds-flatfs written to work/ex/clippy-test-run/sources/stable/gh/kogai/rust-ds-flatfs/Cargo.toml
[INFO] started frobbing kogai/rust-ds-flatfs
[INFO] finished frobbing kogai/rust-ds-flatfs
[INFO] frobbed toml for kogai/rust-ds-flatfs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/rust-ds-flatfs/Cargo.toml
[INFO] crate kogai/rust-ds-flatfs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kogai/rust-ds-flatfs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/rust-ds-flatfs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 13bf48a2cc474a506247508408b02c8970d019072c322a1c5e16c230ef255917
[INFO] running `"docker" "start" "-a" "13bf48a2cc474a506247508408b02c8970d019072c322a1c5e16c230ef255917"`
[INFO] [stderr]     Checking rust-ds-flatfs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lib.rs:6:13
[INFO] [stderr]   |
[INFO] [stderr] 6 | const EXT: &'static str = "data";
[INFO] [stderr]   |            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lib.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 | const SHARDING: &'static str = "SHARDING";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lib.rs:8:16
[INFO] [stderr]   |
[INFO] [stderr] 8 | const PREFIX: &'static str = "/repo/flatfs/shard/";
[INFO] [stderr]   |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]    --> src/lib.rs:114:18
[INFO] [stderr]     |
[INFO] [stderr] 114 |         let mut file = (&self).path.clone();
[INFO] [stderr]     |                        ^^^^^^^ help: try this: `self.path`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ref_in_deref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lib.rs:6:13
[INFO] [stderr]   |
[INFO] [stderr] 6 | const EXT: &'static str = "data";
[INFO] [stderr]   |            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lib.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 | const SHARDING: &'static str = "SHARDING";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lib.rs:8:16
[INFO] [stderr]   |
[INFO] [stderr] 8 | const PREFIX: &'static str = "/repo/flatfs/shard/";
[INFO] [stderr]   |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]    --> src/lib.rs:114:18
[INFO] [stderr]     |
[INFO] [stderr] 114 |         let mut file = (&self).path.clone();
[INFO] [stderr]     |                        ^^^^^^^ help: try this: `self.path`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ref_in_deref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:29:30
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn get_dir_name(&self, key: &String) -> String {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |                     .split("/");
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     .expect(format!("Path {:?} can not convert to str", &rest_path).as_ref())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Path {:?} can not convert to str", &rest_path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:73:8
[INFO] [stderr]    |
[INFO] [stderr] 73 |                         .expect(format!("shard_length [{}] can not parse as integer.", shard_length).as_ref()),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("shard_length [{}] can not parse as integer.", shard_length))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:29:30
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn get_dir_name(&self, key: &String) -> String {
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |                     .split("/");
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     .expect(format!("Path {:?} can not convert to str", &rest_path).as_ref())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Path {:?} can not convert to str", &rest_path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:73:8
[INFO] [stderr]    |
[INFO] [stderr] 73 |                         .expect(format!("shard_length [{}] can not parse as integer.", shard_length).as_ref()),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("shard_length [{}] can not parse as integer.", shard_length))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:177:19
[INFO] [stderr]     |
[INFO] [stderr] 177 |             let sharding = format!("Test");
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Test".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.64s
[INFO] running `"docker" "inspect" "13bf48a2cc474a506247508408b02c8970d019072c322a1c5e16c230ef255917"`
[INFO] running `"docker" "rm" "-f" "13bf48a2cc474a506247508408b02c8970d019072c322a1c5e16c230ef255917"`
[INFO] [stdout] 13bf48a2cc474a506247508408b02c8970d019072c322a1c5e16c230ef255917