[INFO] updating cached repository kogai/henacat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kogai/henacat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/henacat" "work/ex/clippy-test-run/sources/stable/gh/kogai/henacat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kogai/henacat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/henacat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/henacat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/henacat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0592f6eb1787b95e192559387d766084ad1ca676 [INFO] sha for GitHub repo kogai/henacat: 0592f6eb1787b95e192559387d766084ad1ca676 [INFO] validating manifest of kogai/henacat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kogai/henacat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kogai/henacat [INFO] finished frobbing kogai/henacat [INFO] frobbed toml for kogai/henacat written to work/ex/clippy-test-run/sources/stable/gh/kogai/henacat/Cargo.toml [INFO] started frobbing kogai/henacat [INFO] finished frobbing kogai/henacat [INFO] frobbed toml for kogai/henacat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/henacat/Cargo.toml [INFO] crate kogai/henacat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kogai/henacat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/henacat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6409274e0af35c1b6b5a13f1299b123bffac7da663cff69a07c73800621faad [INFO] running `"docker" "start" "-a" "b6409274e0af35c1b6b5a13f1299b123bffac7da663cff69a07c73800621faad"` [INFO] [stderr] Checking henacat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | let mut request_line = headers.nth(0).unwrap().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | format!("Server: Modoki/0.1"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Server: Modoki/0.1".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | format!("Connection: close"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Connection: close".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | format!("{}", request_header.content_type.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `request_header.content_type.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/content_type.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | let extension = x.split(".").nth(1).unwrap_or("html").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/content_type.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match self { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 32 | | &ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | | &ContentType::TextCss => "text/css", [INFO] [stderr] 34 | | &ContentType::TextPlain => "text/plain", [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => "application/octet-stream", [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match *self { [INFO] [stderr] 32 | ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | ContentType::TextCss => "text/css", [INFO] [stderr] 34 | ContentType::TextPlain => "text/plain", [INFO] [stderr] 35 | ContentType::ImageJpg => "image/jpeg", [INFO] [stderr] 36 | ContentType::ImagePng => "image/png", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/status.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | / match self { [INFO] [stderr] 98 | | &Continue => "100 Continue", [INFO] [stderr] 99 | | &SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | | &Ok => "200 Ok", [INFO] [stderr] ... | [INFO] [stderr] 137 | | &HttpVersionNotSupported => "505 Http Version Not Supported", [INFO] [stderr] 138 | | }.to_string() [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *self { [INFO] [stderr] 98 | Continue => "100 Continue", [INFO] [stderr] 99 | SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | Ok => "200 Ok", [INFO] [stderr] 101 | Created => "201 Created", [INFO] [stderr] 102 | Accepted => "202 Accepted", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | let mut request_line = headers.nth(0).unwrap().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | format!("Server: Modoki/0.1"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Server: Modoki/0.1".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | format!("Connection: close"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Connection: close".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | format!("{}", request_header.content_type.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `request_header.content_type.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/content_type.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | let extension = x.split(".").nth(1).unwrap_or("html").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/content_type.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match self { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 32 | | &ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | | &ContentType::TextCss => "text/css", [INFO] [stderr] 34 | | &ContentType::TextPlain => "text/plain", [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => "application/octet-stream", [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match *self { [INFO] [stderr] 32 | ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | ContentType::TextCss => "text/css", [INFO] [stderr] 34 | ContentType::TextPlain => "text/plain", [INFO] [stderr] 35 | ContentType::ImageJpg => "image/jpeg", [INFO] [stderr] 36 | ContentType::ImagePng => "image/png", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/status.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | / match self { [INFO] [stderr] 98 | | &Continue => "100 Continue", [INFO] [stderr] 99 | | &SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | | &Ok => "200 Ok", [INFO] [stderr] ... | [INFO] [stderr] 137 | | &HttpVersionNotSupported => "505 Http Version Not Supported", [INFO] [stderr] 138 | | }.to_string() [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *self { [INFO] [stderr] 98 | Continue => "100 Continue", [INFO] [stderr] 99 | SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | Ok => "200 Ok", [INFO] [stderr] 101 | Created => "201 Created", [INFO] [stderr] 102 | Accepted => "202 Accepted", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/client.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | Client { host: host } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/client.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | Client { host: host } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | let mut request_line = headers.nth(0).unwrap().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | format!("Server: Modoki/0.1"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Server: Modoki/0.1".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | format!("Connection: close"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Connection: close".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | format!("{}", request_header.content_type.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `request_header.content_type.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/content_type.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | let extension = x.split(".").nth(1).unwrap_or("html").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/content_type.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match self { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 32 | | &ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | | &ContentType::TextCss => "text/css", [INFO] [stderr] 34 | | &ContentType::TextPlain => "text/plain", [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => "application/octet-stream", [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match *self { [INFO] [stderr] 32 | ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | ContentType::TextCss => "text/css", [INFO] [stderr] 34 | ContentType::TextPlain => "text/plain", [INFO] [stderr] 35 | ContentType::ImageJpg => "image/jpeg", [INFO] [stderr] 36 | ContentType::ImagePng => "image/png", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/status.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | / match self { [INFO] [stderr] 98 | | &Continue => "100 Continue", [INFO] [stderr] 99 | | &SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | | &Ok => "200 Ok", [INFO] [stderr] ... | [INFO] [stderr] 137 | | &HttpVersionNotSupported => "505 Http Version Not Supported", [INFO] [stderr] 138 | | }.to_string() [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *self { [INFO] [stderr] 98 | Continue => "100 Continue", [INFO] [stderr] 99 | SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | Ok => "200 Ok", [INFO] [stderr] 101 | Created => "201 Created", [INFO] [stderr] 102 | Accepted => "202 Accepted", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | let mut request_line = headers.nth(0).unwrap().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | format!("Server: Modoki/0.1"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Server: Modoki/0.1".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | format!("Connection: close"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Connection: close".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | format!("{}", request_header.content_type.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `request_header.content_type.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/content_type.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | let extension = x.split(".").nth(1).unwrap_or("html").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/content_type.rs:31:28 [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match self { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 32 | | &ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | | &ContentType::TextCss => "text/css", [INFO] [stderr] 34 | | &ContentType::TextPlain => "text/plain", [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => "application/octet-stream", [INFO] [stderr] 39 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | let content_type = match *self { [INFO] [stderr] 32 | ContentType::TextHtml => "text/html", [INFO] [stderr] 33 | ContentType::TextCss => "text/css", [INFO] [stderr] 34 | ContentType::TextPlain => "text/plain", [INFO] [stderr] 35 | ContentType::ImageJpg => "image/jpeg", [INFO] [stderr] 36 | ContentType::ImagePng => "image/png", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/status.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | / match self { [INFO] [stderr] 98 | | &Continue => "100 Continue", [INFO] [stderr] 99 | | &SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | | &Ok => "200 Ok", [INFO] [stderr] ... | [INFO] [stderr] 137 | | &HttpVersionNotSupported => "505 Http Version Not Supported", [INFO] [stderr] 138 | | }.to_string() [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *self { [INFO] [stderr] 98 | Continue => "100 Continue", [INFO] [stderr] 99 | SwitchingProtocols => "101 Switching Protocols", [INFO] [stderr] 100 | Ok => "200 Ok", [INFO] [stderr] 101 | Created => "201 Created", [INFO] [stderr] 102 | Accepted => "202 Accepted", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `"docker" "inspect" "b6409274e0af35c1b6b5a13f1299b123bffac7da663cff69a07c73800621faad"` [INFO] running `"docker" "rm" "-f" "b6409274e0af35c1b6b5a13f1299b123bffac7da663cff69a07c73800621faad"` [INFO] [stdout] b6409274e0af35c1b6b5a13f1299b123bffac7da663cff69a07c73800621faad