[INFO] updating cached repository knutaf/poe_quality_sets [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/knutaf/poe_quality_sets [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/knutaf/poe_quality_sets" "work/ex/clippy-test-run/sources/stable/gh/knutaf/poe_quality_sets"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/knutaf/poe_quality_sets'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/knutaf/poe_quality_sets" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knutaf/poe_quality_sets"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knutaf/poe_quality_sets'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2dfcedb554d49334219963936764622c589bbe1 [INFO] sha for GitHub repo knutaf/poe_quality_sets: f2dfcedb554d49334219963936764622c589bbe1 [INFO] validating manifest of knutaf/poe_quality_sets on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of knutaf/poe_quality_sets on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing knutaf/poe_quality_sets [INFO] finished frobbing knutaf/poe_quality_sets [INFO] frobbed toml for knutaf/poe_quality_sets written to work/ex/clippy-test-run/sources/stable/gh/knutaf/poe_quality_sets/Cargo.toml [INFO] started frobbing knutaf/poe_quality_sets [INFO] finished frobbing knutaf/poe_quality_sets [INFO] frobbed toml for knutaf/poe_quality_sets written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knutaf/poe_quality_sets/Cargo.toml [INFO] crate knutaf/poe_quality_sets has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting knutaf/poe_quality_sets against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knutaf/poe_quality_sets:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d65cc1043d36d6f8e32f0935b5f7284f095bef9dd243084a6dfb7f2a9f34589a [INFO] running `"docker" "start" "-a" "d65cc1043d36d6f8e32f0935b5f7284f095bef9dd243084a6dfb7f2a9f34589a"` [INFO] [stderr] Checking poe_quality_sets v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | let ret = (combo, best_num_sets); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | let ret = (combo, best_num_sets); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:3:104 [INFO] [stderr] | [INFO] [stderr] 3 | fn find_good_ordering(orig_target : u32, max_possible_sets : u32, target : u32, num_sets : u32, nums : &Vec) -> (Vec, u32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 3 | fn find_good_ordering(orig_target : u32, max_possible_sets : u32, target : u32, num_sets : u32, nums : &[u32]) -> (Vec, u32) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `nums.clone()` to [INFO] [stderr] | [INFO] [stderr] 49| (nums.to_owned(), num_sets) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | combo.extend(best_sub_combo.iter().map(|x| { *x })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `best_sub_combo.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | let max_possible_sets : u32 = nums.iter().cloned().fold(0, |acc, x| { acc + x }) / target; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:3:104 [INFO] [stderr] | [INFO] [stderr] 3 | fn find_good_ordering(orig_target : u32, max_possible_sets : u32, target : u32, num_sets : u32, nums : &Vec) -> (Vec, u32) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 3 | fn find_good_ordering(orig_target : u32, max_possible_sets : u32, target : u32, num_sets : u32, nums : &[u32]) -> (Vec, u32) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `nums.clone()` to [INFO] [stderr] | [INFO] [stderr] 49| (nums.to_owned(), num_sets) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | combo.extend(best_sub_combo.iter().map(|x| { *x })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `best_sub_combo.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | let max_possible_sets : u32 = nums.iter().cloned().fold(0, |acc, x| { acc + x }) / target; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "d65cc1043d36d6f8e32f0935b5f7284f095bef9dd243084a6dfb7f2a9f34589a"` [INFO] running `"docker" "rm" "-f" "d65cc1043d36d6f8e32f0935b5f7284f095bef9dd243084a6dfb7f2a9f34589a"` [INFO] [stdout] d65cc1043d36d6f8e32f0935b5f7284f095bef9dd243084a6dfb7f2a9f34589a