[INFO] updating cached repository knoby/cybercon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/knoby/cybercon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/knoby/cybercon" "work/ex/clippy-test-run/sources/stable/gh/knoby/cybercon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/knoby/cybercon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/knoby/cybercon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knoby/cybercon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knoby/cybercon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebd97c2ba4c49d393d97c4ef1c6c3ca90988d22a [INFO] sha for GitHub repo knoby/cybercon: ebd97c2ba4c49d393d97c4ef1c6c3ca90988d22a [INFO] validating manifest of knoby/cybercon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of knoby/cybercon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing knoby/cybercon [INFO] finished frobbing knoby/cybercon [INFO] frobbed toml for knoby/cybercon written to work/ex/clippy-test-run/sources/stable/gh/knoby/cybercon/Cargo.toml [INFO] started frobbing knoby/cybercon [INFO] finished frobbing knoby/cybercon [INFO] frobbed toml for knoby/cybercon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knoby/cybercon/Cargo.toml [INFO] crate knoby/cybercon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting knoby/cybercon against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knoby/cybercon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9aacd7e3dfde799c7ea50ddc8f521f78c4fe24bafa9bf109c7ac8dded39f2e8 [INFO] running `"docker" "start" "-a" "a9aacd7e3dfde799c7ea50ddc8f521f78c4fe24bafa9bf109c7ac8dded39f2e8"` [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking cybercon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cm_com/msg_gen.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | let code: u8; [INFO] [stderr] | _____^ [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | if toggle { [INFO] [stderr] 46 | | code = 0x08; [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | code = 0x00; [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let code = if toggle { 0x08 } else { 0x00 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | cm_com::connect("/dev/ttyUSB0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cm_com/msg_gen.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | let code: u8; [INFO] [stderr] | _____^ [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | if toggle { [INFO] [stderr] 46 | | code = 0x08; [INFO] [stderr] 47 | | } else { [INFO] [stderr] 48 | | code = 0x00; [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let code = if toggle { 0x08 } else { 0x00 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | cm_com::connect("/dev/ttyUSB0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "a9aacd7e3dfde799c7ea50ddc8f521f78c4fe24bafa9bf109c7ac8dded39f2e8"` [INFO] running `"docker" "rm" "-f" "a9aacd7e3dfde799c7ea50ddc8f521f78c4fe24bafa9bf109c7ac8dded39f2e8"` [INFO] [stdout] a9aacd7e3dfde799c7ea50ddc8f521f78c4fe24bafa9bf109c7ac8dded39f2e8