[INFO] updating cached repository knknkn1162/minigrep_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/knknkn1162/minigrep_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/knknkn1162/minigrep_test" "work/ex/clippy-test-run/sources/stable/gh/knknkn1162/minigrep_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/knknkn1162/minigrep_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/knknkn1162/minigrep_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/minigrep_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/minigrep_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 356bcdcd29ed0697af8f2ab4f34cd39301e0d0dc [INFO] sha for GitHub repo knknkn1162/minigrep_test: 356bcdcd29ed0697af8f2ab4f34cd39301e0d0dc [INFO] validating manifest of knknkn1162/minigrep_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of knknkn1162/minigrep_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing knknkn1162/minigrep_test [INFO] finished frobbing knknkn1162/minigrep_test [INFO] frobbed toml for knknkn1162/minigrep_test written to work/ex/clippy-test-run/sources/stable/gh/knknkn1162/minigrep_test/Cargo.toml [INFO] started frobbing knknkn1162/minigrep_test [INFO] finished frobbing knknkn1162/minigrep_test [INFO] frobbed toml for knknkn1162/minigrep_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/minigrep_test/Cargo.toml [INFO] crate knknkn1162/minigrep_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting knknkn1162/minigrep_test against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/minigrep_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a0ff97d7df2f9c9c17295068a8ee45bfab9705ad6b8d381d542c01565b762cb [INFO] running `"docker" "start" "-a" "9a0ff97d7df2f9c9c17295068a8ee45bfab9705ad6b8d381d542c01565b762cb"` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | case_sensitive: case_sensitive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | case_sensitive: case_sensitive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / search(&config.query, &contents, !config.case_sensitive).into_iter() [INFO] [stderr] 14 | | .inspect(|&line| println!("{}", line)).collect::>(); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / search(&config.query, &contents, !config.case_sensitive).into_iter() [INFO] [stderr] 14 | | .inspect(|&line| println!("{}", line)).collect::>(); [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / contents.lines() [INFO] [stderr] 46 | | .filter_map(|line| { [INFO] [stderr] 47 | | let new_line = if is_case_insensitive {line.to_lowercase()} else {line.to_owned()}; [INFO] [stderr] 48 | | if new_line.contains(&new_query) { Some(line) } else { None } [INFO] [stderr] 49 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / search(&config.query, &contents, !config.case_sensitive).into_iter() [INFO] [stderr] 14 | | .inspect(|&line| println!("{}", line)).collect::>(); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / search(&config.query, &contents, !config.case_sensitive).into_iter() [INFO] [stderr] 14 | | .inspect(|&line| println!("{}", line)).collect::>(); [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / contents.lines() [INFO] [stderr] 46 | | .filter_map(|line| { [INFO] [stderr] 47 | | let new_line = if is_case_insensitive {line.to_lowercase()} else {line.to_owned()}; [INFO] [stderr] 48 | | if new_line.contains(&new_query) { Some(line) } else { None } [INFO] [stderr] 49 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "9a0ff97d7df2f9c9c17295068a8ee45bfab9705ad6b8d381d542c01565b762cb"` [INFO] running `"docker" "rm" "-f" "9a0ff97d7df2f9c9c17295068a8ee45bfab9705ad6b8d381d542c01565b762cb"` [INFO] [stdout] 9a0ff97d7df2f9c9c17295068a8ee45bfab9705ad6b8d381d542c01565b762cb