[INFO] updating cached repository klacabane/phono [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/klacabane/phono [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/klacabane/phono" "work/ex/clippy-test-run/sources/stable/gh/klacabane/phono"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/klacabane/phono'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/klacabane/phono" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klacabane/phono"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klacabane/phono'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f3e58ad21295bc908d9a6032fc590365ff7c1358 [INFO] sha for GitHub repo klacabane/phono: f3e58ad21295bc908d9a6032fc590365ff7c1358 [INFO] validating manifest of klacabane/phono on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of klacabane/phono on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing klacabane/phono [INFO] finished frobbing klacabane/phono [INFO] frobbed toml for klacabane/phono written to work/ex/clippy-test-run/sources/stable/gh/klacabane/phono/Cargo.toml [INFO] started frobbing klacabane/phono [INFO] finished frobbing klacabane/phono [INFO] frobbed toml for klacabane/phono written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klacabane/phono/Cargo.toml [INFO] crate klacabane/phono has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting klacabane/phono against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klacabane/phono:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f08700790cb311af909b23f2ebebc03bda88d0f219dd519d1465a306b6a4b260 [INFO] running `"docker" "start" "-a" "f08700790cb311af909b23f2ebebc03bda88d0f219dd519d1465a306b6a4b260"` [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking tui v0.2.1 [INFO] [stderr] Checking phono v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::time` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Modifier` [INFO] [stderr] --> src/main.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | use tui::style::{Color, Modifier, Style}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Modifier` [INFO] [stderr] --> src/main.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | use tui::style::{Color, Modifier, Style}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clock_tx` [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let clock_tx = tx.clone(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_clock_tx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `style` [INFO] [stderr] --> src/main.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | let style = Style::default().fg(Color::Black).bg(Color::White); [INFO] [stderr] | ^^^^^ help: consider using `_style` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `download` [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | fn download(url: &str) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `selected` [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | selected: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Tick` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | Tick, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clock_tx` [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let clock_tx = tx.clone(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_clock_tx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `style` [INFO] [stderr] --> src/main.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | let style = Style::default().fg(Color::Black).bg(Color::White); [INFO] [stderr] | ^^^^^ help: consider using `_style` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | Event::Input(input) => match input { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 107 | | event::Key::Char('q') => { [INFO] [stderr] 108 | | break; [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | Event::Input(input) => if let event::Key::Char('q') = input { [INFO] [stderr] 107 | break; [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function is never used: `download` [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | fn download(url: &str) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `selected` [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | selected: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Tick` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | Tick, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | Event::Input(input) => match input { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 107 | | event::Key::Char('q') => { [INFO] [stderr] 108 | | break; [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | Event::Input(input) => if let event::Key::Char('q') = input { [INFO] [stderr] 107 | break; [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.02s [INFO] running `"docker" "inspect" "f08700790cb311af909b23f2ebebc03bda88d0f219dd519d1465a306b6a4b260"` [INFO] running `"docker" "rm" "-f" "f08700790cb311af909b23f2ebebc03bda88d0f219dd519d1465a306b6a4b260"` [INFO] [stdout] f08700790cb311af909b23f2ebebc03bda88d0f219dd519d1465a306b6a4b260