[INFO] updating cached repository kisom/cbacklight
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kisom/cbacklight
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kisom/cbacklight" "work/ex/clippy-test-run/sources/stable/gh/kisom/cbacklight"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kisom/cbacklight'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kisom/cbacklight" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kisom/cbacklight"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kisom/cbacklight'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c0bbe7c5c5b631726742bc97833daef1adac6ba0
[INFO] sha for GitHub repo kisom/cbacklight: c0bbe7c5c5b631726742bc97833daef1adac6ba0
[INFO] validating manifest of kisom/cbacklight on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kisom/cbacklight on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kisom/cbacklight
[INFO] finished frobbing kisom/cbacklight
[INFO] frobbed toml for kisom/cbacklight written to work/ex/clippy-test-run/sources/stable/gh/kisom/cbacklight/Cargo.toml
[INFO] started frobbing kisom/cbacklight
[INFO] finished frobbing kisom/cbacklight
[INFO] frobbed toml for kisom/cbacklight written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kisom/cbacklight/Cargo.toml
[INFO] crate kisom/cbacklight has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kisom/cbacklight against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kisom/cbacklight:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e9ac8ec0ee2b5f96e9d165f8eeb9bed870ab4ce774cd1b94f813b7d031c66ab0
[INFO] running `"docker" "start" "-a" "e9ac8ec0ee2b5f96e9d165f8eeb9bed870ab4ce774cd1b94f813b7d031c66ab0"`
[INFO] [stderr]     Checking cbacklight v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return ((current as f32 / max as f32) * 100.0) as u16;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((current as f32 / max as f32) * 100.0) as u16`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return (ival / 100) as u16;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(ival / 100) as u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     return buf.to_str().unwrap().to_owned();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.to_str().unwrap().to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return ((current as f32 / max as f32) * 100.0) as u16;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((current as f32 / max as f32) * 100.0) as u16`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return (ival / 100) as u16;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(ival / 100) as u16`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     return buf.to_str().unwrap().to_owned();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.to_str().unwrap().to_owned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:24:14
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return ((current as f32 / max as f32) * 100.0) as u16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^ help: try: `f32::from(current)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return ((current as f32 / max as f32) * 100.0) as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: try: `f32::from(max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:28:21
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let ival: u32 = (max as u32) * (percent as u32);
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: try: `u32::from(max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:28:36
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let ival: u32 = (max as u32) * (percent as u32);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: try: `u32::from(percent)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:69:19
[INFO] [stderr]    |
[INFO] [stderr] 69 |     if percent == "-h".to_string() {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: try: `"-h"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:24:14
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return ((current as f32 / max as f32) * 100.0) as u16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^ help: try: `f32::from(current)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return ((current as f32 / max as f32) * 100.0) as u16;
[INFO] [stderr]    |                               ^^^^^^^^^^ help: try: `f32::from(max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:28:21
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let ival: u32 = (max as u32) * (percent as u32);
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: try: `u32::from(max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:28:36
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let ival: u32 = (max as u32) * (percent as u32);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: try: `u32::from(percent)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:69:19
[INFO] [stderr]    |
[INFO] [stderr] 69 |     if percent == "-h".to_string() {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: try: `"-h"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.54s
[INFO] running `"docker" "inspect" "e9ac8ec0ee2b5f96e9d165f8eeb9bed870ab4ce774cd1b94f813b7d031c66ab0"`
[INFO] running `"docker" "rm" "-f" "e9ac8ec0ee2b5f96e9d165f8eeb9bed870ab4ce774cd1b94f813b7d031c66ab0"`
[INFO] [stdout] e9ac8ec0ee2b5f96e9d165f8eeb9bed870ab4ce774cd1b94f813b7d031c66ab0