[INFO] updating cached repository kirkpetersen/rust-examples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kirkpetersen/rust-examples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kirkpetersen/rust-examples" "work/ex/clippy-test-run/sources/stable/gh/kirkpetersen/rust-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirkpetersen/rust-examples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kirkpetersen/rust-examples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirkpetersen/rust-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirkpetersen/rust-examples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 20954d18a7265595c5bbee489e379e576b78dcd3 [INFO] sha for GitHub repo kirkpetersen/rust-examples: 20954d18a7265595c5bbee489e379e576b78dcd3 [INFO] validating manifest of kirkpetersen/rust-examples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kirkpetersen/rust-examples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kirkpetersen/rust-examples [INFO] finished frobbing kirkpetersen/rust-examples [INFO] frobbed toml for kirkpetersen/rust-examples written to work/ex/clippy-test-run/sources/stable/gh/kirkpetersen/rust-examples/Cargo.toml [INFO] started frobbing kirkpetersen/rust-examples [INFO] finished frobbing kirkpetersen/rust-examples [INFO] frobbed toml for kirkpetersen/rust-examples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirkpetersen/rust-examples/Cargo.toml [INFO] crate kirkpetersen/rust-examples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kirkpetersen/rust-examples against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirkpetersen/rust-examples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 333409a5f6afa4ce105cddde34dae72939cfbae732168390e6b676c6243f8c2a [INFO] running `"docker" "start" "-a" "333409a5f6afa4ce105cddde34dae72939cfbae732168390e6b676c6243f8c2a"` [INFO] [stderr] Checking rust-examples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | println!("x: {:?}", TrieNode::new(0x0a010101, 0x01)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0a01_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/trie.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | key: 0x0a010101, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0a01_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | println!("x: {:?}", TrieNode::new(0x0a010101, 0x01)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0a01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/duplicates.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn contains_duplicates(array : &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/duplicates.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn find_first_duplicate(array : &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parenthesis.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | } else if c == '[' { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 12 | | stack.push(c); [INFO] [stderr] 13 | | } else if c == ')' { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parenthesis.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | if c == '(' { [INFO] [stderr] | _____________________^ [INFO] [stderr] 10 | | stack.push(c); [INFO] [stderr] 11 | | } else if c == '[' { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parenthesis.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | stack.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-examples`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/duplicates.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn contains_duplicates(array : &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/duplicates.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn find_first_duplicate(array : &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parenthesis.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | } else if c == '[' { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 12 | | stack.push(c); [INFO] [stderr] 13 | | } else if c == ')' { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parenthesis.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | if c == '(' { [INFO] [stderr] | _____________________^ [INFO] [stderr] 10 | | stack.push(c); [INFO] [stderr] 11 | | } else if c == '[' { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parenthesis.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | stack.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-examples`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "333409a5f6afa4ce105cddde34dae72939cfbae732168390e6b676c6243f8c2a"` [INFO] running `"docker" "rm" "-f" "333409a5f6afa4ce105cddde34dae72939cfbae732168390e6b676c6243f8c2a"` [INFO] [stdout] 333409a5f6afa4ce105cddde34dae72939cfbae732168390e6b676c6243f8c2a